[Regression 1.43.0-wmf.10] Desktop VisualEditor insert paragraph workflow not legible
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson
	Jun 17 2024, 9:46 PM

Description

NOTE: This is a regression of enabling CSS variables on OOUI. Will hopefully be fixed by T366197.

Steps to replicate the issue (include links if applicable):

Visit https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Dog&veaction=edit
Move mouse underneath "From Wikipedia,.." so "Insert paragraph appears"
Click and type

What happens?:
White text on gray background

Screenshot 2024-06-24 at 1.35.06 PM.png (495×922 px, 188 KB)

What should have happened instead?:

Gray text on black background

NOTE: This does not need to pass WCAG - as this element already fails to pass WCAG in the light theme.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Issues with the following code:

.ve-ce-branchNode-blockSlug, html body p.ve-ce-branchNode-newSlug

QA Results - Beta

AC	Status	Details
1	✅	T367822#9932580

QA Results - PROD

AC	Status	Details
1	✅	T367822#9970856

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Update background of insert paragraph slug	mediawiki/skins/Vector	master	+18 -1

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		ovasileva	T341631 [EPIC] Q1 Main hypothesis: Typographical and palette customizations
Resolved		ovasileva	T341632 [EPIC] Palette customizations and dark mode
Resolved		ovasileva	T367150 Deploy dark mode to logged-out users in tier 1 and 2 wikis on the Vector2022 and Minerva skin
Resolved	BUG REPORT	ovasileva	T367822 [Regression 1.43.0-wmf.10] Desktop VisualEditor insert paragraph workflow not legible

Event Timeline

Jdlrobson created this task.Jun 17 2024, 9:46 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 17 2024, 9:46 PM

Jdlrobson renamed this task from [Regression] VisualEditor insert paragraph workflow not legible to [Regression 1.43.0-wmf.10] VisualEditor insert paragraph workflow not legible.Jun 17 2024, 9:47 PM

Jdlrobson mentioned this in T365383: [Spike] QA outcome of OOUI work .Jun 17 2024, 10:19 PM

Jdlrobson triaged this task as High priority.Jun 18 2024, 4:12 PM

ovasileva moved this task from Ready for estimation to Needs analysis on the Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 6) board.Jun 18 2024, 4:22 PM

ovasileva assigned this task to Jdlrobson.Jun 20 2024, 5:49 PM

Still a problem. We could fix this in the same way we did on mobile like so:
https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/1048072/3/skinStyles/ext.visualEditor.core.mobile.less#L14-16

Jdlrobson renamed this task from [Regression 1.43.0-wmf.10] VisualEditor insert paragraph workflow not legible to [Regression 1.43.0-wmf.10] Desktop VisualEditor insert paragraph workflow not legible.Jun 21 2024, 12:57 AM

Jdlrobson removed Jdlrobson as the assignee of this task.

Jdlrobson moved this task from Needs analysis to Ready for estimation on the Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 6) board.

Jdrewniak updated the task description. (Show Details)Jun 24 2024, 5:35 PM

ovasileva set the point value for this task to 2.Jun 24 2024, 5:36 PM

ovasileva moved this task from Ready for estimation to Ready for Development on the Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 6) board.

ovasileva added a project: FY2023-24-WE 2.1 Typography and palette customizations.

ovasileva added a parent task: T367150: Deploy dark mode to logged-out users in tier 1 and 2 wikis on the Vector2022 and Minerva skin.Jun 24 2024, 5:38 PM

SToyofuku-WMF claimed this task.Jun 24 2024, 7:46 PM

SToyofuku-WMF moved this task from Ready for Development to Doing on the Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 6) board.

Change #1049269 had a related patch set uploaded (by Stoyofuku-wmf; author: Stoyofuku-wmf):

[mediawiki/skins/Vector@master] Update background of insert paragraph slug

https://gerrit.wikimedia.org/r/1049269