Page MenuHomePhabricator

[wmf.9] CommunityConfiguration: Summary edits popup appears for non-valid edits
Open, Needs TriagePublicBUG REPORT

Description

Steps to replicate the issue :

  • As an admin go to Special:CommunityConfiguration page
  • Click on any module.
  • Made non-valid edits - e.g. Special:CommunityConfiguration/GrowthHomepage enter non-existing namespace,
  • Click on the Save changes button.

What happens?:
The summary popup appears. When a user clicks to publish, only then the error message appears.

Screen Shot 2024-06-17 at 2.41.28 PM.png (1×2 px, 378 KB)

What should have happened instead?:
The summary popup should not appear when the changes made are invalid. A user should be informed about errors when
the Save changes button is clicked or before.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

I think there are two aspects to this:

  1. In general, making systematically sure that all errors are being surfaced as they are being entered is the focus of T358659: Client side form validation.
  2. That field in particular is somewhat of a makeshift component which we hopefully replace with the outcome of T345291: [EPIC] MultiselectLookup: Add new component. Then, adding proper validation to that should be easier and not duplicate work.

I think this task could be rephrased to "Namespaces selector allows invalid namespaces". It seems this task is a fair children of T358659, since Namespaces will require specific treatment anyways, thanks for the linking Michael.
Also we could try to keep the "draft" edit summary content so when the user gets a validation error (and fixes it), on the next submit the drafted summary is there. What do. you think? @JFernandez-WMF @KStoller-WMF

Also we could try to keep the "draft" edit summary content so when the user gets a validation error (and fixes it), on the next submit the drafted summary is there. What do. you think? @JFernandez-WMF @KStoller-WMF

Agreed, this is the current UX expectation for other wiki edit summaries.
Should we include that work in this task, or create a new task?