Various buttons on Vector 2022 acquired unexpected link styling when hovered
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	matmarex
	Jun 18 2024, 2:39 AM

Description

Various buttons on Vector 2022 acquired unexpected link styling when hovered, changing the text color to light blue or gaining underlines.

For example: (testing on https://patchdemo.wmflabs.org/wikis/a61a6b72be/wiki/Main_Page)

Requirement

Ensure that various buttons on the Vector 2022 skin do not acquire unexpected link styling when hovered, maintaining consistent styling with no changes to text color or added underlines.

BDD

Feature: Button Styling in Vector 2022

  Scenario: Verify button styling on hover
    Given the user is using the Vector 2022 skin
    When the user hovers over various buttons
    Then the buttons should not change text color
    And the buttons should not gain underlines

Test Steps

Test Case 1: Verify Button Styling on Hover in Vector 2022

Navigate to the Vector 2022 skin.
Hover over various buttons.
AC1: Confirm that the buttons do not change text color when hovered.
AC2: Confirm that the buttons do not gain underlines when hovered.

QA Results - Beta

AC	Status	Details
1	❌	T367844#9904775

QA Results - Prod

AC	Status	Details
1	✅	T367844#10020084
2	✅	T367844#10020084

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Fix codex link styles overriding other link styles	mediawiki/skins/Vector	wmf/1.43.0-wmf.10	+1 -1
	Fix codex link styles overriding other link styles	mediawiki/skins/Vector	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T375876: `.mw-selflink` now has `cursor: pointer;`
T367780: Verify 1.43.0-wmf.10 deployment
T367463: Tables with images inside them appear at minuscule size or disappear due to responsive image CSS
Mentioned Here: T367463: Tables with images inside them appear at minuscule size or disappear due to responsive image CSS
T366515: [VISUAL CHANGE] Visited links are not accessible in dark mode
T367453: Autocomplete highlighting for search is inconsistent between Vector 2022 and Minerva

Event Timeline

matmarex created this task.Jun 18 2024, 2:39 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 18 2024, 2:39 AM

matmarex updated the task description. (Show Details)Jun 18 2024, 2:43 AM

ovasileva triaged this task as Unbreak Now! priority.Jun 18 2024, 9:34 AM

ovasileva added a project: Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 6).

Change #1047120 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Fix codex link styles overriding other link styles

https://gerrit.wikimedia.org/r/1047120

gerritbot added a project: Patch-For-Review.Jun 18 2024, 3:57 PM

ovasileva lowered the priority of this task from Unbreak Now! to High.Jun 18 2024, 4:08 PM

ovasileva set the point value for this task to 1.Jun 18 2024, 4:12 PM

ovasileva moved this task from Needs analysis to QA on the Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 6) board.

Change #1047120 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Fix codex link styles overriding other link styles

https://gerrit.wikimedia.org/r/1047120

Jdlrobson assigned this task to GMikesell-WMF.Jun 18 2024, 4:42 PM

Jdlrobson moved this task from QA to Needs More Work on the Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 6) board.

Jdlrobson moved this task from Needs More Work to QA on the Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 6) board.

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.11; 2024-06-25).Jun 18 2024, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 18 2024, 5:30 PM

Change #1047155 had a related patch set uploaded (by Jdlrobson; author: Bernard Wang):

[mediawiki/skins/Vector@wmf/1.43.0-wmf.10] Fix codex link styles overriding other link styles

https://gerrit.wikimedia.org/r/1047155

gerritbot added a project: Patch-For-Review.Jun 18 2024, 6:12 PM

@Jdlrobson Please reviews issues below and let me know if you have any questions, thanks!

Test Result - Beta

Status: ❌ FAIL
Environment: Beta
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

❌ AC1: unexpected link styling when hovered, changing the text color to light blue or gaining underlines.

Status	Login
❌	Changes to lighter blue when hovering

Status	Publish Changes Grey
✅	No blue underline

Status	Publish Changes Blue
✅	No underline

Status	Publish Changes Blue
❌	First name is not bold

Status	Search for pages containing
✅	No blue underline

Status	Notices1
❌	Mark all as read is missing

Status	Notices2
✅	No blue underline

Status	Notices3
✅	No blue underline

GMikesell-WMF updated the task description. (Show Details)Jun 18 2024, 7:15 PM

❌ AC1: unexpected link styling when hovered, changing the text color to light blue or gaining underlines.

I checked with Justin and this expected. It's part of the deliverable of T366515.

First name is not bold

Tracked in T367453 and unrelated.

Mark all as read is missing

Out of scope for this ticket - I think this relates to Echo behaviour - and only shows if notifications are unread (excluding the more notices line).

Change #1047155 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.43.0-wmf.10] Fix codex link styles overriding other link styles

https://gerrit.wikimedia.org/r/1047155

Mentioned in SAL (#wikimedia-operations) [2024-06-18T21:03:07Z] <jdrewniak@deploy1002> Started scap: Backport for [[gerrit:1046790|Improve responsive images and avoid for inline (T367463)]], [[gerrit:1047155|Fix codex link styles overriding other link styles (T367844)]]

Mentioned in SAL (#wikimedia-operations) [2024-06-18T21:07:47Z] <jdrewniak@deploy1002> jdrewniak, jdlrobson: Backport for [[gerrit:1046790|Improve responsive images and avoid for inline (T367463)]], [[gerrit:1047155|Fix codex link styles overriding other link styles (T367844)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-06-18T21:09:33Z] <jdrewniak@deploy1002> Started scap: Backport for [[gerrit:1046790|Improve responsive images and avoid for inline (T367463)]], [[gerrit:1047155|Fix codex link styles overriding other link styles (T367844)]]

Mentioned in SAL (#wikimedia-operations) [2024-06-18T21:13:59Z] <jdrewniak@deploy1002> jdlrobson, jdrewniak: Backport for [[gerrit:1046790|Improve responsive images and avoid for inline (T367463)]], [[gerrit:1047155|Fix codex link styles overriding other link styles (T367844)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-06-18T21:26:07Z] <jdrewniak@deploy1002> Finished scap: Backport for [[gerrit:1046790|Improve responsive images and avoid for inline (T367463)]], [[gerrit:1047155|Fix codex link styles overriding other link styles (T367844)]] (duration: 16m 33s)