Page MenuHomePhabricator

Various buttons on Vector 2022 acquired unexpected link styling when hovered
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT

Assigned To
Authored By
matmarex
Tue, Jun 18, 2:39 AM
Referenced Files
F55442641: 2024-06-18_11-59-10.png
Tue, Jun 18, 7:14 PM
F55442627: 2024-06-18_11-55-11.png
Tue, Jun 18, 7:14 PM
F55442622: 2024-06-18_11-50-43.png
Tue, Jun 18, 7:14 PM
F55442613: 2024-06-18_11-49-33.png
Tue, Jun 18, 7:14 PM
F55442611: 2024-06-18_11-47-43.png
Tue, Jun 18, 7:14 PM
F55442604: 2024-06-18_11-46-06.png
Tue, Jun 18, 7:14 PM
F55442578: 2024-06-18_11-53-21.png
Tue, Jun 18, 7:14 PM
F55421734: image.png
Tue, Jun 18, 2:43 AM

Description

Various buttons on Vector 2022 acquired unexpected link styling when hovered, changing the text color to light blue or gaining underlines.

For example: (testing on https://patchdemo.wmflabs.org/wikis/a61a6b72be/wiki/Main_Page)

image.png (2×3 px, 393 KB)

image.png (2×3 px, 368 KB)

image.png (2×3 px, 367 KB)

image.png (2×3 px, 379 KB)

image.png (2×3 px, 370 KB)

image.png (2×3 px, 368 KB)

image.png (2×3 px, 386 KB)

image.png (2×3 px, 381 KB)

QA Results - Beta

ACStatusDetails
1T367844#9904775

Event Timeline

Change #1047120 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Fix codex link styles overriding other link styles

https://gerrit.wikimedia.org/r/1047120

ovasileva lowered the priority of this task from Unbreak Now! to High.Tue, Jun 18, 4:08 PM
ovasileva set the point value for this task to 1.Tue, Jun 18, 4:12 PM

Change #1047120 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Fix codex link styles overriding other link styles

https://gerrit.wikimedia.org/r/1047120

Change #1047155 had a related patch set uploaded (by Jdlrobson; author: Bernard Wang):

[mediawiki/skins/Vector@wmf/1.43.0-wmf.10] Fix codex link styles overriding other link styles

https://gerrit.wikimedia.org/r/1047155

@Jdlrobson Please reviews issues below and let me know if you have any questions, thanks!

Test Result - Beta

Status: ❌ FAIL
Environment: Beta
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

❌ AC1: unexpected link styling when hovered, changing the text color to light blue or gaining underlines.

StatusLogin
Changes to lighter blue when hovering
2024-06-18_11-53-21.png (1×2 px, 447 KB)
StatusPublish Changes Grey
No blue underline
2024-06-18_11-46-06.png (666×2 px, 242 KB)
StatusPublish Changes Blue
No underline
2024-06-18_11-47-43.png (443×1 px, 88 KB)
StatusPublish Changes Blue
First name is not bold
2024-06-18_11-49-33.png (624×1 px, 187 KB)
StatusSearch for pages containing
No blue underline
2024-06-18_11-50-43.png (719×1 px, 217 KB)
StatusNotices1
Mark all as read is missing
2024-06-18_11-55-11.png (465×1 px, 195 KB)
StatusNotices2
No blue underline
2024-06-18_11-50-43.png (719×1 px, 217 KB)
StatusNotices3
No blue underline
2024-06-18_11-59-10.png (970×1 px, 475 KB)
Jdlrobson added a subscriber: GMikesell-WMF.

❌ AC1: unexpected link styling when hovered, changing the text color to light blue or gaining underlines.

I checked with Justin and this expected. It's part of the deliverable of T366515.

First name is not bold

Tracked in T367453 and unrelated.

Mark all as read is missing

Out of scope for this ticket - I think this relates to Echo behaviour - and only shows if notifications are unread (excluding the more notices line).

Change #1047155 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.43.0-wmf.10] Fix codex link styles overriding other link styles

https://gerrit.wikimedia.org/r/1047155

Mentioned in SAL (#wikimedia-operations) [2024-06-18T21:03:07Z] <jdrewniak@deploy1002> Started scap: Backport for [[gerrit:1046790|Improve responsive images and avoid for inline (T367463)]], [[gerrit:1047155|Fix codex link styles overriding other link styles (T367844)]]

Mentioned in SAL (#wikimedia-operations) [2024-06-18T21:07:47Z] <jdrewniak@deploy1002> jdrewniak, jdlrobson: Backport for [[gerrit:1046790|Improve responsive images and avoid for inline (T367463)]], [[gerrit:1047155|Fix codex link styles overriding other link styles (T367844)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-06-18T21:09:33Z] <jdrewniak@deploy1002> Started scap: Backport for [[gerrit:1046790|Improve responsive images and avoid for inline (T367463)]], [[gerrit:1047155|Fix codex link styles overriding other link styles (T367844)]]

Mentioned in SAL (#wikimedia-operations) [2024-06-18T21:13:59Z] <jdrewniak@deploy1002> jdlrobson, jdrewniak: Backport for [[gerrit:1046790|Improve responsive images and avoid for inline (T367463)]], [[gerrit:1047155|Fix codex link styles overriding other link styles (T367844)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-06-18T21:26:07Z] <jdrewniak@deploy1002> Finished scap: Backport for [[gerrit:1046790|Improve responsive images and avoid for inline (T367463)]], [[gerrit:1047155|Fix codex link styles overriding other link styles (T367844)]] (duration: 16m 33s)

Looks good, thank you everyone!