Page MenuHomePhabricator

Automatically accept vanishing requests if the user has no activity
Closed, ResolvedPublic

Description

As a user, I would like to have my vanish request be automatically fulfilled if I do not have an in-software presence.

AC:

  • Automatically vanish the user only if they have no edits, public logs or blocks on any connected wikis.
  • If these criteria are not met then the user is simply added to the queue and no action is taken until a renamer reviews the request, as it works right now.
  • Ensure that global action detection is also accounted for.

Related Objects

Event Timeline

Amdrel changed the task status from Open to In Progress.Jun 24 2024, 5:44 PM

Change #1049249 had a related patch set uploaded (by Amdrel; author: Amdrel):

[mediawiki/extensions/CentralAuth@automate-account-vanishing-phase-3] [WIP] Automatically accept vanishing requests if no activity

https://gerrit.wikimedia.org/r/1049249

Change #1049249 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@automate-account-vanishing-phase-3] Automatically accept vanishing requests if no activity

https://gerrit.wikimedia.org/r/1049249

Change #1052684 had a related patch set uploaded (by Simone Cuomo; author: Amdrel):

[mediawiki/extensions/CentralAuth@master] Automatically accept vanishing requests if no activity

https://gerrit.wikimedia.org/r/1052684

Test wiki created on Patch demo by SimoneThisDot using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/f5a7b80242/w

Change #1053294 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/CentralAuth@master] Introduce Vanish Request Flow

https://gerrit.wikimedia.org/r/1053294

Test wiki created on Patch demo by SimoneThisDot using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/0f344e95cc/w

Change #1052684 abandoned by Seddon:

[mediawiki/extensions/CentralAuth@master] Automatically accept vanishing requests if no activity

Reason:

Replaced by a flattened patch https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralAuth/+/1053294

https://gerrit.wikimedia.org/r/1052684

Test wiki created on Patch demo by SimoneThisDot using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/bb21f4e4bf/w

Change #1053294 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Introduce Vanish Request Flow

https://gerrit.wikimedia.org/r/1053294

Change #1054384 had a related patch set uploaded (by Amdrel; author: Amdrel):

[mediawiki/extensions/CentralAuth@master] Properly set automatic vanish performer on GlobalRenameUser

https://gerrit.wikimedia.org/r/1054384

Change #1054384 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Properly set automatic vanish performer on GlobalRenameUser

https://gerrit.wikimedia.org/r/1054384

Change #1054571 had a related patch set uploaded (by Urbanecm; author: Simone Cuomo):

[mediawiki/extensions/CentralAuth@wmf/1.43.0-wmf.13] Introduce Vanish Request Flow

https://gerrit.wikimedia.org/r/1054571

Change #1054571 abandoned by Urbanecm:

[mediawiki/extensions/CentralAuth@wmf/1.43.0-wmf.13] Introduce Vanish Request Flow

https://gerrit.wikimedia.org/r/1054571

Change #1054572 had a related patch set uploaded (by Urbanecm; author: Simone Cuomo):

[mediawiki/extensions/CentralAuth@wmf/1.43.0-wmf.13] Introduce Vanish Request Flow

https://gerrit.wikimedia.org/r/1054572

Change #1054574 had a related patch set uploaded (by Urbanecm; author: Amdrel):

[mediawiki/extensions/CentralAuth@wmf/1.43.0-wmf.13] Properly set automatic vanish performer on GlobalRenameUser

https://gerrit.wikimedia.org/r/1054574

Change #1054572 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@wmf/1.43.0-wmf.13] Introduce Vanish Request Flow

https://gerrit.wikimedia.org/r/1054572

Change #1054574 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@wmf/1.43.0-wmf.13] Properly set automatic vanish performer on GlobalRenameUser

https://gerrit.wikimedia.org/r/1054574

Mentioned in SAL (#wikimedia-operations) [2024-07-16T14:25:47Z] <urbanecm@deploy1002> Started scap sync-world: Backport for [[gerrit:1054572|Introduce Vanish Request Flow (T367329 T367726 T367728 T367729 T367744 T368177 T368285 T368368 T368372 T368611 T369489)]], [[gerrit:1054573|Pass wiki id to actor store for cross-db hasPublicLogs query (T370059)]], [[gerrit:1054574|Properly set automatic vanish performer on GlobalRenameUser (T368177)]], [[gerrit:1053373|Enable account vanishing

Mentioned in SAL (#wikimedia-operations) [2024-07-16T14:53:37Z] <urbanecm@deploy1002> dbrant, urbanecm: Backport for [[gerrit:1054572|Introduce Vanish Request Flow (T367329 T367726 T367728 T367729 T367744 T368177 T368285 T368368 T368372 T368611 T369489)]], [[gerrit:1054573|Pass wiki id to actor store for cross-db hasPublicLogs query (T370059)]], [[gerrit:1054574|Properly set automatic vanish performer on GlobalRenameUser (T368177)]], [[gerrit:1053373|Enable account vanishing in Cen

Mentioned in SAL (#wikimedia-operations) [2024-07-16T15:01:39Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:1054572|Introduce Vanish Request Flow (T367329 T367726 T367728 T367729 T367744 T368177 T368285 T368368 T368372 T368611 T369489)]], [[gerrit:1054573|Pass wiki id to actor store for cross-db hasPublicLogs query (T370059)]], [[gerrit:1054574|Properly set automatic vanish performer on GlobalRenameUser (T368177)]], [[gerrit:1053373|Enable account vanishing in Centra

Change #1054602 had a related patch set uploaded (by Dbrant; author: Dbrant):

[mediawiki/extensions/CentralAuth@master] Remove user-specified reason when user is auto-vanished.

https://gerrit.wikimedia.org/r/1054602

Change #1054602 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Remove user-specified reason when user is auto-vanished.

https://gerrit.wikimedia.org/r/1054602

Is it possible to do something about log entries for this user? For example, https://en.wikipedia.org/wiki/Special:Log/AccountVanishRequests is readily accessible and gives a comprehensive list of every user who's been vanished for privacy reasons, alongside their reason for doing so, all in one central and easily-indexed location. This would seem like, perhaps, the least private thing possible.

Moreover, there's https://en.wikipedia.org/w/index.php?title=Special:Log&page=User%3AIqbal679101qi this log entry where some guy is posting a spam link in the account deletion summary, it may be useful to prohibit URLs in those.

Is it possible to do something about log entries for this user? For example, https://en.wikipedia.org/wiki/Special:Log/AccountVanishRequests is readily accessible and gives a comprehensive list of every user who's been vanished for privacy reasons, alongside their reason for doing so, all in one central and easily-indexed location. This would seem like, perhaps, the least private thing possible.

Moreover, there's https://en.wikipedia.org/w/index.php?title=Special:Log&page=User%3AIqbal679101qi this log entry where some guy is posting a spam link in the account deletion summary, it may be useful to prohibit URLs in those.

@jpxg: This is fixed with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralAuth/+/1054602 and is going out on the train this week

Seddon triaged this task as Medium priority.Jul 23 2024, 11:48 AM
Seddon moved this task from Incoming to Current priorities on the Account-Vanishing board.

FYI: log entries with an associated VRTS ticket seem to be misformatted: see e.g. https://meta.wikimedia.org/w/index.php?title=Special:Log&logid=57074693. I presume there should be a number there (not XXXXXXXXX), and the link format should be more like that which would be produced by printf("per [[:m:Right to vanish]] and [[:ticket:%s|ticket %s]]", ticketNumStr, ticketNumStr) (not printf("per [[:m:Right_to_vanish|m:Right_to_vanishandticket]][[:ticket:%s]]", "XXXXXXXXX"))

FYI: log entries with an associated VRTS ticket seem to be misformatted: see e.g. https://meta.wikimedia.org/w/index.php?title=Special:Log&logid=57074693. I presume there should be a number there (not XXXXXXXXX), and the link format should be more like that which would be produced by printf("per [[:m:Right to vanish]] and [[:ticket:%s|ticket %s]]", ticketNumStr, ticketNumStr) (not printf("per [[:m:Right_to_vanish|m:Right_to_vanishandticket]][[:ticket:%s]]", "XXXXXXXXX"))

Those are from Zendesk tickets, not VRT. Hopefully, this is the last batch from that old workflow.

Seddon moved this task from Verify in Production to Done on the Account-Vanishing board.

@Amdrel, @Seddon: Does "no activity" and "[no] public logs" intentionally include users with "Disallow" edit filter hits that led to a warning on the user's talk page, such as https://en.wikipedia.org/wiki/User_talk:Vanished_user_16d7650337e0e95cfe1b82503d0a1d4f ?

I mean, the filter hits are now probably gone due to the renaming, which appears to break these logs for both the source and the target username, which is probably a separate bug we hopefully also already have an issue for.

Test wiki on Patch demo by SimoneThisDot using patch(es) linked to this task was deleted:

https://patchdemo-legacy.wmcloud.org/wikis/0f344e95cc/w/

Test wiki on Patch demo by SimoneThisDot using patch(es) linked to this task was deleted:

https://patchdemo-legacy.wmcloud.org/wikis/bb21f4e4bf/w/

Test wiki on Patch demo by SimoneThisDot using patch(es) linked to this task was deleted:

https://patchdemo-legacy.wmcloud.org/wikis/f5a7b80242/w/