| DVrandecic | |
| Jun 24 2024, 9:42 PM |
| F58395385: renderer-partial-cache.mov | |
| Feb 13 2025, 3:14 PM |
| F58395384: renderer-fail-1.mov | |
| Feb 13 2025, 3:14 PM |
| F58395382: renderer-1.mov | |
| Feb 13 2025, 3:14 PM |
Go to https://www.wikifunctions.org/view/en/Z17364
The call is currently represented as
less than or equal (integer) (Integer(Sign(positive), Natural number("3")), Integer(Sign
(positive), Natural number("3")))
but we could use the renderer for Integers in order to represent it as
less than or equal (integer) (3, 3)
which would be more readable.
Suggestion is to use the renderer in the short format of the call where possible.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| ZObjectToString: use renderer for inner values | mediawiki/extensions/WikiLambda | master | +148 -22 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • Sharvaniharan | T383163 [25Q3] Fix High-Priority Paper-cuts | |||
| Resolved | DSmit-WMF | T368324 Use renderer for inner values |
I pondered whether to ask for this too. It would certainly be more readable. But I wonder if this should wait until we've got better type validators.
Here's are a couple of examples where it helps to see the expanded content. In some more extreme cases the renderer may even fail.
https://www.wikifunctions.org/view/en/Z13524
https://www.wikifunctions.org/view/en/Z17461
So this needs a bit of UX/Design IMHO:
We should work out the unhappy flow.
What we also show in the expanded version (with different logic behind it):
Some fun movies for inspiration:
Renderer: https://www.dropbox.com/scl/fi/f7evfdw9gq4376iyyt8yc/renderer-1.mov?rlkey=iu38f7g46mlqhns9d55mrktf5&dl=0
Renderer fails: https://www.dropbox.com/scl/fi/8u249l5yga5fzrtlsfmpf/renderer-fail-1.mov?rlkey=vilv2m3d7ejv6ofe3xfjthij5&dl=0
Renderer where a few items are already cached: https://www.dropbox.com/scl/fi/bz72blvxiv7e5bn8o6puc/renderer-partial-cache.mov?rlkey=cz3n0zcj8jcxalazn73knxx75&dl=0
looks good!
Renderer fails: https://www.dropbox.com/scl/fi/8u249l5yga5fzrtlsfmpf/renderer-fail-1.mov?rlkey=vilv2m3d7ejv6ofe3xfjthij5&dl=0
@DSmit-WMF if it fails, instead of showing No display value we would show the fallback view. see example below:
| loading | success | fail |
|---|---|---|
| same Integer (Running...) | same Integer (255) | same Integer (Integer (Sign (positive), Natural number ("255"))) |
Renderer where a few items are already cached: https://www.dropbox.com/scl/fi/bz72blvxiv7e5bn8o6puc/renderer-partial-cache.mov?rlkey=cz3n0zcj8jcxalazn73knxx75&dl=0
looks good!
Change #1122564 had a related patch set uploaded (by Daphne Smit; author: Daphne Smit):
[mediawiki/extensions/WikiLambda@master] ZObjectToString: use renderer for inner values
Change #1122564 merged by jenkins-bot:
[mediawiki/extensions/WikiLambda@master] ZObjectToString: use renderer for inner values