[Desktop] VisualEditor save workflow unreadable in dark mode
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson
	Jun 26 2024, 12:27 AM

Description

Flagged by QA in T367813

Steps to replicate the issue (include links if applicable):

Visit https://en.wikipedia.beta.wmflabs.org/w/index.php?title=T352930&action=edit
Make an edit
Click save.

What happens?:

2024-06-21_13-54-44.png (913×1 px, 303 KB)

What should have happened instead?:

No color contrast issues

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

.ve-ui-mwSaveDialog-options uses hardcoded colors

https://gerrit.wikimedia.org/g/mediawiki/extensions/VisualEditor/+/6fcd80d4d4193162951591ef3c03b99ffc389590/modules/ve-mw/ui/styles/dialogs/ve.ui.MWSaveDialog.less#27

ve-ui-mwSaveDialog-license uses hardcoded color

https://gerrit.wikimedia.org/g/mediawiki/extensions/VisualEditor/+/6fcd80d4d4193162951591ef3c03b99ffc389590/modules/ve-mw/ui/styles/dialogs/ve.ui.MWSaveDialog.less#78

QA Results - Beta

AC	Status	Details
1	✅	T368486#9962820

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Use codex tokens in save dialog	mediawiki/extensions/VisualEditor	master	+1 -1

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		ovasileva	T341631 [EPIC] Q1 Main hypothesis: Typographical and palette customizations
Resolved		ovasileva	T341632 [EPIC] Palette customizations and dark mode
Resolved		ovasileva	T367150 Deploy dark mode to logged-out users in tier 1 and 2 wikis on the Vector2022 and Minerva skin
Resolved	BUG REPORT	ovasileva	T368486 [Desktop] VisualEditor save workflow unreadable in dark mode

Event Timeline

Jdlrobson created this task.Jun 26 2024, 12:27 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 26 2024, 12:27 AM

Jdlrobson added a parent task: T367150: Deploy dark mode to logged-out users in tier 1 and 2 wikis on the Vector2022 and Minerva skin.Jun 26 2024, 12:28 AM

Jdlrobson mentioned this in T367813: [QA only] Media overlay, citation, link and template and save changes overlay close icon/search icon invisible.

Jdlrobson mentioned this in T366197: VisualEditor should use Codex design tokens for custom colors.Jun 26 2024, 12:43 AM

Jdlrobson triaged this task as High priority.Jun 26 2024, 12:56 AM

Jdlrobson moved this task from Backlog to Night mode (desktop) on the FY2023-24-WE 2.1 Typography and palette customizations board.Jun 26 2024, 2:49 AM

ovasileva set the point value for this task to 2.Jun 27 2024, 5:20 PM

ovasileva edited projects, added Web-Team-Backlog-Archived (FY2024-25 Q1 Sprint 1); removed Web-Team-Backlog-Archived (FY2023-24 Q4 Sprint 6).

ovasileva moved this task from Needs analysis to Ready for Development on the Web-Team-Backlog-Archived (FY2024-25 Q1 Sprint 1) board.

ppelberg subscribed.Jun 27 2024, 5:49 PM

Jdlrobson renamed this task from VisualEditor save workflow unreadable in dark mode to [Desktop] VisualEditor save workflow unreadable in dark mode.Jun 27 2024, 9:44 PM

Jdlrobson moved this task from Backlog to Web (MediaWiki) on the dark-mode board.Jun 28 2024, 3:03 AM

Jdlrobson added a project: patch-welcome.Jun 28 2024, 3:05 AM

bwang claimed this task.Jul 2 2024, 5:41 PM

SToyofuku-WMF moved this task from Ready for Development to Doing on the Web-Team-Backlog-Archived (FY2024-25 Q1 Sprint 1) board.Jul 2 2024, 8:20 PM

Jdlrobson merged a task: T369183: ".ve-ui-mwSaveDialog-options" in VE confirm dialog is unreadable in dark mode.Jul 3 2024, 4:50 PM

Jdlrobson added a subscriber: zdev.

Change #1051816 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/extensions/VisualEditor@master] Use codex tokens in save dialog

https://gerrit.wikimedia.org/r/1051816

Change #1051816 abandoned by Bernard Wang:

[mediawiki/extensions/VisualEditor@master] Use codex tokens in save dialog

Reason: