Maniphest T368530

OOJS: clone/copy fails on an object with a null prototype
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	dchan
	Jun 26 2024, 12:38 PM

Tags

Referenced Files

None

Subscribers

Description

Steps to reproduce

OO.cloneObject( Object.create( null ) )
OO.copy( Object.create( null ) ).__proto__

Expected behaviour

Clone succeeds
Copy succeeds

Observed behaviour

Clone throws an error
Copy creates an object whose prototype is not null.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Support null-prototype objects in OO.cloneObject/OO.copy	oojs/core	master	+14 -2

Customize query in gerrit

Event Timeline

dchan created this task.Jun 26 2024, 12:38 PM

Restricted Application added a project: MediaWiki-Platform-Team. · View Herald TranscriptJun 26 2024, 12:38 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change #1049922 had a related patch set uploaded (by Divec; author: Divec):

[oojs/core@master] Support null-prototype objects in OO.cloneObject/OO.copy

https://gerrit.wikimedia.org/r/1049922

gerritbot added a project: Patch-For-Review.Jun 26 2024, 12:40 PM

Change #1049922 merged by jenkins-bot:

[oojs/core@master] Support null-prototype objects in OO.cloneObject/OO.copy

https://gerrit.wikimedia.org/r/1049922

Maintenance_bot removed a project: Patch-For-Review.Jun 27 2024, 2:30 PM

• larissagaulia moved this task from Inbox, needs triage to Radar on the MediaWiki-Platform-Team board.Jul 1 2024, 2:38 PM

• larissagaulia edited projects, added MediaWiki-Platform-Team (Radar); removed MediaWiki-Platform-Team.

matmarex closed this task as Resolved.Jul 1 2024, 2:44 PM

matmarex subscribed.

Krinkle moved this task from Inbox to Confirmed Problem on the OOjs core board.Jan 6 2026, 6:39 AM