Page MenuHomePhabricator
Create Task
Maniphest T368547

Create centralized tests for supported media types in all edit routes
Closed, ResolvedPublic
Actions

Description

Currently, Wikibase REST API have a centralized test file for checking unsupported media type requests in repo/rest-api/tests/mocha/api-testing/UnsupportedMediaTypeTest.js.

We want to centralize the tests for the media types that the REST API supports.

For PATCH requests, it supports application/json and application/json-patch+json.

Wikibase REST API supports application/json for the remaining edit requests.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
REST: Test supported media types in edit routesMuhammad Jaziralymediawiki/extensions/Wikibasemaster+47 -226
Customize query in gerrit

Event Timeline

• Muhammad_Yasser_Jazirahly_WMDE created this task.Jun 26 2024, 2:56 PM
Herald added a subscriber: Aklapper. · View Herald TranscriptJun 26 2024, 2:56 PM
• Muhammad_Yasser_Jazirahly_WMDE added a comment.Jun 26 2024, 2:57 PM

If it turns out not necessary to test application/json we can focus only on the PATCH requests.

Ollie.Shotton_WMDE moved this task from Backlog to Tech backlog on the Wikibase Reuse Team board.Jun 26 2024, 4:15 PM
gerritbot added a comment.Sep 14 2024, 10:10 PM

Change #1072866 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Test supported media types in edit routes

https://gerrit.wikimedia.org/r/1072866

gerritbot added a project: Patch-For-Review.Sep 14 2024, 10:10 PM
• Muhammad_Yasser_Jazirahly_WMDE claimed this task.Sep 14 2024, 10:10 PM
• Muhammad_Yasser_Jazirahly_WMDE moved this task from Tech backlog to Sprint 28 on the Wikibase Reuse Team board.
• Muhammad_Yasser_Jazirahly_WMDE edited projects, added: Wikibase Reuse Team (Sprint 28); removed: Wikibase Reuse Team.
• Muhammad_Yasser_Jazirahly_WMDE moved this task from To Do to Doing on the Wikibase Reuse Team (Sprint 28) board.
• Muhammad_Yasser_Jazirahly_WMDE moved this task from Doing to Peer Review on the Wikibase Reuse Team (Sprint 28) board.Sep 14 2024, 10:41 PM
gerritbot added a comment.Sep 16 2024, 4:40 PM

Change #1072866 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Test supported media types in edit routes

https://gerrit.wikimedia.org/r/1072866

• Muhammad_Yasser_Jazirahly_WMDE moved this task from Peer Review to Done on the Wikibase Reuse Team (Sprint 28) board.Sep 16 2024, 4:52 PM
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.23; 2024-09-17).Sep 16 2024, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 16 2024, 5:30 PM
Ifrahkhanyaree_WMDE closed this task as Resolved.Sep 17 2024, 10:38 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits