Page MenuHomePhabricator

[Mobile] TypeError: Cannot read properties of undefined (reading 'close')
Open, Needs TriagePublicBUG REPORT

Description

https://logstash.wikimedia.org/goto/06d80cf373ac6b785fae30846d78b60e
1369 errors in the last 7 days. Seems restricted to mobile site

t ve.ui.EditCheckBack.onSelect  https://pt.m.wikipedia.org/w/load.php?lang=pt&modules=ext.visualEditor.editCheck&skin=minerva&version=1uyua:8:477
at OO.ui.ToolGroup.onMouseKeyUp  https://pt.m.wikipedia.org/w/load.php?lang=pt&modules=oojs-ui-toolbars&skin=minerva&version=1jzkw:13:340
at OO.ui.ToolGroup.onDocumentMouseKeyUp  https://pt.m.wikipedia.org/w/load.php?lang=pt&modules=oojs-ui-toolbars&skin=minerva&version=1jzkw:13:73

Steps to replicate the issue (include links if applicable):

What happens?:

What should have happened instead?:

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

This is a click on the "back" button in the edit check popup. For it to error like this, it needs to be in a state where said back button is accessible... but there's no open context item or inspector. This might mean that there's a reachable state where we just seem to have an empty edit check stage with the toolbar still showing... or it might mean that there's a way to access the toolbar after we think we've cleaned up and moved on.

Looks like it started happening with last week's train-deploy of wmf.10, so it's probably a side-effect of the changes made for the edit check API / multicheck.