Test file "SandboxTest.php" not found for parallel PHPUnit in TwoColConflict
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Umherirrender
	Jun 28 2024, 7:48 PM

Description

The unit run for TwoColConflict gives failure about missing file
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/TwoColConflict/+/1048824
https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php74-noselenium/23147/console

INFO:quibble.commands:>>> Start: PHPUnit split_group_0 suite (without database or standalone)
PHPUnit split_group_0 suite (without database or standalone)
composer run --timeout=0 phpunit:entrypoint -- --cache-result-file /workspace/log/.phpunit_group_{split_group_id}_databaseless.cache.json --testsuite split_group_0 --exclude-group Broken,ParserFuzz,Stub,Database,Standalone
> phpunit '--cache-result-file' '/workspace/log/.phpunit_group_{split_group_id}_databaseless.cache.json' '--testsuite' 'split_group_0' '--exclude-group' 'Broken,ParserFuzz,Stub,Database,Standalone'
Using PHP 7.4.33
Running with MediaWiki settings because there might be integration tests
PHPUnit 9.6.19 by Sebastian Bergmann and contributors.

Test file "/workspace/src/extensions/Scribunto/tests/phpunit/Engines/LuaSandbox/SandboxTest.php" not found
Script phpunit handling the phpunit event returned with error code 2
Script @phpunit was called via phpunit:entrypoint
<<< Finish: PHPUnit split_group_0 suite (without database or standalone), in 1.395 s

INFO:quibble.commands:<<< Finish: Run PHPUnit extensions suite (without database or standalone) parallel run in parallel (concurrency=7):
* PHPUnit split_group_0 suite (without database or standalone)
* PHPUnit split_group_1 suite (without database or standalone)
* PHPUnit split_group_2 suite (without database or standalone)
* PHPUnit split_group_3 suite (without database or standalone)
* PHPUnit split_group_4 suite (without database or standalone)
* PHPUnit split_group_5 suite (without database or standalone)
* PHPUnit split_group_6 suite (without database or standalone), in 1.528 s

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
zuul: Re-enable parallel tests on TwoColConflict	integration/config	master	+1 -3
jjb: switch jobs from Quibble 1.9.1 to 1.9.3	integration/config	master	+14 -14
zuul: disable PHPUnit parallel for TwoColConflict	integration/config	master	+3 -1
Parallel PHPUnit: Only run Scributo SandboxTest if Scribunto loaded	integration/quibble	master	+11 -5

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T361118 [EPIC][Infra] Reduce CI test runtime for Wikibase and related extensions
Resolved	kostajh	T361190 Split PHPUnit test suite for wmf-quibble-vendor-mysql-php74-docker
Resolved	ArthurTaylor	T368783 Test file "SandboxTest.php" not found for parallel PHPUnit in TwoColConflict
Resolved	hashar	T369146 Quibble CI images based on Buster fail to build due to sury.org dropping support

Event Timeline

Umherirrender created this task.Jun 28 2024, 7:48 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 28 2024, 7:48 PM

Umherirrender added a parent task: T361190: Split PHPUnit test suite for wmf-quibble-vendor-mysql-php74-docker.Jun 28 2024, 7:49 PM

Scribunto is not cloned and seems not a dependency of the extension.

Ah - yes. That's definitely my bad. It needs a file-exists check, but I didn't get to adding that. I'll take a look - thanks for the report!

Change #1051058 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[integration/quibble@master] Parallel PHPUnit: Only run Scributo SandboxTest if Scribunto loaded

https://gerrit.wikimedia.org/r/1051058

gerritbot added a project: Patch-For-Review.Jul 1 2024, 8:03 AM

Change #1051058 merged by jenkins-bot:

[integration/quibble@master] Parallel PHPUnit: Only run Scributo SandboxTest if Scribunto loaded

https://gerrit.wikimedia.org/r/1051058

Maintenance_bot removed a project: Patch-For-Review.Jul 1 2024, 9:30 AM

Mentioned in SAL (#wikimedia-releng) [2024-07-03T08:37:31Z] <hashar> Tag Quibble 1.9.2 @ 046ec783998b5964a3148d05a1220fcec8998777 # T361190 T368783

I can't upgrade Quibble on CI since we use Buster image and PHP packages coming from sury.org which has removed support for Buster: T369146

The easiest for now is to opt out TwoColConflict from parallelism.

hashar added a subtask: T369146: Quibble CI images based on Buster fail to build due to sury.org dropping support.Jul 3 2024, 9:36 AM

Change #1051701 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] zuul: disable PHPUnit parallel for TwoColConflict

https://gerrit.wikimedia.org/r/1051701

Change #1051701 merged by jenkins-bot:

[integration/config@master] zuul: disable PHPUnit parallel for TwoColConflict

https://gerrit.wikimedia.org/r/1051701

This is now unblocked - the pending change (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/TwoColConflict/+/1048824) has been merged. We can revisit enabling parallel testing for TwoColConflict in the future, but since all jobs run in under 7 mins, it doesn't seem an urgent priority.

Change #1053311 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] jjb: switch jobs from Quibble 1.9.1 to 1.9.3

https://gerrit.wikimedia.org/r/1053311

Mentioned in SAL (#wikimedia-releng) [2024-07-10T14:00:08Z] <hashar> Switching some of the Jenkins jobs from Quibble 1.9.1 to 1.9.3 # T368783 & T366799