Page MenuHomePhabricator

gepersonalizedpraisedefaultnotificationsfrequency does not indicate units
Closed, ResolvedPublicBUG REPORT

Description

When you visit https://cs.wikipedia.org/wiki/Speci%C3%A1ln%C3%AD:Komunitn%C3%AD_konfigurace/Mentorship?uselang=en, one of the options (link) reads:

By default, how often should mentors receive notifications to remind them to send encouragement to mentees who are editing successfully?

It should indicate the time unit, too. I think it is hours, but I can make this guess only based on its current value, i.e., 168 (no. hours per week). But this value can change over time, then that might not be that obvious anymore.

Acceptance Criteria:
  • unit of measurement is added
  • unit of measure is converted from hours to days (split to T369311)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change #1051464 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] i18n: Clarify units for Personalized praise notifications frequency

https://gerrit.wikimedia.org/r/1051464

Urbanecm_WMF subscribed.

Thanks for noticing this @matej_suchanek! I went ahead and uploaded a patch for the copy change, since that part is very trivial, and definitely improves user experience. With my change, the form looks like this:

image.png (606×1 px, 104 KB)

In the future, we might want to fix this in a better way, such as by adding the unit directly into the form field as an inline label:

image.png (154×1 px, 19 KB)

If we want something like this, we should think about how exactly it should work like (in terms of CommunityConfiguration components) in a separate task, I think.

As for changing the units of measurement, that's more tricky (and since that would be a migration, it would need T357532: Create a system to support developers while upgrading configuration schemas to be completed first). @KStoller-WMF Would it be possible to break that part to a separate task, please? Once that's done, this task can be safely moved to sprint QA.

Change #1051464 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] i18n: Clarify units for Personalized praise notifications frequency

https://gerrit.wikimedia.org/r/1051464

As for changing the units of measurement, that's more tricky (and since that would be a migration, it would need T357532: Create a system to support developers while upgrading configuration schemas to be completed first). @KStoller-WMF Would it be possible to break that part to a separate task, please? Once that's done, this task can be safely moved to sprint QA.

Done as T369311: Personalized praise frequency: Change the units of measurement to days. Removing the second A/C from this task.

Urbanecm_WMF updated the task description. (Show Details)

Moving to QA, as the first part of the task is done.