"jQuery.Deferred exception: wish is null" for some unbalanced parser tags
Closed, DeclinedPublicBUG REPORT
Actions

Assigned To

None

Authored By

	dom_walden
	Jul 2 2024, 8:14 AM

Project Tags

Referenced Files

	F56493269: 2024-07-17_19-16-14.png
	Jul 18 2024, 2:20 AM

	F56493267: 2024-07-17_19-04-48.mp4.gif
	Jul 18 2024, 2:20 AM

Subscribers

Description

What is the problem?

The intake form will not load if the wish description includes parser tags (e.g. <syntaxhighlight>) that are not correctly closed.

For example, a description like:

<syntaxhighlight>
foobar sdjfkl sdjfkl sd jsklf sjklf sdjkfl sd

If you try to "edit with form" a blank intake form will load and the VisualEditor and Source Editor will not load for the description.

Also, in the browser console you will see this error:

jQuery.Deferred exception: wish is null setProposalData/<@https://wishlist-test.toolforge.org/w/load.php?lang=en-gb&modules=ext.gadget.WishlistIntake&skin=vector-2022&version=1ru3n:43:654
mightThrow@https://wishlist-test.toolforge.org/w/load.php?lang=en-gb&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue&skin=vector-2022&version=1a11e:180:648
Deferred/then/resolve/</process<@https://wishlist-test.toolforge.org/w/load.php?lang=en-gb&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue&skin=vector-2022&version=1a11e:181:309
setTimeout handler*Deferred/then/resolve/<@https://wishlist-test.toolforge.org/w/load.php?lang=en-gb&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue&skin=vector-2022&version=1a11e:181:714
fire@https://wishlist-test.toolforge.org/w/load.php?lang=en-gb&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue&skin=vector-2022&version=1a11e:177:705
fireWith@https://wishlist-test.toolforge.org/w/load.php?lang=en-gb&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue&skin=vector-2022&version=1a11e:178:903
fire@https://wishlist-test.toolforge.org/w/load.php?lang=en-gb&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue&skin=vector-2022&version=1a11e:178:947
fire@https://wishlist-test.toolforge.org/w/load.php?lang=en-gb&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue&skin=vector-2022&version=1a11e:177:705
fireWith@https://wishlist-test.toolforge.org/w/load.php?lang=en-gb&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue&skin=vector-2022&version=1a11e:178:903
Deferred/</deferred[tuple[0]]@https://wishlist-test.toolforge.org/w/load.php?lang=en-gb&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue&skin=vector-2022&version=1a11e:182:471
ajax/xhr<@https://wishlist-test.toolforge.org/w/load.php?lang=en-gb&modules=mediawiki.api&skin=vector-2022&version=18hsa:4:372
fire@https://wishlist-test.toolforge.org/w/load.php?lang=en-gb&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue&skin=vector-2022&version=1a11e:177:705
fireWith@https://wishlist-test.toolforge.org/w/load.php?lang=en-gb&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue&skin=vector-2022&version=1a11e:178:903
done@https://wishlist-test.toolforge.org/w/load.php?lang=en-gb&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue&skin=vector-2022&version=1a11e:262:417
send/callback/<@https://wishlist-test.toolforge.org/w/load.php?lang=en-gb&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue&skin=vector-2022&version=1a11e:266:67
EventHandlerNonNull*send@https://wishlist-test.toolforge.org/w/load.php?lang=en-gb&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue&skin=vector-2022&version=1a11e:266:288
ajax@https://wishlist-test.toolforge.org/w/load.php?lang=en-gb&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue&skin=vector-2022&version=1a11e:261:137
ajax@https://wishlist-test.toolforge.org/w/load.php?lang=en-gb&modules=mediawiki.api&skin=vector-2022&version=18hsa:3:751
get@https://wishlist-test.toolforge.org/w/load.php?lang=en-gb&modules=mediawiki.api&skin=vector-2022&version=18hsa:2:354
setProposalData@https://wishlist-test.toolforge.org/w/load.php?lang=en-gb&modules=ext.gadget.WishlistIntake&skin=vector-2022&version=1ru3n:43:298
beforeMount@https://wishlist-test.toolforge.org/w/load.php?lang=en-gb&modules=ext.gadget.WishlistIntake&skin=vector-2022&version=1ru3n:44:842
resources/lib/vue/vue.js/ms/Vue/Vue<@https://wishlist-test.toolforge.org/w/load.php?lang=en-gb&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue&skin=vector-2022&version=1a11e:506:995
jt@https://wishlist-test.toolforge.org/w/load.php?lang=en-gb&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue&skin=vector-2022&version=1a11e:490:309
Ht@https://wishlist-test.toolforge.org/w/load.php?lang=en-gb&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue&skin=vector-2022&version=1a11e:490:381
resources/lib/vue/vue.js/fs/t.__weh@https://wishlist-test.toolforge.org/w/load.php?lang=en-gb&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue&skin=vector-2022&version=1a11e:506:876
P@https://wishlist-test.toolforge.org/w/load.php?lang=en-gb&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue&skin=vector-2022&version=1a11e:474:403
c@https://wishlist-test.toolforge.org/w/load.php?lang=en-gb&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue&skin=vector-2022&version=1a11e:526:819
run@https://wishlist-test.toolforge.org/w/load.php?lang=en-gb&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue&skin=vector-2022&version=1a11e:480:868
resources/lib/vue/vue.js/ko/B/e.update@https://wishlist-test.toolforge.org/w/load.php?lang=en-gb&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue&skin=vector-2022&version=1a11e:527:306
B@https://wishlist-test.toolforge.org/w/load.php?lang=en-gb&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue&skin=vector-2022&version=1a11e:527:333
M@https://wishlist-test.toolforge.org/w/load.php?lang=en-gb&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue&skin=vector-2022&version=1a11e:525:631
F@https://wishlist-test.toolforge.org/w/load.php?lang=en-gb&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue&skin=vector-2022&version=1a11e:523:898
v@https://wishlist-test.toolforge.org/w/load.php?lang=en-gb&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue&skin=vector-2022&version=1a11e:521:38
Z@https://wishlist-test.toolforge.org/w/load.php?lang=en-gb&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue&skin=vector-2022&version=1a11e:531:978
mount@https://wishlist-test.toolforge.org/w/load.php?lang=en-gb&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue&skin=vector-2022&version=1a11e:513:219
resources/lib/vue/vue.js/e.createApp/t.mount@https://wishlist-test.toolforge.org/w/load.php?lang=en-gb&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue&skin=vector-2022&version=1a11e:613:872
WishlistIntake.js/</</<@https://wishlist-test.toolforge.org/w/load.php?lang=en-gb&modules=ext.gadget.WishlistIntake&skin=vector-2022&version=1ru3n:52:235
promise callback*WishlistIntake.js/</<@https://wishlist-test.toolforge.org/w/load.php?lang=en-gb&modules=ext.gadget.WishlistIntake&skin=vector-2022&version=1ru3n:51:929
mightThrow@https://wishlist-test.toolforge.org/w/load.php?lang=en-gb&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue&skin=vector-2022&version=1a11e:180:648
Deferred/then/resolve/</process<@https://wishlist-test.toolforge.org/w/load.php?lang=en-gb&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue&skin=vector-2022&version=1a11e:181:309
setTimeout handler*Deferred/then/resolve/<@https://wishlist-test.toolforge.org/w/load.php?lang=en-gb&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue&skin=vector-2022&version=1a11e:181:714
fire@https://wishlist-test.toolforge.org/w/load.php?lang=en-gb&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue&skin=vector-2022&version=1a11e:177:705
add@https://wishlist-test.toolforge.org/w/load.php?lang=en-gb&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue&skin=vector-2022&version=1a11e:178:222
Deferred/then/<@https://wishlist-test.toolforge.org/w/load.php?lang=en-gb&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue&skin=vector-2022&version=1a11e:181:894
Deferred@https://wishlist-test.toolforge.org/w/load.php?lang=en-gb&modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cjquery%2Coojs-ui-core%2Cvue&skin=vector-2022&version=1a11e:182:611
 undefined load.php:183:554

I also notice that those wishes are not included in the wish index:
https://wishlist-test.toolforge.org/wiki/Community_Wishlist/Wishes

Steps to reproduce problem

Examples of problematic wishes:

https://wishlist-test.toolforge.org/w/index.php?title=Community_Wishlist/Wishes/Wish_is_null_G&editwish=1 (unbalanced <syntaxhighlight>)
https://wishlist-test.toolforge.org/w/index.php?title=Community_Wishlist/Wishes/Wish_is_null_H&editwish=1 (unbalanced <gallery>)
https://wishlist-test.toolforge.org/w/index.php?title=Community_Wishlist/Wishes/Wish_is_null_I&editwish=1 (unbalanced <ref>)

QA Results - Wishlist-test.toolforge

AC	Status	Details
1	❓	T369009#9993323

Details

Other Assignee: GMikesell-WMF

Event Timeline

dom_walden created this task.Jul 2 2024, 8:14 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 2 2024, 8:14 AM

dom_walden updated the task description. (Show Details)Jul 2 2024, 8:17 AM

MusikAnimal claimed this task.Jul 12 2024, 4:20 AM

MusikAnimal edited projects, added: Community-Tech (July 1-12 2024 (Corsac Fox)); removed: Community-Tech.

MusikAnimal moved this task from Ready for dev to In development on the Community-Tech (July 1-12 2024 (Corsac Fox)) board.

musikanimal opened https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/184

init: Show informative error when wish cannot be parsed

MusikAnimal moved this task from In development to Feedback and review on the Community-Tech (July 1-12 2024 (Corsac Fox)) board.Jul 12 2024, 5:51 PM

samwilson merged https://gitlab.wikimedia.org/repos/commtech/wishlist-intake/-/merge_requests/184

init: Show informative error when wish cannot be parsed

• JWheeler-WMF edited projects, added: Community-Tech (Darwin's Fox (July 15-26, 2024)); removed: Community-Tech (July 1-12 2024 (Corsac Fox)).Jul 15 2024, 3:34 PM

• JWheeler-WMF moved this task from Backlog to Feedback and review on the Community-Tech (Darwin's Fox (July 15-26, 2024)) board.

Restricted Application edited projects, added: Community-Tech; removed: Community-Tech (Darwin's Fox (July 15-26, 2024)). · View Herald TranscriptJul 15 2024, 3:34 PM

• JWheeler-WMF moved this task from New & TBD Tickets to Darwin's Fox (July 15-26, 2024) on the Community-Tech board.Jul 16 2024, 1:46 AM

• JWheeler-WMF edited projects, added: Community-Tech (Darwin's Fox (July 15-26, 2024)); removed: Community-Tech.

It's a different error now but we're at least letting the user know if the wish can't be parsed.

Maintenance_bot removed a project: Patch-For-Review.Jul 16 2024, 6:31 PM

@MusikAnimal Can you please review the gif and screenshot if that is what you want on to work if that happens?

Test Result - Wishlist-test.toolforge

Status: ❓NMI
Environment: Wishlist-test.toolforge
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Create a wish and in the wish description include parser tags (e.g. <syntaxhighlight>) that are not correctly closed.

Is that the error you want so this would be wad?	Is it as design not to show up in the Recent Wish table too?

GMikesell-WMF updated the task description. (Show Details)Jul 18 2024, 2:20 AM

GMikesell-WMF updated Other Assignee, added: GMikesell-WMF.

GMikesell-WMF moved this task from QA to in development on the Community-Tech (Darwin's Fox (July 15-26, 2024)) board.

@GMikesell-WMF Sorry for the delay in replying. Yes, the GIF/screenshot you've posted looks like the expected behaaviour.

Is it as design not to show up in the Recent Wish table too?

It's not by design, but it is the same reason the intake form won't load. The bot can't parse the proposal.

We should probably come up with a better way to handle this. Otherwise wishes with unbalanced wikitext never get surfaced. I'm going to leave the task here In Development while I brainstorm a solution.

• JWheeler-WMF edited projects, added: Community-Tech (Ezo Red Fox (July 29 - Aug 9, 2024)); removed: Community-Tech (Darwin's Fox (July 15-26, 2024)).Jul 30 2024, 1:52 AM

• JWheeler-WMF moved this task from Ready for dev to Goals and epics on the Community-Tech (Ezo Red Fox (July 29 - Aug 9, 2024)) board.

MusikAnimal moved this task from Goals and epics to In development on the Community-Tech (Ezo Red Fox (July 29 - Aug 9, 2024)) board.Jul 30 2024, 1:53 AM

MusikAnimal edited projects, added: Community-Tech (Fennec Fox (Aug 12-23, 2024)); removed: Community-Tech (Ezo Red Fox (July 29 - Aug 9, 2024)).Aug 12 2024, 9:05 PM

MusikAnimal moved this task from Ready for dev to In development on the Community-Tech (Fennec Fox (Aug 12-23, 2024)) board.

I have not had a chance to look more into this, but I haven't heard of this issue happening in the wild. So perhaps this is low-priority.

• JWheeler-WMF edited projects, added: Community-Tech (Gray Fox (Aug 26 - Sept 6)); removed: Community-Tech (Fennec Fox (Aug 12-23, 2024)).Aug 26 2024, 3:28 PM

MusikAnimal edited projects, added: Community-Tech (Island Fox (Sept 9 - 20)); removed: Community-Tech (Gray Fox (Aug 26 - Sept 6)).Sep 9 2024, 6:16 PM

Moving this to our backlog as we haven't seen it in production

The Wishlist intake gadget has been superseded by MediaWiki-extensions-CommunityRequests per T366194#11553227, thus declining this task

"jQuery.Deferred exception: wish is null" for some unbalanced parser tagsClosed, DeclinedPublicBUG REPORTActions