Page MenuHomePhabricator

Changes warnings for "depicts" and "date" in UploadWizard to notices
Closed, ResolvedPublic

Description

Changes warnings for "depicts" and "date" in UploadWizard to notices

Event Timeline

Change #1051758 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/UploadWizard@master] Improve error handling

https://gerrit.wikimedia.org/r/1051758

Change #1051758 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@master] Improve error handling

https://gerrit.wikimedia.org/r/1051758

@matthiasmullie - I think I need some clarification on the following from https://gerrit.wikimedia.org/r/1051758

  • the style of warnings has been updated to look like notices

Which warnings have been changed to notices? The good candidate (in my opinion) for such change would be a message that should appear for a pre-filled date from EXIF . (per the not-yet-done spec in T362328):

If the file is ‘own work’ and has a date in the EXIF show that date in the date field by default with a message as shown here

Or it's about the following notice - "We recommend providing a full date if it is known" ?:

Screen Shot 2024-07-04 at 1.13.33 PM.png (634×1 px, 88 KB)

The good candidate (in my opinion) for such change would be a message that should appear for a pre-filled date from EXIF . (per the not-yet-done spec in T362328):

BTW @matthiasmullie I've just downloaded the patch, and this message doesn't show up anymore.

To summarize

  • on commons beta the Date field doesn't display a warning - it's either an error message or a notice
  • I was not able to trigger any message for the depicts field
production commons wmf.12figma designcommons beta
- a warning is displayed as per figma design
Screen Shot 2024-07-08 at 5.00.52 PM.png (1×1 px, 234 KB)
Screen Shot 2024-07-08 at 5.00.35 PM.png (552×1 px, 191 KB)
- a notice is displayed
Screen Shot 2024-07-08 at 4.53.24 PM.png (1×1 px, 230 KB)

Change #1052931 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/UploadWizard@master] Re-introduce notices

https://gerrit.wikimedia.org/r/1052931

@Etonkovidova I misunderstood the ask and thought we wanted to convert all warnings to notice style.
Above patch should change warnings back to their original style, and re-introduce "notices" for "we recommend providing a full date if it is known" (date) and "we recommend keeping the number of items to a maximum of x" (depicts/statements)

As for depicts: the only thing we have there is a notice when more than 3 statements have been selected (from the autocomplete field)
Looks like you had ,,,,, input there (which, I suspect isn't triggering any autocomplete suggestions), which is simply ignored; only things ("chips") selected from the autocomplete matter.
(Nit: we could revise how that input field works and how/when it triggers warnings, but that's a separate thing)

Change #1052946 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):

[mediawiki/extensions/UploadWizard@wmf/1.43.0-wmf.13] Re-introduce notices

https://gerrit.wikimedia.org/r/1052946

Change #1052931 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@master] Re-introduce notices

https://gerrit.wikimedia.org/r/1052931

Change #1052946 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@wmf/1.43.0-wmf.13] Re-introduce notices

https://gerrit.wikimedia.org/r/1052946

Mentioned in SAL (#wikimedia-operations) [2024-07-09T13:38:02Z] <logmsgbot> lucaswerkmeister-wmde@deploy1002 Started scap sync-world: Backport for [[gerrit:1052946|Re-introduce notices (T369053)]]

Mentioned in SAL (#wikimedia-operations) [2024-07-09T14:09:28Z] <logmsgbot> lucaswerkmeister-wmde@deploy1002 lucaswerkmeister-wmde, mlitn: Backport for [[gerrit:1052946|Re-introduce notices (T369053)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-07-09T14:17:19Z] <logmsgbot> lucaswerkmeister-wmde@deploy1002 Finished scap: Backport for [[gerrit:1052946|Re-introduce notices (T369053)]] (duration: 39m 17s)

@Etonkovidova I misunderstood the ask and thought we wanted to convert all warnings to notice style.
Above patch should change warnings back to their original style, and re-introduce "notices" for "we recommend providing a full date if it is known" (date) and "we recommend keeping the number of items to a maximum of x" (depicts/statements)

As for depicts: the only thing we have there is a notice when more than 3 statements have been selected (from the autocomplete field)
Looks like you had ,,,,, input there (which, I suspect isn't triggering any autocomplete suggestions), which is simply ignored; only things ("chips") selected from the autocomplete matter.
(Nit: we could revise how that input field works and how/when it triggers warnings, but that's a separate thing)

Thx, @matthiasmullie! I keep forgetting about that number of depicts limitation. Below is updated screenshots from commons beta - I think now all is in place: the warnings are for EXIF date and for categories; the notices are depicts and when a date entered looks like incomplete.

Updated screenshots from commons beta

Screen Shot 2024-07-09 at 5.54.58 PM.png (1×1 px, 252 KB)
Screen Shot 2024-07-09 at 5.56.00 PM.png (1×1 px, 206 KB)