Page MenuHomePhabricator

Enhance and refactor email sending for rename and vanish process
Closed, ResolvedPublic

Description

We currently have email sending in three places. One in the SpecialGlobalRenameQueue and another in the SpecialGlobalVanishRequest and one in the maintenance script.

All this methods are quite similar and have them duplicated may result is inconsistency depending of where the email is sent from. To mitigate from this issue, we should refactor the email functionality to be able to abstract it and re-use it in the different methods. As part of this refactoring we are also going to take care of an issue with translation.

The current implementations either uses the "stewart" wiki language to send emails (Renamer and vanish), or the current person wiki (SpecialVanishRequest) or english (maintenance). This should be changes to send the email using the "user specific" language.

AC:

  • Refactor the email method to ensure consistency
  • Ensure the email is receipt with the user language in all three scenario

Event Timeline

Amdrel changed the task status from Open to In Progress.Jul 3 2024, 4:01 PM
Amdrel claimed this task.

The action on this ticket was changed to just add the "notes" field in auto approval. this was missing.

The refactoring of the email logic was turning out to be too complicated and risky

SimoneThisDot renamed this task from Refactor email sending to be consistent to Enhance and refactor email sending for rename and vanish process.Jul 12 2024, 8:23 AM
SimoneThisDot reopened this task as Open.
SimoneThisDot updated the task description. (Show Details)

We are reopening this task due to further changes made to the email that have increased the need for a refactor.

Seddon moved this task from Incoming to Done on the Account-Vanishing board.