Soon after all components (mainly alerts & dashboards) using these metrics are migrated to use prometheus instead of graphite we should be able to remove this legacy code.
See comment
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Stop emitting graphite metrics | mediawiki/extensions/CirrusSearch | master | +1 -86 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T343020 Converting MediaWiki Metrics to StatsLib | |||
| Resolved | dcausse | T359033 EPIC: Convert CirrusSearch metrics to statslib | |||
| Resolved | dcausse | T369148 Replace usage of StatsdDataFactory with StatsFactory | |||
| Resolved | bking | T371061 Update CirrusSearch dashboards to use new metrics/refresh dashboards | |||
| Invalid | bking | T372902 Find/replace Graphite metrics with Prometheus metrics | |||
| Declined | None | T376189 Replace the "CirrusSearch.$cluster.updates.all.doc_size" with a new metric that works with SUP |
Event Timeline
Comment Actions
If i understand this correctly, it needs to be delayed by a few weeks. Metrics started getting recorded into prometheus with this weeks train deploy, we likely want to wait for a couple (2?) weeks to transition the graphs so that the graphs still contain the information they contain today. The metrics from StatsdDataFactory shouldn't be removed until after the transition.
Comment Actions
Change #1112240 had a related patch set uploaded (by DCausse; author: DCausse):
[mediawiki/extensions/CirrusSearch@master] Stop emitting graphite metrics
Comment Actions
Change #1112240 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Stop emitting graphite metrics