Page MenuHomePhabricator

Further investigation on globalUser usage from Patch comment
Closed, InvalidPublic

Description

During a previous patch a comment was give: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralAuth/+/1049249/4..11/includes/Special/SpecialGlobalVanishRequest.php#b122.

We should investigate and make sure that all precaution are taken care of, and that the above mentioned implementation works the same as the one mentioned in the comment

Event Timeline

Doing a quick test in my local development, this looks safe for that specific case (auto-approve vanish requests when user hasn't done anything)

  • The admin has the permission to delete only the global account for the user, which makes that user a local-only
  • If that user logs in the system auto-creates a global user for them

So the user cannot exist only locally AND request a vanish (to be auto-approved).

I'm not sure if there's another edge case in which a user (local only, not global) can request a global vanish.