Page MenuHomePhabricator

Inline comments displayed on old revisions of pages should not be selectable
Closed, ResolvedPublic

Description

If viewing an InlineComments comment on an old revision of a page - whether looking directly at that revision, or looking at a page diff - comments right now can be clicked on, which brings up the "Reply", "Close discussion", etc. buttons. That should not be possible - basically, I think if there's an "oldid=" in the URL, comments should not do anything if they are clicked on.

Event Timeline

Change #1053900 had a related patch set uploaded (by Jayanthvikashs; author: Jayanthvikashs):

[mediawiki/extensions/InlineComments@master] Disable selection of InlineComments in old revisions of the page

https://gerrit.wikimedia.org/r/1053900

Change #1053900 merged by jenkins-bot:

[mediawiki/extensions/InlineComments@master] Disable selection of InlineComments in old revisions of the page

https://gerrit.wikimedia.org/r/1053900

Yaron_Koren claimed this task.