Page MenuHomePhabricator

Add a show Headers preference
Closed, ResolvedPublic



Many Wikisource use a pr headers gadget in order to set an option that show by default the header and footer of pages of the Page namespace. This gadget set to true a JS variable used by proofreadpage extension. But, with RessourceLoader 2, this gadget is often loaded after extension JS, and doesn't work.

This patch solve the problem by adding a checkbox in editing preferences.

Version: unspecified
Severity: minor




Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:10 AM
bzimport added a project: ProofreadPage.
bzimport set Reference to bz34942.

zaran.krleza wrote:

I agree it will be cleaner to have an option to set this in user preferences. However, does it work if you add as a dependency of the gadget?

zaran.krleza wrote:

Ok. Patch applied in r114004

(In reply to comment #3)

Ok. Patch applied in r114004

For reference, this was reverted in r114398 and then re-merged in