Add a show Headers preference
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Tpt
	Mar 3 2012, 6:16 PM

Description

Correction

Many Wikisource use a pr headers gadget in order to set an option that show by default the header and footer of pages of the Page namespace. This gadget set to true a JS variable used by proofreadpage extension. But, with RessourceLoader 2, this gadget is often loaded after extension JS, and doesn't work.

This patch solve the problem by adding a checkbox in editing preferences.

Version: unspecified
Severity: minor

Attached:

test.diff2 KBDownload

Details

Reference: bz34942

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:10 AM

• bzimport added a project: ProofreadPage.

• bzimport set Reference to bz34942.

Tpt created this task.Mar 3 2012, 6:16 PM

zaran.krleza wrote:

I agree it will be cleaner to have an option to set this in user preferences. However, does it work if you add ext.proofreadpage.page as a dependency of the gadget?

No, it doesn't because it is ext.proofreadpage.page that depends on the gadget.

See : https://fr.wikisource.org/w/index.php?title=MediaWiki%3AGadgets-definition&diff=3301228&oldid=3301223

zaran.krleza wrote:

Ok. Patch applied in r114004

(In reply to comment #3)

Ok. Patch applied in r114004

For reference, this was reverted in r114398 and then re-merged in https://gerrit.wikimedia.org/r/3466.

GOIII moved this task from Backlog to Done: to deploy/check on the ProofreadPage board.Jun 12 2016, 3:13 AM

Add a show Headers preferenceClosed, ResolvedPublicActions

Description

Details

Event Timeline

Add a show Headers preference
Closed, ResolvedPublic
Actions