The WikimediaUI-Base library has been superseded by Codex, and is being sunset (T354310, T334934).
However, PCS still depends on WikimediaUI-Base for its design tokens. Let's bring in the latest Codex tokens for PCS's usage of Dark and Light themes. (And let's even consider upstreaming our tokens for Black and Sepia themes.)
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Migrate to Codex from WikimediaUI-Base. | mediawiki/services/mobileapps | master | +75 -197 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | TLessa-WMF | T299778 iOS Component Library | |||
| Open | None | T384832 Align iOS and Android colors with Codex | |||
| Resolved | Volker_E | T334934 [EPIC] Replace WikimediaUI Base variables with Codex design tokens (mediawiki.skin.variables) | |||
| Resolved | Dbrant | T369434 Move PCS service from WikimediaUI Base to Codex |
Wait, @Dbrant do the apps (through PCS) rely on Wikimedia-UI Base for its theme system?
The apps rely on PCS only for rendering articles, and all the styled elements within articles. Aside from that (i.e. for styling native components for the rest of our features) we do not use wikimedia-ui-base.
@Dbrant @JTannerWMF Thanks for picking this up! What would/could DST do to make this workable.
From my POV apps and PCS are not using wikimedia-ui-base as dependency, just an outdated copy. We can proceed with sunsetting it.
The transformation to Codex is as simple as updating it itself.
A bigger question is if the apps would benefit from Codex tokens as dependency with an export format as shown in proof-of-concept in https://gerrit.wikimedia.org/r/c/design/codex/+/856036 on task T327200: [Spike] Explore tokens export to mobile platforms Android and iOS
Thanks @Volker_E -- Could you clarify what you mean by "transformation to Codex is as simple as updating it itself"?
Here's where PCS declares its dependency on wikimedia-ui-base:
https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/services/mobileapps/+/refs/heads/master/pagelib/package.json#110
And this where PCS imports wikimedia-ui-base as the basis of our color themes:
https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/services/mobileapps/+/refs/heads/master/pagelib/src/transform/Constants.less#1
Do you mean that we can drop-in Codex in place of wikimedia-ui-base, and it would just work? (what should we import there instead?)
FYI @DTorsani-WMF and @cmadeo - when this work is started, there will be some sepia and black theme colour tokens that DST/Design need to determine how to incorporate (upstreaming directly and/or with some changes to specific colours colours)...
Change #1080748 had a related patch set uploaded (by Dbrant; author: Dbrant):
[mediawiki/services/mobileapps@master] [WIP] Migrate to Codex from WikimediaUI-Base.
iOS screenshots (prod vs. patch) are here - https://drive.google.com/drive/folders/10ourn-PGeq_FWBWWuhWYsDTt8Ounx97a?usp=drive_link
...and Android screenshots (prod vs. patch): https://drive.google.com/drive/folders/1Yoa3SMs3yfuviCNsm-ZVQIPr5V-rsSM9?usp=drive_link
Change #1080748 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] Migrate to Codex from WikimediaUI-Base.