Page MenuHomePhabricator

Update PCS to no longer store local copies of styles
Closed, ResolvedPublic

Description

PCS creates a bundle of CSS styles from a number of .less files collected from common extensions and the Minerva skin.
Currently this collection must be updated manually, and is long overdue for an update, especially considering the development of Dark mode in Minerva.
Keeping local copies of styles also inevitably leads to issues when the styles no longer apply to the HTML output of one or more extensions.

  • If updating the styles is currently done manually, let's consider programmatic ways of updating styles, preferably on a schedule.
  • Make sure the latest dark mode affordances from Minerva and/or MediaWiki itself are included, such as skin-invert and skin-invert-image etc.
  • In addition to styles referenced from Minerva, there are styles in the WikimediaMessages extension relevant to dark mode that may be worth including.
  • Since the updated styles likely supersede any theme overrides currently in PCS (e.g. most of the things here), let's audit and trim away anything we're doing manually in PCS, since at this point it's likely to be conflicting with styles in Minerva.

Event Timeline

+1 through the support email:
Version: 2.7.50504-r-2024-10-01
Device: OPPO CPH2099 (SDK: 30)

REQUEST: Support 'class=skin-invert' in the [[File:]] tag for dark mode.

https://en.wikipedia.org/wiki/Wikipedia%3AExtended_image_syntax?wprov=sfla1

Change #1082532 had a related patch set uploaded (by Dbrant; author: Dbrant):

[mediawiki/services/mobileapps@master] [Hyper WIP] Use ResourceLoader instead of local copies of styles.

https://gerrit.wikimedia.org/r/1082532

Dbrant renamed this task from Update PCS styles to match current Minerva styles for dark mode. to Update PCS to no longer store local copies of styles.May 28 2025, 12:24 PM
Dbrant updated the task description. (Show Details)

Change #1082532 merged by Cooltey:

[mediawiki/services/mobileapps@master] Use ResourceLoader instead of local copies of styles.

https://gerrit.wikimedia.org/r/1082532

Change #1167251 had a related patch set uploaded (by Dbrant; author: Dbrant):

[mediawiki/services/mobileapps@master] Additional cleanup after switching away from local copies of styles.

https://gerrit.wikimedia.org/r/1167251

Change #1167282 had a related patch set uploaded (by Dbrant; author: Dbrant):

[mediawiki/services/mobileapps@master] (Temporarily) revert built style artifacts.

https://gerrit.wikimedia.org/r/1167282

Change #1167282 merged by jenkins-bot:

[mediawiki/services/mobileapps@master] (Temporarily) revert built style artifacts.

https://gerrit.wikimedia.org/r/1167282

Change #1167251 merged by jenkins-bot:

[mediawiki/services/mobileapps@master] Additional cleanup after switching away from local copies of styles.

https://gerrit.wikimedia.org/r/1167251