Page MenuHomePhabricator
Create Task
Maniphest T369447

Flaky Wikibase GetItemStatementTest in CI
Closed, ResolvedPublic
Actions

Description

We're seeing Wikibase REST API api-testing fail flakily quite often in our CI runs. As far as I can see, it is always these two tests:

00:09:41.967   2 failing
00:09:41.967 
00:09:41.967   1) GET statement
00:09:41.967        getItemStatement
00:09:41.967          can get a statement with a deleted property:
00:09:41.967      AssertionError: expected 'string' to equal null
00:09:41.967       at Context.<anonymous> (tests/mocha/api-testing/GetItemStatementTest.js:68:12)
00:09:41.967       at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
00:09:41.968 
00:09:41.968   2) GET statement
00:09:41.968        getStatement
00:09:41.968          can get a statement with a deleted property:
00:09:41.968      AssertionError: expected 'string' to equal null
00:09:41.968       at Context.<anonymous> (tests/mocha/api-testing/GetItemStatementTest.js:68:12)
00:09:41.968       at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
00:09:41.968 
00:09:41.968 
00:09:41.968 
00:09:42.002 ERROR: "api-testing:e2e" exited with 2.
00:09:42.054 ERROR: "api-testing:rest-api" exited with 1.

Recent occurrences:

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
REST: Retry flaky deleted property e2e testsmediawiki/extensions/Wikibasemaster+24 -2
REST: Fix flaky deleted property e2e testmediawiki/extensions/Wikibasemaster+2 -0
REST: Fix flaky deleted property e2e testmediawiki/extensions/Wikibasemaster+2 -0
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT371913 [EPIC] Track common CI failures
 ResolvedJakob_WMDET369447 Flaky Wikibase GetItemStatementTest in CI

Event Timeline

Michael created this task.Jul 7 2024, 8:08 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 7 2024, 8:08 AM
Michael updated the task description. (Show Details)Jul 7 2024, 8:16 AM
Michael moved this task from Inbox to Blocked on the Growth-Team board.
WMDE-leszek subscribed.Jul 18 2024, 9:52 AM
gerritbot added a comment.Jul 22 2024, 3:36 PM

Change #1055966 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Fix flaky deleted property e2e test

https://gerrit.wikimedia.org/r/1055966

gerritbot added a project: Patch-For-Review.Jul 22 2024, 3:36 PM
Jakob_WMDE claimed this task.Jul 22 2024, 3:38 PM
Jakob_WMDE moved this task from Incoming tickets outside WPP to Sprint 24 on the Wikibase Reuse Team board.
Jakob_WMDE edited projects, added: Wikibase Reuse Team (Sprint 24); removed: Wikibase Reuse Team.
Jakob_WMDE moved this task from To Do to Peer Review on the Wikibase Reuse Team (Sprint 24) board.Jul 23 2024, 8:22 AM
Ifrahkhanyaree_WMDE edited projects, added: Wikibase Reuse Team (Sprint 25); removed: Wikibase Reuse Team (Sprint 24).Jul 23 2024, 9:57 AM
Ifrahkhanyaree_WMDE moved this task from To Do to Peer Review on the Wikibase Reuse Team (Sprint 25) board.
gerritbot added a comment.Jul 23 2024, 2:07 PM

Change #1055966 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Fix flaky deleted property e2e test

https://gerrit.wikimedia.org/r/1055966

Maintenance_bot removed a project: Patch-For-Review.Jul 23 2024, 2:31 PM
Jakob_WMDE moved this task from Peer Review to Done on the Wikibase Reuse Team (Sprint 25) board.Jul 23 2024, 2:35 PM
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.16; 2024-07-30).Jul 23 2024, 3:00 PM
gerritbot added a comment.Jul 23 2024, 3:35 PM

Change #1056190 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@master] REST: Fix flaky deleted property e2e test

https://gerrit.wikimedia.org/r/1056190

gerritbot added a project: Patch-For-Review.Jul 23 2024, 3:35 PM
gerritbot added a comment.Jul 24 2024, 11:14 AM

Change #1056190 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Fix flaky deleted property e2e test

https://gerrit.wikimedia.org/r/1056190

Maintenance_bot removed a project: Patch-For-Review.Jul 24 2024, 11:31 AM
Michael updated the task description. (Show Details)Jul 25 2024, 4:40 PM
Ollie.Shotton_WMDE subscribed.Jul 26 2024, 9:08 AM
Ifrahkhanyaree_WMDE moved this task from Backlog to Done on the Wikibase REST API (WPP) board.Jul 26 2024, 2:37 PM
Ifrahkhanyaree_WMDE moved this task from Done to Happening now on the Wikibase REST API (WPP) board.
Jakob_WMDE awarded a token.Jul 30 2024, 1:37 PM
• Muhammad_Yasser_Jazirahly_WMDE moved this task from Done to To Do on the Wikibase Reuse Team (Sprint 25) board.Jul 30 2024, 1:37 PM
Jakob_WMDE removed Jakob_WMDE as the assignee of this task.Jul 30 2024, 1:39 PM
Jakob_WMDE subscribed.
Jakob_WMDE claimed this task.Aug 5 2024, 8:31 AM
Jakob_WMDE moved this task from To Do to Doing on the Wikibase Reuse Team (Sprint 25) board.
gerritbot added a comment.Aug 5 2024, 9:00 AM

Change #1059836 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Retry flaky deleted property e2e tests

https://gerrit.wikimedia.org/r/1059836

gerritbot added a project: Patch-For-Review.Aug 5 2024, 9:00 AM
Jakob_WMDE moved this task from Doing to Peer Review on the Wikibase Reuse Team (Sprint 25) board.Aug 5 2024, 10:15 AM
gerritbot added a comment.Aug 5 2024, 1:49 PM

Change #1059836 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Retry flaky deleted property e2e tests

https://gerrit.wikimedia.org/r/1059836

ReleaseTaggerBot edited projects, added: MW-1.43-notes (1.43.0-wmf.17; 2024-08-06); removed: MW-1.43-notes (1.43.0-wmf.16; 2024-07-30).Aug 5 2024, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 5 2024, 2:30 PM
Jakob_WMDE moved this task from Peer Review to Done on the Wikibase Reuse Team (Sprint 25) board.Aug 5 2024, 3:30 PM
Ifrahkhanyaree_WMDE closed this task as Resolved.Aug 6 2024, 10:23 AM
Michael updated the task description. (Show Details)Aug 7 2024, 12:33 PM
Ollie.Shotton_WMDE reopened this task as Open.Aug 7 2024, 1:45 PM
Ollie.Shotton_WMDE edited projects, added: Wikibase Reuse Team (Sprint 26); removed: Wikibase Reuse Team (Sprint 25).
Ollie.Shotton_WMDE added a parent task: T371913: [EPIC] Track common CI failures.
Ollie.Shotton_WMDE moved this task from To Do to Doing on the Wikibase Reuse Team (Sprint 26) board.
Jakob_WMDE moved this task from Doing to Peer Review on the Wikibase Reuse Team (Sprint 26) board.Aug 7 2024, 2:36 PM
Silvan_WMDE moved this task from Peer Review to Done on the Wikibase Reuse Team (Sprint 26) board.Aug 8 2024, 9:05 AM
Ifrahkhanyaree_WMDE closed this task as Resolved.Aug 20 2024, 10:01 AM
Ifrahkhanyaree_WMDE moved this task from Happening now to Done on the Wikibase REST API (WPP) board.Aug 22 2024, 12:00 PM
Lucas_Werkmeister_WMDE mentioned this in T400265: Flaky Wikibase GetItemStatementTest in CI (July 2025 edition).Jul 23 2025, 2:07 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits