Page MenuHomePhabricator

Enhance the auto-vanish maintenance script
Closed, ResolvedPublic

Description

After all development of phase 3, we need to be able to apply the new features and changes to the maintenance script.

AC:

  • Ensure all users with no edit and no log are autovanished if possible
  • Ensure that all users with blocks are NOT added to the queue
  • Automatically create a CSV that include info on what the script did (this can be done with a simple echo > output.csv). The file will have a column with a zendesk ID and another with the outcome (blocked, autovanish or in queue).

Related Objects

Event Timeline

Mimurawil changed the task status from Open to In Progress.Jul 8 2024, 3:40 PM
Mimurawil claimed this task.

Heads up that auto-vanish requires the performer user to be a mandatory input for the script (this was optional before).

Change #1052811 had a related patch set uploaded (by Mimurawil; author: Mimurawil):

[mediawiki/extensions/CentralAuth@master] Enhance the auto-vanish maintenance script

https://gerrit.wikimedia.org/r/1052811

Test wiki created on Patch demo by SimoneThisDot using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/f5a7b80242/w

Change #1053294 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/CentralAuth@master] Introduce Vanish Request Flow

https://gerrit.wikimedia.org/r/1053294

Test wiki created on Patch demo by SimoneThisDot using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/0f344e95cc/w

Change #1052811 abandoned by Seddon:

[mediawiki/extensions/CentralAuth@master] Enhance the auto-vanish maintenance script

Reason:

Replaced by a flattened patch https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralAuth/+/1053294

https://gerrit.wikimedia.org/r/1052811

Change #1053620 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/CentralAuth@master] Add auto-vanish in renamer queue

https://gerrit.wikimedia.org/r/1053620

Change #1053620 abandoned by Seddon:

[mediawiki/extensions/CentralAuth@master] Add auto-vanish in renamer queue

Reason:

See Simone's comment

https://gerrit.wikimedia.org/r/1053620

Test wiki created on Patch demo by SimoneThisDot using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/bb21f4e4bf/w

Change #1053294 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Introduce Vanish Request Flow

https://gerrit.wikimedia.org/r/1053294

Change #1054571 had a related patch set uploaded (by Urbanecm; author: Simone Cuomo):

[mediawiki/extensions/CentralAuth@wmf/1.43.0-wmf.13] Introduce Vanish Request Flow

https://gerrit.wikimedia.org/r/1054571

Change #1054571 abandoned by Urbanecm:

[mediawiki/extensions/CentralAuth@wmf/1.43.0-wmf.13] Introduce Vanish Request Flow

https://gerrit.wikimedia.org/r/1054571

Change #1054572 had a related patch set uploaded (by Urbanecm; author: Simone Cuomo):

[mediawiki/extensions/CentralAuth@wmf/1.43.0-wmf.13] Introduce Vanish Request Flow

https://gerrit.wikimedia.org/r/1054572

Change #1054572 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@wmf/1.43.0-wmf.13] Introduce Vanish Request Flow

https://gerrit.wikimedia.org/r/1054572

Mentioned in SAL (#wikimedia-operations) [2024-07-16T14:25:47Z] <urbanecm@deploy1002> Started scap sync-world: Backport for [[gerrit:1054572|Introduce Vanish Request Flow (T367329 T367726 T367728 T367729 T367744 T368177 T368285 T368368 T368372 T368611 T369489)]], [[gerrit:1054573|Pass wiki id to actor store for cross-db hasPublicLogs query (T370059)]], [[gerrit:1054574|Properly set automatic vanish performer on GlobalRenameUser (T368177)]], [[gerrit:1053373|Enable account vanishing

Mentioned in SAL (#wikimedia-operations) [2024-07-16T14:53:37Z] <urbanecm@deploy1002> dbrant, urbanecm: Backport for [[gerrit:1054572|Introduce Vanish Request Flow (T367329 T367726 T367728 T367729 T367744 T368177 T368285 T368368 T368372 T368611 T369489)]], [[gerrit:1054573|Pass wiki id to actor store for cross-db hasPublicLogs query (T370059)]], [[gerrit:1054574|Properly set automatic vanish performer on GlobalRenameUser (T368177)]], [[gerrit:1053373|Enable account vanishing in Cen

Mentioned in SAL (#wikimedia-operations) [2024-07-16T15:01:39Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:1054572|Introduce Vanish Request Flow (T367329 T367726 T367728 T367729 T367744 T368177 T368285 T368368 T368372 T368611 T369489)]], [[gerrit:1054573|Pass wiki id to actor store for cross-db hasPublicLogs query (T370059)]], [[gerrit:1054574|Properly set automatic vanish performer on GlobalRenameUser (T368177)]], [[gerrit:1053373|Enable account vanishing in Centra

Change #1054598 had a related patch set uploaded (by Dbrant; author: Dbrant):

[mediawiki/extensions/CentralAuth@master] Improve error handling in batchVanishUsers script.

https://gerrit.wikimedia.org/r/1054598

I tested the enhancement to the test failure here:

image.png (88×1 px, 25 KB)

Change #1054598 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Improve error handling in batchVanishUsers script.

https://gerrit.wikimedia.org/r/1054598