Page MenuHomePhabricator

EasyTimeline hardcodes interwiki links rather than using the proper interwiki map
Closed, ResolvedPublic

Description

if ($link =~
    /^\[\[ (?:.{2,3}|(?:zh\-.*)|simple|minnan|tokipona) \: .+\]\]$/xi
    )    # has a interwiki link prefix
{

    # This will fail for all interwiki links other than Wikipedia.
    $wiki  = lc($link);
    $title = $link;
    $wiki  =~ s/\[\[([^\:]+)\:.*$/$1/x;
    $title =~ s/^[^\:]+\:(.*)\]\]$/$1/x;
    $title =~ s/ /_/g;
    $link = "http://$wiki.wikipedia.org/wiki/$title";
    $link = &EncodeURL($title);
    if (($hint eq "") && ($title ne "")) { $hint = "$wiki: $title"; }

Details

Event Timeline

Change #1053051 had a related patch set uploaded (by Pppery; author: Pppery):

[mediawiki/extensions/timeline@master] Remove broken interwiki support

https://gerrit.wikimedia.org/r/1053051

Change #1053051 merged by jenkins-bot:

[mediawiki/extensions/timeline@master] Remove broken interwiki support

https://gerrit.wikimedia.org/r/1053051