Page MenuHomePhabricator
Create Task
Maniphest T369539

Remove migration code from Hooks.php
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Now that wgCheckUserEventTablesMigrationStage has been set to SCHEMA_COMPAT_NEW, the value can be assumed to always be SCHEMA_COMPAT_NEW and the configuration value can be removed.

This task will be done after T366781: Run maintenance script to delete entries only for use when reading old on WMF wikis. This means that this task can also remove references to cuc_only_for_read_old.

Acceptance criteria
  • Remove wgCheckUserEventTablesMigrationStage and other migration related code from Hooks.php (assuming the value of SCHEMA_COMPAT_NEW where necessary)

Details

SubjectRepoBranchLines +/-
Move Hooks::updateCheckUserData to CheckUserInsert servicemediawiki/extensions/CheckUsermaster+291 -407
Remove wgCheckUserEventTablesMigrationStage for user created handlermediawiki/extensions/CheckUsermaster+56 -117
Remove wgCheckUserEventTablesMigrationStage for reset email handlermediawiki/extensions/CheckUsermaster+58 -100
Remove wgCheckUserEventTablesMigrationStage for email handlermediawiki/extensions/CheckUsermaster+229 -221
Remove wgCheckUserEventTablesMigrationStage for login handlermediawiki/extensions/CheckUsermaster+290 -411
Remove wgCheckUserEventTablesMigrationStage for logout handlermediawiki/extensions/CheckUsermaster+176 -137
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolvedDreamy_JazzT366546 Remove wgCheckUserEventTablesMigrationStage and related migration code
ResolvedDreamy_JazzT366507 Remove 'CheckUserInsertForRecentChange' hook
ResolvedDreamy_JazzT369539 Remove migration code from Hooks.php
ResolvedDreamy_JazzT341830 Create maintenance script to delete entries only for read old
· · ·

Event Timeline

Dreamy_Jazz created this task.Jul 8 2024, 5:37 PM
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptJul 8 2024, 5:37 PM
gerritbot added a comment.Jul 8 2024, 5:37 PM

Change #1052729 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Remove wgCheckUserEventTablesMigrationStage for logout handler

https://gerrit.wikimedia.org/r/1052729

gerritbot added a project: Patch-For-Review.Jul 8 2024, 5:37 PM

Change #1052735 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Remove wgCheckUserEventTablesMigrationStage for login handler

https://gerrit.wikimedia.org/r/1052735

gerritbot added a comment.Jul 8 2024, 5:38 PM

Change #1052744 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Remove wgCheckUserEventTablesMigrationStage for email handler

https://gerrit.wikimedia.org/r/1052744

gerritbot added a comment.Jul 8 2024, 5:38 PM

Change #1052747 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Remove wgCheckUserEventTablesMigrationStage for reset email handler

https://gerrit.wikimedia.org/r/1052747

gerritbot added a comment.Jul 8 2024, 5:39 PM

Change #1052758 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Remove wgCheckUserEventTablesMigrationStage for user created handler

https://gerrit.wikimedia.org/r/1052758

gerritbot added a comment.Jul 8 2024, 5:40 PM

Change #1052788 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] [WIP] Move Hooks::updateCheckUserData to CheckUserInsert service

https://gerrit.wikimedia.org/r/1052788

gerritbot added a comment.Jul 8 2024, 5:40 PM

Change #1052787 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] [WIP] Move RecentChanges save handler to separate file

https://gerrit.wikimedia.org/r/1052787

Dreamy_Jazz added a subtask: T341830: Create maintenance script to delete entries only for read old.Jul 8 2024, 5:45 PM
Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Cajon (Jun 24 - July 5)) board.
Dreamy_Jazz set the point value for this task to 3.
Dreamy_Jazz moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Cajon (Jun 24 - July 5)) board.Jul 9 2024, 11:36 AM
Dreamy_Jazz closed subtask T341830: Create maintenance script to delete entries only for read old as Resolved.Jul 10 2024, 9:33 AM
gerritbot added a comment.Jul 10 2024, 6:06 PM

Change #1052729 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Remove wgCheckUserEventTablesMigrationStage for logout handler

https://gerrit.wikimedia.org/r/1052729

gerritbot added a comment.Jul 10 2024, 6:33 PM

Change #1052735 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Remove wgCheckUserEventTablesMigrationStage for login handler

https://gerrit.wikimedia.org/r/1052735

Dreamy_Jazz added a parent task: T366507: Remove 'CheckUserInsertForRecentChange' hook.Jul 10 2024, 7:40 PM
gerritbot added a comment.Jul 11 2024, 2:40 PM

Change #1052744 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Remove wgCheckUserEventTablesMigrationStage for email handler

https://gerrit.wikimedia.org/r/1052744

gerritbot added a comment.Jul 11 2024, 2:57 PM

Change #1052747 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Remove wgCheckUserEventTablesMigrationStage for reset email handler

https://gerrit.wikimedia.org/r/1052747

gerritbot added a comment.Jul 11 2024, 4:42 PM

Change #1052758 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Remove wgCheckUserEventTablesMigrationStage for user created handler

https://gerrit.wikimedia.org/r/1052758

gerritbot added a comment.Jul 11 2024, 4:51 PM

Change #1052788 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Move Hooks::updateCheckUserData to CheckUserInsert service

https://gerrit.wikimedia.org/r/1052788

Dreamy_Jazz moved this task from Needs Review to Needs QA on the Trust and Safety Product Sprint (Sprint Cajon (Jun 24 - July 5)) board.Jul 11 2024, 7:38 PM
Tchanders moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Cajon (Jun 24 - July 5)) board.Jul 14 2024, 2:01 PM
Tchanders closed this task as Resolved.Jul 15 2024, 11:03 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits