Page MenuHomePhabricator

[S] Instrument web preference reason for banner not being shown
Closed, ResolvedPublic1 Estimated Story Points

Description

Background

The iOS app now honors a user's web preferences for opting-out of donation banners, T352306. We want to measure the effect that honoring this setting is having on banner impressions within the iOS app.

Requirements
  • Measure each time an in-app banner is not displayed because we are honoring a logged-in user's preference from Web.
Tasks
  • Analytics - Document how instrumentation should be updated
  • Engineers update instrumentation based on specs from Shay
  • Analytics - Data validation once in beta (or active campaign if necessary)

Due Date: this should be completed by end of September 2024, or before the next banner campaign (whichever comes first).

Engineering Notes

  • Add logging method to the DonateFunnel. Also please rename this file to "DonateFunnel.swift", this was missed from a past class rename.
  • Here in the ArticleViewController+Announcements extension, if isOptedIn = false, call logging method.

QA Notes

You can test this in Staging 7.5.9 (93).

  1. Fresh install Staging 7.5.9 (93). Log into account. On Desktop Wikipedia, make sure account has Preferences > Banners > Fundraising checkmark off.
  2. Go to developer settings menu, turn on wmflabs setting for analytics.
  3. Background app, foreground, pull to refresh on Explore.
  4. Visit article on EN Wikipedia.
  5. Confirm banner is not seen, but new analytics event indicating banner was suppressed appears in wmflabs analytics portal.

Event Timeline

@HNordeenWMF good call that we should be measuring this, thanks. I added a slide to Apps Donor Experience Instrumentation Documentation with an event for when banner impression is withheld. Since user is setting preference on Web we will not track a user setting change event unless there is a way for user to opt out from within the app. Engineers please lmk if this is an option.

@SNowick_WMF Ok, thanks! There is not currently a way for user to opt out from within the app, it's only on Web

Tsevener renamed this task from Instrument web preference reason for banner not being shown to [S] Instrument web preference reason for banner not being shown.Aug 28 2024, 7:21 PM
Seddon set the point value for this task to 1.Aug 29 2024, 12:32 PM

@SNowick_WMF Just confirming - is it okay that we use the campaign ID format as established in T352717? So it looks something like:

stream: app_donor_experience
active_interface: article_banner
action: impression_suppressed_user_pref
action_data: "campaign_id:enUS_2024_11_iOS",

Tsevener updated the task description. (Show Details)
Tsevener added a subscriber: GOlson-WMF.

Created validation subtask, will add that onto the board in mid October once we have had campaigns live