Page MenuHomePhabricator

Change the "date" to "last updated" vs "created"
Closed, ResolvedPublic

Assigned To
None
Authored By
JWheeler-WMF
Jul 8 2024, 8:34 PM
Referenced Files
F56629801: 2024-07-23_16-41-48.png
Jul 24 2024, 12:10 AM
F56629763: 2024-07-23_16-41-34.png
Jul 24 2024, 12:10 AM
F56629759: 2024-07-23_16-41-48.png
Jul 24 2024, 12:10 AM
F56629753: 2024-07-23_15-57-29.png
Jul 24 2024, 12:10 AM
F56629744: 2024-07-23_16-06-24.png
Jul 24 2024, 12:10 AM
F56365333: 2024-07-11_18-52-56.png
Jul 12 2024, 1:58 AM
F56365328: 2024-07-11_18-51-33.png
Jul 12 2024, 1:58 AM
F56365326: 2024-07-11_18-52-37.png
Jul 12 2024, 1:58 AM

Description

Background:
As stakeholders at the foundation, we should have a pulse on which wishes are seeing edits and updates. If we are unable to quickly parse when a wish is last updated, we may miss seeing the "latest" for a new wish.

User story:
Given that I am viewing the table of wishes on the dashboard or wish index page, when a wish is created or updated, then it should appear at the top of the dashboard, and I should see a timestamp of the last-updated date.

Derived Requirement

Change the "date" label to "last updated" on the wish dashboard to reflect the latest modification date, ensuring that the most recently updated wishes appear at the top. The original "created" date should still be displayed on the wish detail page.

BDD

Feature: Display "Last Updated" Date on Wishes

Scenario: Show "last updated" date on the wish dashboard

Given a user is viewing the wish dashboard
When a wish is created or updated
Then the wish should appear at the top of the dashboard
And the "last updated" date should be displayed
And the "created" date should be shown on the wish detail page
Test Steps

Test Case 1: Verify "Last Updated" Date Display

Navigate to the wish dashboard.
Create a new wish and note the creation date.
Update the wish.
✅❓❌⬜ AC1: Verify that the wish detail page shows both "created" and "last updated" dates and confirm the wish appears at the top of the dashboard with the "last updated" date.

Acceptance criteria

  • The timestamp in the table of wishes should correspond to "last updated"
  • When a wish is updated (edited), then it should appear at the top of the table.
  • A new wish should always appear at the top of the table
  • The wish should still show the "created" date in its detail page.

QA Results - Wishlist-test.toolforge

ACStatusDetails
1T369554#9975664

Details

Other Assignee
GMikesell-WMF
TitleReferenceAuthorSource BranchDest Branch
Show and sort by last updated daterepos/commtech/wishlist-intake!178tstarlingwork/tstarling/updated-datemain
Customize query in GitLab

Event Timeline

@tstarling Please review issue below, thanks!

Test Result - Wishlist-test.toolforge

Status: ❌ FAIL
Environment: Wishlist-test.toolforge
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Steps

Test Case 1: Verify "Last Updated" Date Display

  1. Navigate to the wish dashboard.
  2. Create a new wish and note the creation date.
  3. Update the wish.
  4. ❌ AC1: Verify that the wish detail page shows both "created" and "last updated" dates and confirm the wish appears at the top of the dashboard with the "last updated" date.

The title "Lorem ipsum" is below the "Last updated" title in the table, even though "Lorem ipsum" has a more recent date

Recent Wishes TableTitle- Last updatedTitle- Lorem ipsum
2024-07-11_18-52-37.png (654×858 px, 84 KB)
2024-07-11_18-51-33.png (657×1 px, 104 KB)
2024-07-11_18-52-56.png (793×1 px, 108 KB)
GMikesell-WMF updated Other Assignee, added: GMikesell-WMF.
GMikesell-WMF updated the task description. (Show Details)
GMikesell-WMF updated the task description. (Show Details)

Also, can the last updated date be placed before the created date on the wish detail page? I feel this is more important than creation date.

@tstarling Please review issue below, thanks!
The title "Lorem ipsum" is below the "Last updated" title in the table, even though "Lorem ipsum" has a more recent date

The test wiki did not have the relevant code deployed.

@tstarling Issue has been resolved but waiting on Joy to see if he still wants to proceed with "Last updated" to be on top or if he wants this as a separate task.

Test Result - Wishlist-test.toolforge

Status: ❌ FAIL
Environment: Wishlist-test.toolforge
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Steps

Test Case 1: Verify "Last Updated" Date Display

  1. Navigate to the wish dashboard.
  2. Create a new wish and note the creation date.
  3. Update the wish.
  4. ❓ AC1: Verify that the wish detail page shows both "created" and "last updated" dates and confirm the wish appears at the top of the dashboard with the "last updated" date.

The Title is now above when you update

Before WishBefore DashboardUpdate WishUpdate Dashaboard
2024-07-23_16-06-24.png (1×1 px, 204 KB)
2024-07-23_15-57-29.png (1×1 px, 210 KB)
2024-07-23_16-41-48.png (1×2 px, 235 KB)
2024-07-23_16-41-34.png (1×1 px, 206 KB)

@JSengupta-WMF Did you still want "last updated" to be on top as said in T369554#9975821 or do you want to have that on a separate task?

2024-07-23_16-41-48.png (1×2 px, 235 KB)

Yes last updated will be more important that creation date in most cases so would make more sense to appear on top. If it's a small fix and easier to address under this task then let it be here.

tstarling subscribed.