No-JS OOUI DropdownInputWidget arrow isn't visible in dark mode
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson
	Jul 8 2024, 11:33 PM

Description

Discovered during QA of T366372.
Steps to replicate the issue (include links if applicable):

Visit https://en.wikipedia.beta.wmflabs.org/w/index.php?action=edit&title=Polar_bear&venoscript=1 in dark mode

What happens?:

What should have happened instead?:

Arrow should be white

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

A quick fix would be to add the skin-invert and notheme classes to the element
Long term fix would be to use a component that is compatible with dark mode.

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Update OOUI to v0.52.0	mediawiki/core	master	+289 -126
DropdownInputWidget: Fix native `<select>` colors in dark mode	oojs/ui	master	+11 -16
DropdownInputWidget: Redo dropdown arrow for compat with MediaWiki dark mode	oojs/ui	master	+57 -21

Customize query in gerrit

Related Objects

Mentioned In: T370191: AbuseFilter special page is not dark mode friendly
T366372: Enable night theme on action submit and action edit pages (non-JavaScript based edit workflows)
Mentioned Here: T366372: Enable night theme on action submit and action edit pages (non-JavaScript based edit workflows)

Event Timeline

Jdlrobson created this task.Jul 8 2024, 11:33 PM

Restricted Application added a project: Community-Tech. · View Herald TranscriptJul 8 2024, 11:33 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Jdlrobson mentioned this in T366372: Enable night theme on action submit and action edit pages (non-JavaScript based edit workflows).Jul 8 2024, 11:36 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson moved this task from Backlog to Web (MediaWiki) on the dark-mode board.Jul 8 2024, 11:39 PM

Pppery added a project: MediaWiki-Watchlist.Aug 11 2024, 8:54 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptAug 11 2024, 8:54 PM

It seems that the issue is not present anymore.
Checked in betalabs on the article that is linked in the task description - https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Polar_bear&action=edit&venoscript=1

"Watch this page" not checked - the arrow is visible	"Watch this page" is checked - the arrow and the options are visible

Checked in wmf.17 - the results are the same as in the above screenshots.

Screen Shot 2024-08-14 at 3.42.14 PM.png (680×2 px, 152 KB)

for VE summary dialog

Screen Shot 2024-08-14 at 3.41.58 PM.png (1×1 px, 369 KB)

Etonkovidova moved this task from Inbox to Needs Discussion on the Growth-Team board.Aug 14 2024, 11:19 PM

I can still see the issue with JavaScript disabled.

It's a problem with the no-JS OOUI widget, not specific to the watchlist. It can be reproduced everywhere that widget it used, e.g. https://en.wikipedia.beta.wmflabs.org/wiki/Special:Contributions as well.

matmarex renamed this task from Watchlist expiry dropdown arrow isn't visible in dark mode to No-JS OOUI DropdownInputWidget arrow isn't visible in dark mode.Aug 19 2024, 5:10 PM

matmarex removed projects: MediaWiki-Watchlist, Growth-Team, Community-Tech, Expiring-Watchlist-Items.

matmarex triaged this task as High priority.Aug 19 2024, 5:22 PM

matmarex moved this task from Backlog to Next-up on the OOUI board.

This is the last OOUI dark-mode bug now, which makes me really want to fix it.

Change #1154867 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[oojs/ui@master] DropdownInputWidget: Redo dropdown arrow for compat with MediaWiki dark mode

https://gerrit.wikimedia.org/r/1154867

gerritbot added a project: Patch-For-Review.Jun 9 2025, 6:16 PM

Change #1154872 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[oojs/ui@master] DropdownInputWidget: Fix native `<select>` colors in dark mode

https://gerrit.wikimedia.org/r/1154872

Change #1154867 merged by jenkins-bot:

[oojs/ui@master] DropdownInputWidget: Redo dropdown arrow for compat with MediaWiki dark mode

https://gerrit.wikimedia.org/r/1154867

Change #1154872 merged by jenkins-bot:

[oojs/ui@master] DropdownInputWidget: Fix native `<select>` colors in dark mode

https://gerrit.wikimedia.org/r/1154872

Maintenance_bot removed a project: Patch-For-Review.Jun 10 2025, 7:30 PM

matmarex closed this task as Resolved.Jun 10 2025, 8:27 PM

Change #1156368 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] Update OOUI to v0.52.0

https://gerrit.wikimedia.org/r/1156368

gerritbot added a project: Patch-For-Review.Jun 12 2025, 2:29 PM

Change #1156368 merged by jenkins-bot: