Page MenuHomePhabricator

"Cancel" edit button should not be frameless (does not look like a button)
Closed, DeclinedPublicFeature

Description

Here in red is the "cancel" button:

Screenshot 2024-07-09 09.41.37.png (297×1 px, 106 KB)

But because its button outline is missing,
users cannot find it among the button choices.
Only via its red color, do users eventually spot it.

It needs to become the fourth button.

Keep the red color, that's OK.

(Sorry I lost the formatting when editing this report.)

Event Timeline

Jidanni updated the task description. (Show Details)
Jidanni updated the task description. (Show Details)

Indeed, there is some kind of border around Cancel, just not visible enough.

Screenshot 2024-07-09 11.28.40.png (179×575 px, 10 KB)

All I know is a standard HTML <form> will create standard buttons.

Regarding the first screenshot, that is due to framed' => false for mw-editform-cancel in https://phabricator.wikimedia.org/source/mediawiki/browse/master/includes/editpage/EditPage.php$3887 . Not sure if this is an intended OOUI design choice.

Aklapper renamed this task from Make cancel button into a button to "Cancel" edit button should not be frameless (does not look like a button).Jul 9 2024, 8:45 AM
Jdforrester-WMF subscribed.

Making this a frameless button was an intentional design choice to reduce the amount people click on it, because too many people in user tests were clicking on it and were unable to 'see' the more important preview and diff buttons next to it (a framed destructive button is very prominent).

If you're proposing revert changes made by the Editing team, you should justify why more than just saying "users cannot find it". Which users? How often? How much is this compromise worse than the one you're proposing? Etc.

Aklapper changed the task status from Open to Stalled.Jul 9 2024, 12:25 PM

Well perhaps instead of a hacked HTML <form> cancel button, maybe have no cancel button at all.

For instance as I type in this comment, there is only a Submit button below.

Also when filling in a GitHub comment, there is only a Comment button.

And on Facebook when adding a comment, there is only an arrow, etc.

So maybe Cancel buttons are a thing of the past, and should be "canceled" themselves, from the design.

Regarding how then does one cancel, well the other sites mentioned already are confident that users will figure out their favorite way if needed.

Jidanni renamed this task from "Cancel" edit button should not be frameless (does not look like a button) to Cancel buttons are perhaps old-fashioned and can be removed.Jul 9 2024, 1:42 PM
Aklapper renamed this task from Cancel buttons are perhaps old-fashioned and can be removed to "Cancel" edit button should not be frameless (does not look like a button).Jul 9 2024, 3:59 PM