Page MenuHomePhabricator

Header Tabs sometime fails to load
Closed, ResolvedPublicBUG REPORT

Description

Following the discussion "Header Tabs sometime fails to load" : https://www.mediawiki.org/wiki/Extension_talk:Header_Tabs

It seems that the solution is to wrap the OO.ui.infuse js function in the file ext.headertabs.core.js with the ready hook to wait for the DOM to be fully loaded:

$( d ).ready(function() {
var tabs = OO.ui.infuse( $( '.mw-tabs' ) );
});

Can this be added to master and REL1_39 ?

Event Timeline

@Allanext2 - does this solution work for you? I really just wanted confirmation that it solves the problem.

@Yaron_Koren, Yes it works for me.. and from the discussion it seems also for Jongfeli

Change #1052996 had a related patch set uploaded (by Yaron Koren; author: Yaron Koren):

[mediawiki/extensions/HeaderTabs@master] Call OOUI and related code only after document load

https://gerrit.wikimedia.org/r/1052996

Change #1052996 merged by jenkins-bot:

[mediawiki/extensions/HeaderTabs@master] Call OOUI and related code only after document load

https://gerrit.wikimedia.org/r/1052996

@Yaron_Koren I saw the commit on the master branch, when can we expect this to be merged on REL1_39 ?

Thank you

I generally don't make changes to the "REL" branches - I always recommend that people just the "master" branch for my extensions. With that said, if anyone wanted to make such a patch for REL1_39, or any of the other branches, I would merge it in.

Yaron_Koren claimed this task.