Page MenuHomePhabricator

Review IP reveal from a functionary's perspective
Closed, ResolvedPublic

Description

Background

This task tracks testing of the IP reveal feature by functionaries.

The feature is only available if temporary accounts are enabled and CheckUser is loaded. At the time of writing, they are only enabled on beta sites, which don't have CheckUser, so tests would need to be done on Patch Demo.

Once temporary accounts are available on testwiki, the feature can be tested there.

How to test

Setup

Note: if someone has tested this recently as the Patch Demo user, the IPs may already be revealed. If so, create a new user, then use the Patch Demo account to assign your new user the checkuser group. (On Patch Demo, only checkusers have the IP reveal right. On production, other groups will have the IP reveal right too.)

Steps to create a new checkuser:

Testing basic reveal

Testing multi-reveal

Note: on Patch Demo, everyone has the same IP address. If this user had used several different IP addresses, all would be revealed with one click.

Testing that reveal persists

Note: they stay revealed for 24 hours. This works across pages, and includes if the user makes new edits.

Testing browsing all anonymous contributions from an IP address and/or range

Note: On Patch Demo, you will see all temporary accounts in that view. This is because for privacy reasons, Patch Demo routes all traffic through a single IP address.

Testing Special:Block

Note: on Patch Demo, everyone has the same IP address. If this user had used several different IP addresses, all would be revealed.

Other pages

The IP reveal buttons are shown in most places where a temporary account user link is shown, e.g. diff pages, Special:Log, Special:Contributions/<tempuser>, and more.

Event Timeline

Note that the activity log looks odd on Patch Demo. I'll look into it and file a task if necessary.

Thanks for putting this together @Tchanders!

On Special:Block I have one tiny piece of UI feedback: the spacing between username/IP field and "This is a temporary user using the following IP: 172.16.5.238" message is a bit tight. Adding 4px spacing between field and helper text seems to improve things.

Just tested, all seems to work well.

@sgrabarczuk @Niharika do we want to do anything else for this task?

@sgrabarczuk, @Niharika: Could you please answer the last comment? Thanks in advance!

@kostajh I'm not sure, but I guess we don't. If this is QA-like, and EPIC kindly gave the green light, then we may proceed, and we'd be iterating on the feature if there's more feedback? This is my deduction, and I think the ticket needs Niharika's decision.

@sgrabarczuk would it be valuable to share this task among functionaries? Or perhaps to copy-over the instructions for testing the feature to wiki so we can share it with CUs and admins?

Niharika claimed this task.

Nothing else needed on this task from engineering so I'm marking it as resolved.