Page MenuHomePhabricator
Create Task
Maniphest T369669

Migrate bare division math to parens-division in Less stylesheet files (in web team extensions)
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Note: Per T368921#9981396 we'd like to get this done by mid August.

Background

The MediaWiki core team T368921 is making updates to ResourceLoader to support modern CSS. Work is needed from web team to help them succeed in that goal.

User story

As a developer I want access to modern CSS so I can build products for Wikimedia as easily as possible.

Requirements

  • MobileFrontend has been updated.
  • Minerva has been updated.
  • Vector has been updated.
  • Page previews has been updated.

BDD

  • For QA engineer to fill out === Test Steps
  • For QA engineer to fill out

Design

  • Add mockups and design requirements

Acceptance criteria

  • Add acceptance criteria

Communication criteria - does this need an announcement or discussion?

  • Add communication criteria

Rollback plan

  • What is the rollback plan in production for this task if something goes wrong?

This task was created by Version 1.0.0 of the Web team task template using phabulous

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Migrate bare division math to parens divisionmediawiki/extensions/Popupsmaster+1 -1
Migrate bare division math to parens divisionmediawiki/skins/MinervaNeuemaster+2 -2
Migrate bare division math to parens divisionmediawiki/extensions/MobileFrontendmaster+1 -1
Migrate bare division math to parens divisionmediawiki/skins/Vectormaster+3 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Jul 9 2024, 9:56 PM
Jdlrobson triaged this task as Medium priority.
Jdlrobson mentioned this in T368921: Migrate bare division math to parens-division in Less stylesheet files (in WMF-deployed extensions) .
Jdlrobson added a project: Readers Essential Work.
Jdlrobson moved this task from For triage to Tracking on the Readers Essential Work board.
Jdlrobson raised the priority of this task from Medium to High.Jul 15 2024, 6:13 PM
Jdlrobson edited projects, added: Web-Team-Backlog-Archived (FY2024-25 Q1 Sprint 3); removed: Web-Team-Backlog-Archived.
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from Needs analysis to Ready for estimation on the Web-Team-Backlog-Archived (FY2024-25 Q1 Sprint 3) board.
Jdrewniak set the point value for this task to 2.Jul 22 2024, 5:43 PM
Jdlrobson moved this task from Ready for estimation to Ready for Development on the Web-Team-Backlog-Archived (FY2024-25 Q1 Sprint 3) board.Jul 26 2024, 1:53 AM
bwang claimed this task.Aug 1 2024, 4:08 PM
bwang moved this task from Ready for Development to Doing on the Web-Team-Backlog-Archived (FY2024-25 Q1 Sprint 3) board.
gerritbot added a comment.Aug 1 2024, 6:15 PM

Change #1059138 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Migrate bare division math to parens division

https://gerrit.wikimedia.org/r/1059138

gerritbot added a project: Patch-For-Review.Aug 1 2024, 6:15 PM
gerritbot added a comment.Aug 1 2024, 8:33 PM

Change #1059138 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Migrate bare division math to parens division

https://gerrit.wikimedia.org/r/1059138

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.17; 2024-08-06).Aug 1 2024, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 1 2024, 9:31 PM
gerritbot added a comment.Aug 2 2024, 6:33 PM

Change #1059413 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/MinervaNeue@master] Migrate bare division math to parens division

https://gerrit.wikimedia.org/r/1059413

gerritbot added a project: Patch-For-Review.Aug 2 2024, 6:33 PM

Change #1059414 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/extensions/MobileFrontend@master] Migrate bare division math to parens division

https://gerrit.wikimedia.org/r/1059414

gerritbot added a comment.Aug 2 2024, 9:56 PM

Change #1059414 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Migrate bare division math to parens division

https://gerrit.wikimedia.org/r/1059414

gerritbot added a comment.Aug 2 2024, 9:56 PM

Change #1059413 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Migrate bare division math to parens division

https://gerrit.wikimedia.org/r/1059413

Maintenance_bot removed a project: Patch-For-Review.Aug 2 2024, 10:30 PM
Jdlrobson updated the task description. (Show Details)Aug 2 2024, 11:09 PM
bwang moved this task from Doing to Code Review on the Web-Team-Backlog-Archived (FY2024-25 Q1 Sprint 3) board.Aug 5 2024, 4:15 PM
gerritbot added a comment.Aug 5 2024, 4:17 PM

Change #1059911 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/extensions/Popups@master] Migrate bare division math to parens division

https://gerrit.wikimedia.org/r/1059911

gerritbot added a project: Patch-For-Review.Aug 5 2024, 4:17 PM
bwang removed bwang as the assignee of this task.Aug 5 2024, 4:18 PM
bwang subscribed.
JScherer-WMF assigned this task to bwang.Aug 6 2024, 4:24 PM
JScherer-WMF moved this task from Code Review to Doing on the Web-Team-Backlog-Archived (FY2024-25 Q1 Sprint 3) board.
gerritbot added a comment.Aug 7 2024, 7:13 PM

Change #1059911 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Migrate bare division math to parens division

https://gerrit.wikimedia.org/r/1059911

bwang reassigned this task from bwang to Edtadros.Aug 7 2024, 7:24 PM
bwang moved this task from Doing to QA on the Web-Team-Backlog-Archived (FY2024-25 Q1 Sprint 3) board.
Maintenance_bot removed a project: Patch-For-Review.Aug 7 2024, 7:31 PM
ReleaseTaggerBot edited projects, added: MW-1.43-notes (1.43.0-wmf.18; 2024-08-13); removed: MW-1.43-notes (1.43.0-wmf.17; 2024-08-06).Aug 7 2024, 8:00 PM
Edtadros removed Edtadros as the assignee of this task.Aug 10 2024, 6:02 PM
Edtadros subscribed.

@Jdlrobson, if this is verifiable by QA, please add some more information to the requirements or some test steps when it's moved into the next sprint.

Jdlrobson closed this task as Resolved.Aug 12 2024, 12:04 PM
Jdlrobson claimed this task.
Jdlrobson moved this task from QA to Ready for Signoff on the Web-Team-Backlog-Archived (FY2024-25 Q1 Sprint 3) board.
Jdlrobson added a project: Verified.
Jdlrobson reassigned this task from Jdlrobson to Edtadros.Aug 15 2024, 7:09 AM
Jdlrobson moved this task from Ready for Signoff to QA on the Web-Team-Backlog-Archived (FY2024-25 Q1 Sprint 3) board.
Jdlrobson moved this task from QA to Ready for Signoff on the Web-Team-Backlog-Archived (FY2024-25 Q1 Sprint 3) board.
Krinkle subscribed.EditedNov 26 2024, 7:56 PM
From T368921: Migrate bare division math to parens-division in Less stylesheet files (in WMF-deployed extensions)

Codesearch: Bare math slash in Less files.

There are approximately 50 files using the deprecated as of writing.

Based on the search we originally shared, there appear to still be uses of unparenthesised slash division in MobileFrontend and Minerva. For example:

MobileFrontend - resources/mobile.startup/references/ReferencesDrawer.less
	padding: @drawerPadding/2 @drawerPadding @drawerPadding @drawerPadding;
MinervaNeue - minerva.less/minerva.variables.less
@width-search-box: 375/16em;
MinervaNeue - resources/skins.minerva.base.styles/content/toc.less
	@toctitle-vertical-padding: 1.4em / 2;

Are these false positives where the code is already compatible with Less.js v5 and its new default of math=parens-division?

Krinkle reopened this task as Open.Dec 21 2024, 6:07 PM
Krinkle added a comment.Dec 21 2024, 6:21 PM

Are these false positives where the code is already compatible with Less.js v5 and its new default of math=parens-division?

Please confirm if Minerva and MobileFrontend are ready for Less.js v5, and thus it is okay to switch ResourceLoader to math=parens-division.

Jdlrobson closed this task as Resolved.Jan 2 2025, 11:27 PM
Jdlrobson mentioned this in T382931: [REQUEST] Review unparenthesised slash division in MobileFrontend and Minerva and update if necessary.

I opened T382931 to capture the new request. Let me know on that ticket the urgency and I'll make sure to get Olga to prioritize it.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits