Metadata dialog inappropriately displays the sum of the durations
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	DMartin-WMF
	Jul 11 2024, 6:04 AM

Description

As shown in the attached image (which was provided by @GrounderUK in T363908), the Metadata dialog is showing a summary number for Duration, which is the sum of the orchestrator duration and evaluator duration. This is a potential source of confusion. Duration is elapsed time (end-time - start-time), and the duration of the orchestrator always encompasses that of the evaluator.

Desired behavior/Acceptance criteria

When metadata includes both orchestrator and evaluator durations, the best summary number would be the orchestrator duration, which gives the total elapsed time of handling the function call in the back-end services.

(Of course, CPU times are different and it's still appropriate to summarize them by summing.)

Completion checklist

Before closing this task, review one by one the checklist available here: https://www.mediawiki.org/wiki/Abstract_Wikipedia_team/Definition_of_Done#Front-end_Task/Bug_Completion_Checklist

Details

Other Assignee: DSmit-WMF

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Metadata dialog: show correct duration for nestedmetadata	mediawiki/extensions/WikiLambda	master	+3 -6

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		• Sharvaniharan	T383163 [25Q3] Fix High-Priority Paper-cuts
		Resolved		DSmit-WMF	T369788 Metadata dialog inappropriately displays the sum of the durations

Event Timeline

DMartin-WMF created this task.Jul 11 2024, 6:04 AM

DMartin-WMF mentioned this in T363908: Review WikiLambda system’s criteria for updating a function’s implementation list.Jul 11 2024, 6:17 AM

DMartin-WMF renamed this task from Metadata dialog incorrectly displays the sum of the durations to Metadata dialog inappropriately displays the sum of the durations.Jul 11 2024, 2:44 PM

DMartin-WMF updated the task description. (Show Details)

Geno is asking what to put in the summary and suggests the orchestration time directly. That sounds right!

I agree. It seems to me it should always just be the orchestrator time.

In T369788#9977651, @DMartin-WMF wrote:

I agree. It seems to me it should always just be the orchestrator time.

I agree too. Even if we capture pre-orchestration and post-orchestration latency in a true end-to-end elapsed time, I think we would still be more interested in the period from the start of orchestration to its end.

Jdforrester-WMF triaged this task as Low priority.Jul 17 2024, 4:39 PM

Jdforrester-WMF moved this task from To Triage to Backlog on the Abstract Wikipedia team board.

Jdforrester-WMF raised the priority of this task from Low to Medium.Dec 11 2024, 8:28 PM

Jdforrester-WMF moved this task from Backlog to Engineering Backlog on the Abstract Wikipedia team board.

Jdforrester-WMF added a parent task: T383163: [25Q3] Fix High-Priority Paper-cuts.Jan 17 2025, 1:50 PM

Jdforrester-WMF moved this task from Engineering Backlog to 25Q3 (Jan–Mar) on the Abstract Wikipedia team board.

Jdforrester-WMF edited projects, added Abstract Wikipedia team (25Q3 (Jan–Mar)); removed Abstract Wikipedia team.

Jdforrester-WMF moved this task from Incoming to Ready, Quarterly Work on the Abstract Wikipedia team (25Q3 (Jan–Mar)) board.

DMartin-WMF added a project: Abstract Wikipedia Fix-It tasks.Jan 17 2025, 10:12 PM

Change #1115468 had a related patch set uploaded (by Daphne Smit; author: Daphne Smit):

[mediawiki/extensions/WikiLambda@master] Metadata dialog: show correct duration for nestedmetadata

https://gerrit.wikimedia.org/r/1115468

gerritbot added a project: Patch-For-Review.Jan 30 2025, 5:50 PM

Jdforrester-WMF assigned this task to DSmit-WMF.Jan 30 2025, 5:52 PM

Jdforrester-WMF moved this task from Ready, Quarterly Work to Ready to deploy on the Abstract Wikipedia team (25Q3 (Jan–Mar)) board.

DSmit-WMF changed the task status from Open to In Progress.Jan 30 2025, 6:01 PM

DSmit-WMF updated Other Assignee, added: DSmit-WMF.

DSmit-WMF moved this task from Ready to deploy to In Code review on the Abstract Wikipedia team (25Q3 (Jan–Mar)) board.

Change #1115468 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Metadata dialog: show correct duration for nestedmetadata

https://gerrit.wikimedia.org/r/1115468

Maintenance_bot removed a project: Patch-For-Review.Jan 30 2025, 6:31 PM

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.15; 2025-02-04).Jan 30 2025, 7:00 PM

DSantamaria added a project: Wikifunctions Paper-cuts.Jan 31 2025, 1:19 PM

Jdforrester-WMF moved this task from In Code review to Ready to deploy on the Abstract Wikipedia team (25Q3 (Jan–Mar)) board.Feb 3 2025, 4:36 PM

This was deployed last week (sorry, missed it). On to @Sharvaniharan for sign-off.

Lgtm! I feel it would be clearer to show it visually that the orchestration time includes the evaluation time, but will open a new task for it.

• Sharvaniharan closed this task as Resolved.Feb 14 2025, 5:23 PM

DSantamaria removed a project: Wikifunctions Paper-cuts.Fri, Mar 27, 9:18 AM

Maintenance_bot edited projects, added Abstract Wikipedia team; removed Abstract Wikipedia team (25Q3 (Jan–Mar)).Fri, Mar 27, 9:30 AM

Metadata dialog inappropriately displays the sum of the durationsClosed, ResolvedPublicActions