Page MenuHomePhabricator
Create Task
Maniphest T369822

Implement Integration Test Cases
Open, Needs TriagePublic
Actions

Description

Many extensions that are widely used are still lagging concerning the Integration Test cases, Page Forms is one of them with a test coverage less than 10% among other extensions with even less, considering that this is an extension which is widely used today, it only makes sense to drive the implementation of integration tests to a certain level that will be a little convenient for the extension and later on other such extensions.

Goal:

  • The aim is to drive the development of integration tests in this extension to a point (why not 100%).

Details

Related Changes in Gerrit:
Show related patches Customize query in gerrit

Event Timeline

Collins created this task.Jul 11 2024, 1:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 11 2024, 1:38 PM
Collins updated the task description. (Show Details)Jul 11 2024, 1:41 PM
Aklapper renamed this task from Implementation of Integration Test Cases. to Implement Integration Test Cases.Jul 11 2024, 1:46 PM
Aklapper added a project: Test-Coverage.
Yaron_Koren subscribed.Jul 11 2024, 2:00 PM

I agree - it would be great to have more tests for Page Forms.

Collins claimed this task.Oct 9 2024, 2:14 PM
gerritbot added a comment.Mar 4 2025, 11:16 AM

Change #1124390 had a related patch set uploaded (by Wandji collins; author: Wandji collins):

[mediawiki/extensions/PageForms@master] T369822: Added more integration tests for PF FormPrinter file.

https://gerrit.wikimedia.org/r/1124390

gerritbot added a project: Patch-For-Review.Mar 4 2025, 11:16 AM
gerritbot added a comment.Mar 11 2025, 4:20 PM

Change #1124390 had a related patch set uploaded (by Yaron Koren; author: Wandji collins):

[mediawiki/extensions/PageForms@master] Added more integration tests for PF FormPrinter file

https://gerrit.wikimedia.org/r/1124390

gerritbot added a comment.Sep 5 2025, 8:13 PM

Change #1124390 merged by jenkins-bot:

[mediawiki/extensions/PageForms@master] Added more integration tests for PF FormPrinter file

https://gerrit.wikimedia.org/r/1124390

Yaron_Koren added a comment.Sep 5 2025, 8:29 PM

@Collins - thank you for creating these additional tests! It's unfortunate that it took so long to get this patch in, but that's alright. Getting this patch through validation led to some bug fixes/improvements in the Page Forms code, so it has already been helpful.

gerritbot added a comment.Feb 25 2026, 12:06 AM

Change #1243273 had a related patch set uploaded (by Wandji collins; author: Wandji collins):

[mediawiki/extensions/PageForms@master] feature: Adding Integreations tests for PF_Form file, which is the main entry point for PageForm ext.

https://gerrit.wikimedia.org/r/1243273

gerritbot added a comment.Feb 25 2026, 3:05 PM

Change #1243849 had a related patch set uploaded (by Wandji collins; author: Wandji collins):

[mediawiki/extensions/PageForms@master] Adding integration test cases for more functions in PF FormPrinter

https://gerrit.wikimedia.org/r/1243849

gerritbot added a comment.Feb 25 2026, 5:59 PM

Change #1243273 merged by jenkins-bot:

[mediawiki/extensions/PageForms@master] Add integration tests for PF_Form and PF_FormPrinter files

https://gerrit.wikimedia.org/r/1243273

gerritbot added a comment.Feb 25 2026, 6:06 PM

Change #1243849 merged by jenkins-bot:

[mediawiki/extensions/PageForms@master] Adding integration test cases for more functions in PF FormPrinter

https://gerrit.wikimedia.org/r/1243849

gerritbot added a comment.Feb 26 2026, 5:54 AM

Change #1244385 had a related patch set uploaded (by Wandji collins; author: Wandji collins):

[mediawiki/extensions/PageForms@master] Adding test cases to PF FormPrint

https://gerrit.wikimedia.org/r/1244385

gerritbot added a comment.Feb 26 2026, 6:17 PM

Change #1244385 merged by jenkins-bot:

[mediawiki/extensions/PageForms@master] Adding test cases to PF FormPrinter

https://gerrit.wikimedia.org/r/1244385

gerritbot added a comment.Feb 27 2026, 1:38 AM

Change #1244982 had a related patch set uploaded (by Wandji collins; author: Wandji collins):

[mediawiki/extensions/PageForms@master] Add test cases for PF Form, PF FormPrinter, PFFormLinker, and PFDateInputeWidget.

https://gerrit.wikimedia.org/r/1244982

gerritbot added a comment.Feb 27 2026, 6:35 AM

Change #1244982 merged by jenkins-bot:

[mediawiki/extensions/PageForms@master] Add tests for PFForm, PFFormPrinter, PFFormLinker, PFDateInputWidget

https://gerrit.wikimedia.org/r/1244982

gerritbot added a comment.Feb 28 2026, 1:31 PM

Change #1245972 had a related patch set uploaded (by Wandji collins; author: Wandji collins):

[mediawiki/extensions/PageForms@master] Testing PFFormLinker, PFFormPrinter, PFMappingUtils, and PFDateInputWidget.

https://gerrit.wikimedia.org/r/1245972

gerritbot added a comment.Mar 2 2026, 3:31 PM

Change #1245972 merged by jenkins-bot:

[mediawiki/extensions/PageForms@master] Add tests for four classes

https://gerrit.wikimedia.org/r/1245972

gerritbot added a comment.Mar 4 2026, 2:52 PM

Change #1248020 had a related patch set uploaded (by Wandji collins; author: Wandji collins):

[mediawiki/extensions/PageForms@master] Add test cases to three classes

https://gerrit.wikimedia.org/r/1248020

gerritbot added a comment.Mar 4 2026, 4:20 PM

Change #1248020 merged by jenkins-bot:

[mediawiki/extensions/PageForms@master] Add test cases to three classes

https://gerrit.wikimedia.org/r/1248020

gerritbot added a comment.Mar 5 2026, 1:55 AM

Change #1248164 had a related patch set uploaded (by Wandji collins; author: Wandji collins):

[mediawiki/extensions/PageForms@master] Add test cases for PFValuesUtils and PFFormUtils

https://gerrit.wikimedia.org/r/1248164

gerritbot added a comment.Mar 9 2026, 10:06 PM

Change #1248164 merged by jenkins-bot:

[mediawiki/extensions/PageForms@master] Add test cases for PFValuesUtils and PFFormUtils

https://gerrit.wikimedia.org/r/1248164

gerritbot added a comment.Tue, Mar 17, 3:28 PM

Change #1254229 had a related patch set uploaded (by Wandji collins; author: Wandji collins):

[mediawiki/extensions/PageForms@master] Adding integration test to three classes

https://gerrit.wikimedia.org/r/1254229

gerritbot added a comment.Fri, Mar 20, 8:08 PM

Change #1254229 merged by jenkins-bot:

[mediawiki/extensions/PageForms@master] Adding integration test to three classes

https://gerrit.wikimedia.org/r/1254229

gerritbot added a comment.Tue, Mar 24, 4:16 PM

Change #1260022 had a related patch set uploaded (by Wandji collins; author: Wandji collins):

[mediawiki/extensions/PageForms@master] Adding integration test to PFValuesUtils.

https://gerrit.wikimedia.org/r/1260022

gerritbot added a comment.Thu, Mar 26, 5:41 AM

Change #1260022 merged by jenkins-bot:

[mediawiki/extensions/PageForms@master] Adding integration test for PFValuesUtils class.

https://gerrit.wikimedia.org/r/1260022

gerritbot added a comment.Thu, Mar 26, 10:06 AM

Change #1261367 had a related patch set uploaded (by Wandji collins; author: Wandji collins):

[mediawiki/extensions/PageForms@master] Add integration test cases for PFFormUtils class

https://gerrit.wikimedia.org/r/1261367

gerritbot added a comment.Mon, Mar 30, 6:23 PM

Change #1261367 merged by jenkins-bot:

[mediawiki/extensions/PageForms@master] Add integration test cases for PFFormUtils class

https://gerrit.wikimedia.org/r/1261367

gerritbot added a comment.Mon, Mar 30, 11:45 PM

Change #1264810 had a related patch set uploaded (by Wandji collins; author: Wandji collins):

[mediawiki/extensions/PageForms@master] Adding integration test to PFValuesUtils class

https://gerrit.wikimedia.org/r/1264810

gerritbot added a comment.Tue, Mar 31, 2:04 AM

Change #1264810 merged by jenkins-bot:

[mediawiki/extensions/PageForms@master] Adding integration test to PFValuesUtils class

https://gerrit.wikimedia.org/r/1264810

gerritbot added a comment.Thu, Apr 2, 1:43 AM

Change #1266501 had a related patch set uploaded (by Wandji collins; author: Wandji collins):

[mediawiki/extensions/PageForms@master] Add integration test for two classes

https://gerrit.wikimedia.org/r/1266501

gerritbot added a comment.Thu, Apr 2, 8:54 PM

Change #1266501 merged by jenkins-bot:

[mediawiki/extensions/PageForms@master] Add integration test for two classes

https://gerrit.wikimedia.org/r/1266501

gerritbot added a comment.Thu, Apr 2, 11:38 PM

Change #1267279 had a related patch set uploaded (by Wandji collins; author: Wandji collins):

[mediawiki/extensions/PageForms@master] Add integration test for PFHelperFormAction class

https://gerrit.wikimedia.org/r/1267279

gerritbot added a comment.Mon, Apr 6, 6:14 PM

Change #1267279 merged by jenkins-bot:

[mediawiki/extensions/PageForms@master] Add integration test for PFHelperFormAction class

https://gerrit.wikimedia.org/r/1267279

gerritbot added a comment.Wed, Apr 8, 9:37 PM

Change #1269065 had a related patch set uploaded (by Wandji collins; author: Wandji collins):

[mediawiki/extensions/PageForms@master] Add integration test cases for PFMappingUtils

https://gerrit.wikimedia.org/r/1269065

gerritbot added a comment.Fri, Apr 10, 1:15 AM

Change #1269756 had a related patch set uploaded (by Wandji collins; author: Wandji collins):

[mediawiki/extensions/PageForms@master] Add integration test cases for PFUtils class

https://gerrit.wikimedia.org/r/1269756

gerritbot added a comment.Fri, Apr 10, 4:28 AM

Change #1269756 merged by jenkins-bot:

[mediawiki/extensions/PageForms@master] Add integration test cases for PFUtils class

https://gerrit.wikimedia.org/r/1269756

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits