Page MenuHomePhabricator

Edit summaries length should have a countdown for remaining characters
Closed, ResolvedPublic

Description

Edit summaries are currently a maximum of 200 characters. It would be useful for editors to be able to see while they are typing in the edit summary a countdown of the remaining characters.

Ideally, any solution to this would not hardcode the character length (because, see Bug 4715 and Bug 4714 - that might change) but base it on the maxlength attribute in the HTML.


Version: unspecified
Severity: enhancement
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=44827

Details

Reference
bz34984
Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
Refine: Remove diff functionality from refine pipelinerepos/data-engineering/airflow-dags!1615aquT369845_main_refine_remove_diffmain
Refine: optionnaly skip diff per tablerepos/data-engineering/airflow-dags!1594aquT369845_refine_fix_add_skip_diff_listmain
Refine: Fix table locationrepos/data-engineering/airflow-dags!1577aquT369845_refine_fix_table_base_locationmain
analytics-test: Refine remove diffrepos/data-engineering/airflow-dags!1568aquT369845_analytics_test_refine_remove_diffmain
Refine: Bump refinery to 0.2.67repos/data-engineering/airflow-dags!1563aquT369845_refine_bump_refinery_versionmain
Fix UI/UX issues for final releaserepos/wmde/wikidata-query-builder!5haakui-cleanupmaster
analytics-test: Refine - Remove diff with legacy partitionrepos/data-engineering/airflow-dags!1559aquT369845_refine_analytics_test_post_migration_fixesmain
refine_to_hive_hourly: Switch from staging to productionrepos/data-engineering/airflow-dags!1554aquT369845_refine_to_hive_production_switchmain
Refine: update variablesrepos/data-engineering/airflow-dags!1550aquT369845_refine_update_variablesmain
Update SimpleSkeinOperator field to be publicrepos/data-engineering/airflow-dags!1525joalfix_canary_eventsmain
Update main canary_events for smaller XComsrepos/data-engineering/airflow-dags!1517joaleasier_canary_eventsmain
Reduce main gobblin_webrequest resourcesrepos/data-engineering/airflow-dags!1504joalupdate_main_gobblin_resourcesmain
analytics-test: Refine revert change in cmd buildrepos/data-engineering/airflow-dags!1500aquT369845_analytics_test_refine_fix_skein_cmdmain
Fix analytics_test refine_events_hourly jobrepos/data-engineering/airflow-dags!1489joalfix_an_test_refinemain
Update main refine_hourly and canary events poolsrepos/data-engineering/airflow-dags!1486joalmain_refine_poolmain
analytics-test: Refine fixrepos/data-engineering/airflow-dags!1479aquT369845_refine_add_processed_flagmain
analytics-test: Refine add spark scale overriderepos/data-engineering/airflow-dags!1478aquT369845_refine_add_processed_flagmain
analytics-test: Refine parameterize all resources (jar & properties)repos/data-engineering/airflow-dags!1476aquT369845_refine_add_processed_flagmain
airflow-main: Refine add _PROCESSED flagrepos/data-engineering/airflow-dags!1471aquT369845_refine_add_processed_flagmain
airflow-main: Refine add _PROCESSED flagrepos/data-engineering/airflow-dags!1469aquT369845_refine_add_processed_flagmain
Show related patches Customize query in GitLab

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 12:13 AM
bzimport set Reference to bz34984.
bzimport added a subscriber: Unknown Object (MLST).

Usability bonus: the countdown's max value could account for autogenerated text which will be prepended or appended during save (e.g. manual undo, tagging, section title).

This might be solved by closing T6714 and/or T6715, depending on implementation. (Or at least I stared at those a while, plus T18921, before deciding this was a distinct issue and searching further. :>

A gadget is used for this purpose in ruwiki (counter is shown when less than 80 bytes are left, but this can be configured in summaryBytesLeft_margin variable).

This is done in the visual editor and in the wikitext mode of said editor; it's probably not worth trying to shoe-horn it into the 2010 wikitext editor.

Please roll this back. It breaks a basic function. I was unaware this was being considered and this is a perhaps-nice-to-have-gadget but not necessary. If re-implemented it should be an opt-in and not default. In my view this counter is clutter: I would never turn it on.

@Jytdog: Explaining which exact "basic function" is now broken and how would be required. If there are convincing arguments how this counter negatively impacts your workflow and why that impact is big enough that it justifies the additional maintenance costs and resources to long-term maintain some additional opt-in/opt-out code and add even more preferences, I am sure developers would be open to discuss such arguments. "I don't like it" is not an argument though.

Yes I posted here since this appears to be where this was agreed to. Aklapper the problems with this counter are obvious and explained at depth at the phab thread just linked and at VPT.

The implementation of this twitter-like "bell and whistle" broke a basic function. This is obvious. If making it an opt-in "costs" too much than it should not be implemented at all.

If the problem is not explained and if no links are provided (I don't plan to go through the last weeks of "VPT") it's impossible to discuss the same topic. Your choice. :)
But if the "obvious problems" are "explained at depth" in T169982 then there is T169982 to discuss the best way forward. "Revert" is just one of the available options.