Page MenuHomePhabricator
Create Task
Maniphest T369859

Update Special:IPContributions UI messages according to design specification
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To
Dreamy_Jazz
Authored By
Tchanders
Jul 11 2024, 6:04 PM
Tags
Referenced Files
F57471295: image.png
Sep 9 2024, 5:11 PM
F57471324: image.png
Sep 9 2024, 5:11 PM
F57471308: image.png
Sep 9 2024, 5:11 PM
F57288826: 90dayscopy.png
Aug 23 2024, 4:21 PM
F57288863: deletedlegacyip.png
Aug 23 2024, 4:21 PM
F57288829: legacyip.png
Aug 23 2024, 4:21 PM
F56472921: image.png
Jul 17 2024, 3:31 AM
F56472918: image.png
Jul 17 2024, 3:31 AM
View All 17 Files
Subscribers
Aklapper
Amire80
Djackson-ctr
Dreamy_Jazz
• JayCano
JJMC89
KColeman-WMF
View All 12 Subscribers

Description

Overview

Following T367121: Design review and user testing for Special:IPContributions, update some UI messages according to the table in T367121#9962620:

Details

Change the following message translations in en.json:

  • Default page title: "Search for IP contributions" (checkuser-ip-contributions)
  • Inline error message: "Enter a valid IP address or IP range" (checkuser-ip-contributions-target-error-no-ip)

Customize the following messages currently defined in the parent classes:

  • Accordion form title: "Search for IP contributions" (to replace sp-contributions-search)
  • IP search results title: "Temporary user IP contributions for 172.16.5.238" (to replace contributions-title)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Indicate IP contributions are legacy when temporary accounts enabledmediawiki/coremaster+137 -52
Remove now unneeded default value in SpecialIPContributions methodmediawiki/extensions/CheckUsermaster+1 -1
Improve checkuser-ip-contributions-subtitle message for translatorsmediawiki/extensions/CheckUsermaster+5 -4
Update signature of SpecialIPContributions methodmediawiki/extensions/CheckUsermaster+2 -1
Add "showing results from last 90 days" to Special:IPContributionsmediawiki/extensions/CheckUsermaster+14 -0
ContributionsSpecialPage: Allow some messages to be customizablemediawiki/coremaster+16 -2
Customize some messages on Special:IPContributionsmediawiki/extensions/CheckUsermaster+18 -0
Update Special:IPContributions UI messages according to design specmediawiki/extensions/CheckUsermaster+2 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Tchanders created this task.Jul 11 2024, 6:04 PM
Tchanders updated the task description. (Show Details)Jul 12 2024, 6:50 PM
gerritbot added a comment.Jul 12 2024, 6:57 PM

Change #1053976 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CheckUser@master] Update Special:IPContributions UI messages according to design spec

https://gerrit.wikimedia.org/r/1053976

gerritbot added a project: Patch-For-Review.Jul 12 2024, 6:57 PM
kostajh assigned this task to Tchanders.Jul 12 2024, 7:18 PM
gerritbot added a comment.Jul 12 2024, 7:45 PM

Change #1053976 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Update Special:IPContributions UI messages according to design spec

https://gerrit.wikimedia.org/r/1053976

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.14; 2024-07-16).Jul 12 2024, 8:00 PM
Tchanders edited projects, added Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)); removed Trust and Safety Product Sprint (Sprint Cajon (Jun 24 - July 5)).Jul 15 2024, 10:58 AM
Tchanders moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)) board.
Tchanders updated the task description. (Show Details)Jul 16 2024, 12:32 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 16 2024, 1:30 PM
gerritbot added a comment.Jul 16 2024, 1:56 PM

Change #1054567 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/core@master] ContributionsSpecialPage: Allow some messages to be customizable

https://gerrit.wikimedia.org/r/1054567

gerritbot added a project: Patch-For-Review.Jul 16 2024, 1:56 PM

Change #1054568 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CheckUser@master] Customize some messages on Special:IPContributions

https://gerrit.wikimedia.org/r/1054568

gerritbot added a comment.Jul 16 2024, 8:41 PM

Change #1054567 merged by jenkins-bot:

[mediawiki/core@master] ContributionsSpecialPage: Allow some messages to be customizable

https://gerrit.wikimedia.org/r/1054567

gerritbot added a comment.Jul 16 2024, 8:42 PM

Change #1054568 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Customize some messages on Special:IPContributions

https://gerrit.wikimedia.org/r/1054568

Dreamy_Jazz updated the task description. (Show Details)Jul 16 2024, 8:54 PM

@Tchanders is there anything else left to do in this task (considering it is still in 'In Progress')? If not, can we move it to 'Needs QA'?

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.15; 2024-07-23); removed MW-1.43-notes (1.43.0-wmf.14; 2024-07-16).Jul 16 2024, 9:00 PM
Tchanders moved this task from In Progress to Needs QA on the Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)) board.Jul 16 2024, 9:19 PM

@Dreamy_Jazz It should've been in review - moved to QA.

Maintenance_bot removed a project: Patch-For-Review.Jul 16 2024, 9:30 PM
Dreamy_Jazz added a comment.Jul 16 2024, 9:54 PM
In T369859#9988156, @Tchanders wrote:

@Dreamy_Jazz It should've been in review - moved to QA.

Thanks.

Djackson-ctr moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)) board.Jul 17 2024, 3:31 AM
Djackson-ctr subscribed.

I have verified the new code has been implemented and is functioning and displaying as expected.

image.png (811×1 px, 252 KB)

image.png (846×1 px, 385 KB)

image.png (739×994 px, 45 KB)

image.png (748×996 px, 48 KB)

image.png (734×990 px, 45 KB)

image.png (779×987 px, 49 KB)

image.png (859×490 px, 182 KB)

image.png (868×488 px, 221 KB)

image.png (853×450 px, 207 KB)

image.png (851×585 px, 227 KB)

image.png (874×609 px, 186 KB)

Tchanders closed this task as Resolved.Jul 17 2024, 4:45 AM
Tchanders reopened this task as Open.Jul 24 2024, 1:39 PM
Tchanders moved this task from Done to Needs Design Review on the Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)) board.
Tchanders moved this task from Needs Design Review to Done on the Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)) board.
Tchanders moved this task from Done to Needs Design Review on the Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)) board.
Tchanders added a subscriber: • JayCano.Jul 24 2024, 1:41 PM

Opening this back up for design review.

@KColeman-WMF It should be testable on testwiki once you get the rights. (Cc @JayCano, who is handling this.)

Tchanders edited projects, added Trust and Safety Product Sprint (Sprint Erhu (August 5th - August 16th)); removed Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)).Aug 5 2024, 9:34 AM
Tchanders moved this task from Priority Backlog to Needs Design Review on the Trust and Safety Product Sprint (Sprint Erhu (August 5th - August 16th)) board.
KColeman-WMF added a comment.Aug 23 2024, 3:15 PM

I have checked this on test wiki and can confirm copy changes are updated.

KColeman-WMF closed this task as Resolved.Aug 23 2024, 3:16 PM
KColeman-WMF moved this task from Needs Design Review to Done on the Trust and Safety Product Sprint (Sprint Erhu (August 5th - August 16th)) board.
KColeman-WMF moved this task from Done to Needs Design Review on the Trust and Safety Product Sprint (Sprint Erhu (August 5th - August 16th)) board.Aug 23 2024, 3:56 PM
KColeman-WMF reopened this task as Open.Aug 23 2024, 4:21 PM

Opening this up again as I spotted some small copy changes that are missing. As per https://phabricator.wikimedia.org/T367121#9962620:

PageComponentUX copyMockup
Special:ContributionsIP search results titleLegacy IP contributions for 172.16.5.238
legacyip.png (422×1 px, 82 KB)
Special:DeletedContributionsIP search results titleDeleted legacy IP contributions for 172.16.5.238
deletedlegacyip.png (415×1 px, 79 KB)
Special:IPContributionsSearch results descriptionShowing results from the last 90 days.
90dayscopy.png (440×1 px, 91 KB)
KColeman-WMF edited projects, added Trust and Safety Product Sprint (Sprint Theremin (Aug 26 - Sept. 6)); removed Trust and Safety Product Sprint (Sprint Erhu (August 5th - August 16th)).Aug 23 2024, 4:21 PM
kostajh edited projects, added Temporary accounts; removed Temporary accounts (Blockers to testwiki deployment).Aug 26 2024, 10:15 AM
• JayCano removed Tchanders as the assignee of this task.Aug 26 2024, 10:27 AM
• JayCano set the point value for this task to 1.
Dreamy_Jazz claimed this task.Aug 30 2024, 12:33 PM
Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Theremin (Aug 26 - Sept. 6)) board.
gerritbot added a comment.Aug 30 2024, 1:02 PM

Change #1069177 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Add "showing results from last 90 days" to Special:IPContributions

https://gerrit.wikimedia.org/r/1069177

gerritbot added a project: Patch-For-Review.Aug 30 2024, 1:02 PM
gerritbot added a comment.Aug 30 2024, 1:58 PM

Change #1069212 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Indicate IP contributions are legacy when temporary accounts enabled

https://gerrit.wikimedia.org/r/1069212

gerritbot added a comment.Aug 30 2024, 2:00 PM

Change #1069177 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Add "showing results from last 90 days" to Special:IPContributions

https://gerrit.wikimedia.org/r/1069177

gerritbot added a comment.Aug 30 2024, 2:00 PM

Change #1069213 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Update signature of SpecialIPContributions::getResultsPageTitleMessageKey

https://gerrit.wikimedia.org/r/1069213

gerritbot added a comment.Aug 30 2024, 2:16 PM

Change #1069216 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Remove now un-needed default value in SpecialIPContributions method

https://gerrit.wikimedia.org/r/1069216

Dreamy_Jazz moved this task from In Progress to Needs review on the Trust and Safety Product Sprint (Sprint Theremin (Aug 26 - Sept. 6)) board.Aug 30 2024, 2:19 PM
ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.21; 2024-09-03); removed MW-1.43-notes (1.43.0-wmf.15; 2024-07-23).Aug 30 2024, 3:00 PM
gerritbot added a comment.Aug 30 2024, 3:42 PM

Change #1069213 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Update signature of SpecialIPContributions method

https://gerrit.wikimedia.org/r/1069213

Amire80 subscribed.EditedSep 1 2024, 4:59 AM

This adds the message checkuser-ip-contributions-subtitle: "Showing results from the last $1."

$1 is documented as "formatted representation of the maximum age that revisions can be to be shown on the page".

Can anyone provide more details? Is it in seconds, days, or something else? The word "last" has to be translated differently according to the context in many languages.

If this is used with durationParams(), which eventually uses duration-seconds or duration-days, then it cannot be conveniently to many languages at all. Those messages may be OK as standalone time descriptions, but they are not very good at being integrated into sentences. Consider changing it to something like "Showing results from the last {{PLURAL:$1|day|$1 days}}."

JJMC89 subscribed.Sep 1 2024, 5:33 AM

By default it is 90 days. Depending on the value of $wgCUDMaxAge the interval could be something other than days though.

Maybe it should be updated to have the duration always be in days like checkuser-tempaccount-no-ip-results.

Dreamy_Jazz added a comment.Sep 2 2024, 1:48 PM

I can update checkuser-ip-contributions-subtitle to only ever display days.

gerritbot added a comment.Sep 2 2024, 1:58 PM

Change #1070033 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Improve checkuser-ip-contributions-subtitle message for translators

https://gerrit.wikimedia.org/r/1070033

kostajh moved this task from Needs review to Needs QA on the Trust and Safety Product Sprint (Sprint Theremin (Aug 26 - Sept. 6)) board.Sep 2 2024, 2:08 PM
gerritbot added a comment.Sep 2 2024, 2:35 PM

Change #1070033 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Improve checkuser-ip-contributions-subtitle message for translators

https://gerrit.wikimedia.org/r/1070033

gerritbot added a comment.Sep 3 2024, 11:23 PM

Change #1069212 merged by jenkins-bot:

[mediawiki/core@master] Indicate IP contributions are legacy when temporary accounts enabled

https://gerrit.wikimedia.org/r/1069212

gerritbot added a comment.Sep 3 2024, 11:23 PM

Change #1069216 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Remove now unneeded default value in SpecialIPContributions method

https://gerrit.wikimedia.org/r/1069216

Maintenance_bot removed a project: Patch-For-Review.Sep 3 2024, 11:30 PM
ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.22; 2024-09-10); removed MW-1.43-notes (1.43.0-wmf.21; 2024-09-03).Sep 4 2024, 12:00 AM
Dreamy_Jazz moved this task from Needs QA to Ready on the Trust and Safety Product Sprint (Sprint Theremin (Aug 26 - Sept. 6)) board.Sep 4 2024, 6:43 AM
Dreamy_Jazz moved this task from Ready to Needs QA on the Trust and Safety Product Sprint (Sprint Theremin (Aug 26 - Sept. 6)) board.
Dreamy_Jazz mentioned this in T374265: Update subtitle text for Contribution special pages to use "Results for 1.2.3.4" instead of "For 1.2.3.4".Sep 6 2024, 4:20 PM
Djackson-ctr moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Theremin (Aug 26 - Sept. 6)) board.Sep 9 2024, 5:11 PM

QA has been completed and the new design copy changes have been implemented:
(NOTE: the positioning of the Temporary User IP Edits button and Legacy IP Edits button will be addressed in a different ticket: T369930).

Legacy IP contributions for 172.16.5.238:

image.png (243×1 px, 121 KB)

Deleted legacy IP contributions for 172.16.5.238:

image.png (231×1 px, 151 KB)

Showing results from the last 90 days:

image.png (338×1 px, 193 KB)

kostajh closed this task as Resolved.Sep 9 2024, 5:23 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits