Page MenuHomePhabricator

SpecialNotifications - accessibility issues
Open, Needs TriagePublic

Description

Checked with axe DevTools - the following issues were reported as Critical or Serious.

Contrast issues
Element Location:.mw-echo-ui-crossWikiUnreadFilterWidget-subtitle<label class="mw-echo-ui-crossWikiUnreadFilterWidget-subtitle oo-ui-widget oo-ui-widget-enabled oo-ui-labelElement oo-ui-labelElement-labeloo-ui-labelWidget">Pages with unread notifications</label>
Screen Shot 2024-07-11 at 12.31.21 PM.png (2,218×604 px, 164 KB)

Note: "Images must have alternate text"(see an example below) is reported as a Critical issue with axe DevTools, is most likely a false positive since the images are only decorative (see the explanation in https://phabricator.wikimedia.org/T281717#7053678 and in https://phabricator.wikimedia.org/T369870#9975265)

Element Location:.mw-echo-ui-datedSubGroupListWidget.mw-echo-ui-subGroupListWidget.oo-ui-widget-enabled:nth-child(1) > .mw-echo-ui sortedListWidget.oo-ui-widget-enabled.oo-ui-widget > .mw-echo-ui-sortedListWidget-group > .mw-echo-ui-notificationItemWidget:nth-child(1) > .mw-echo-ui-notificationItemWidget-icon > img[role="presentation"][alt=" "] <img src="/w/extensions/Echo/modules/icons/edit-user-talk-progressive.svg" role="presentation" alt=" ">
Screen Shot 2024-07-11 at 1.58.13 PM.png (2,360×1,384 px, 432 KB)

Event Timeline

Probably the contrast issue(s) should be added to T368893: Fix Echo color contrast issues in standard theme & night mode (pt 2) and this task should be only about the missing alt text. Which actually shouldn't have alt text at all and should be set to "" rather than " ". This is a clearly decorative image, so in fact it must not have alt text. Curious that it got reported.

Curious that it got reported.

I guess because both of the divs that make up an entity are inside an a? (The meaningful text block itself contains an a also... I think I've talked with someone about that somewhere.) Either way I think this one is approximately a false positive and/or should have the space removed, but there is no other meaningful change to be made here.

Thanks, @Izno - yes, since "mw-echo-ui-notificationItemWidget-content-message-body" is the same element as in the Echo overlay, this issue can be added to .

In light mode the element also has a contrast issue when displayed on the grey background in the Echo overlay.

Also, agree with that images being decorative probably would not need alt text (also, there was a clarification on it - https://phabricator.wikimedia.org/T281717#7053678). I'll move the issue with "mw-echo-ui-notificationItemWidget-content-message-body" to T368893. I add comment on this task that alt text is not needed. And only issue to fix on Special:Notifications will be the issue with "mw-echo-ui-crossWikiUnreadFilterWidget-subtitle.

Etonkovidova renamed this task from SpecialNotifications - accesibility issues to SpecialNotifications - accessibility issues.Jul 16 2024, 12:11 AM