Are you sure? I see an icon for it...

Ditto Brion. Share has no icon

Created attachment 10215
Image of git head, no icon for share

Uploaded directly from my phone!

Attached:

(In reply to comment #1)

Are you sure? I see an icon for it...

Got some uncommited/unpushed changes Yuvi? ;)

Nope, been committed for a while https://github.com/wikimedia/WikipediaMobile/commit/481e00cd0e33663501946f43f0a95c79c58a1527

This is very interesting/weird...

This is on ICS 4.0.2 on my Galaxy Nexus. I guess Brion is aswell...

It is ok on my Motorola Xoom on 4.0.3 though...

I can try on my Desire HD on 2.3 when my brother gets back later

There's no xhdpi image, which explains why it's missing on Galaxy Nexus but not on lower-density devices.

(In reply to comment #7)

There's no xhdpi image, which explains why it's missing on Galaxy Nexus but not
on lower-density devices.

This would be easily fixed if we had the one that is supposed to be in orig.

If it was there, ./share.sh, add, commit...

I took the share icon from android default icons - am so far unable to find the xhdpi version though. Ugh

xhdpi seems to be new in android 4 so there may not be a default image for that menu style, depending on how cleverly they made their default-icon assets. :P

Worst case just scale the hdpi one up and it'll be a smidge blurry.

I'll poke heather when she's back and see if she can make us one. Will also try finding this exact icon again

There *is* a share icon available at all dpis, but it looks quite different than the one we're using.

Here is the ldpi version https://github.com/wikimedia/WikipediaMobile/blob/master/assets/www/img/ldpi/optionSharePage.png

Actually yuvi already checked in a scaled up copy https://github.com/wikimedia/WikipediaMobile/blob/master/assets/www/img/xhdpi/optionSharePage.png. Resolving