Page MenuHomePhabricator

Fundraising - Send isoCountryCode to submitPayment endpoint
Closed, ResolvedPublic

Description

Instead of sending CNPostalAddress.country to the `donor_country" parameter for the submitPayment endpoint, we should send CNPostalAddress.isoCountryCode.

QA Notes

Just regression testing - confirm Apple Pay payments continue to go through.

Event Timeline

Thank you for tagging this task with good first task for Wikimedia newcomers!

Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.

A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly pointed to the codebase URL and provide clear steps to help a contributor get setup for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !

Thank you for helping us drive new contributions to our projects <3

Change #1054665 had a related patch set uploaded (by Seawolf35gerrit; author: Seawolf35gerrit):

[mediawiki/extensions/DonationInterface@master] Fundraising:Send isoCountryCode to submitPayment endpoint

https://gerrit.wikimedia.org/r/1054665

Change #1054665 abandoned by Seawolf35gerrit:

[mediawiki/extensions/DonationInterface@master] Fundraising:Send isoCountryCode to submitPayment endpoint

https://gerrit.wikimedia.org/r/1054665

Seawolf35 subscribed.

Hi @Tsevener
May I ask you to review the PR please?

@Viktor.dev sorry for the delay - we have been busy on a different feature lately. We will code review (and likely merge) this next week. Thank you for your contribution. This will help with our upcoming campaigns.

Tsevener added a subscriber: Viktor.dev.
Mazevedo subscribed.

Can be retested in 7.5.9 (4067) - per notes in the ticket, this only needs a regression test to ensure it still works