Page MenuHomePhabricator

Missing function stored as empty string
Open, Needs TriagePublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:
The "element equality function" argument gets stored as an empty string ""

What should have happened instead?:
We shouldn't have published that, but raised an error that the argument is missing / has the wrong type.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
Could probably be caught with better validation / type checking.

Geno's comments: This is an issue, the field requires a referenced function, but there's no validation before submitting, so the empty reference "Z889K3":{"Z1K1": "Z9", "Z9K1": ""} when canonicalized is transformed into "Z889K3":"" , which then is interpreted as a string.