Page MenuHomePhabricator
Create Task
Maniphest T369930

Update navigation between Special:Contributions and Special:IPContributions
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To
kostajh
Authored By
Tchanders
Jul 12 2024, 6:49 PM
Tags
Referenced Files
F57408356: image.png
Sep 2 2024, 4:05 PM
F57408293: image.png
Sep 2 2024, 4:05 PM
F57408168: image.png
Sep 2 2024, 4:05 PM
F57288882: toggleonright.png
Aug 23 2024, 4:35 PM
F56595628: ipcontributions_invalidip_search.png
Jul 22 2024, 12:25 PM
F56595594: ipcontributions_invalidip.png
Jul 22 2024, 12:25 PM
F56595570: deletedcontributions.png
Jul 22 2024, 12:25 PM
F56595567: ipcontributions_isArchived.png
Jul 22 2024, 12:25 PM
View All 10 Files
Subscribers
Aklapper
dom_walden
Dreamy_Jazz
KColeman-WMF
kostajh
Madalina
Niharika
View All 10 Subscribers

Description

Overview

Following feedback from users and a design review, update the navigation between Special:Contributions and Special:IPContributions to make it easier for the user to:

  • understand which page they are on
  • understand what the different pages do
  • understand how to get to other related pages
Details

The details, including screenshots, a table of UI messages, and figma links, are in this comment: T367121#9962620.

Scope

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Show the temp IP toggle buttons on Special:DeletedContributionsmediawiki/extensions/CheckUsermaster+20 -10
Add error banner to Special:IPContributions for invalid targetmediawiki/extensions/CheckUsermaster+34 -0
SpecialIPContributions: Improve navigation between modesmediawiki/extensions/CheckUsermaster+211 -84
Add button to indicate mode on Contributions pagesmediawiki/extensions/CheckUsermaster+80 -137
Customize query in gerrit

Related Objects
Search...

Event Timeline

Tchanders created this task.Jul 12 2024, 6:49 PM
Tchanders updated the task description. (Show Details)Jul 13 2024, 5:34 AM
Tchanders moved this task from Priority Backlog to Ready on the Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)) board.Jul 15 2024, 11:00 AM
Tchanders updated the task description. (Show Details)Jul 18 2024, 12:46 PM
Tchanders claimed this task.Jul 18 2024, 1:02 PM
Tchanders moved this task from Ready to In Progress on the Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)) board.
gerritbot added a comment.Jul 18 2024, 3:01 PM

Change #1055247 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CheckUser@master] Add button to indicate mode on Contributions pages

https://gerrit.wikimedia.org/r/1055247

gerritbot added a project: Patch-For-Review.Jul 18 2024, 3:01 PM
gerritbot added a comment.Jul 18 2024, 5:06 PM

Change #1055260 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CheckUser@master] WIP SpecialIPContributions: Improve navigation between modes

https://gerrit.wikimedia.org/r/1055260

gerritbot added a comment.Jul 18 2024, 5:56 PM

Change #1055247 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Add button to indicate mode on Contributions pages

https://gerrit.wikimedia.org/r/1055247

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.15; 2024-07-23).Jul 18 2024, 6:00 PM
gerritbot added a comment.Jul 18 2024, 8:08 PM

Change #1055288 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CheckUser@master] WIP Add error banner to Special:IPContributions for invalid target

https://gerrit.wikimedia.org/r/1055288

Dreamy_Jazz mentioned this in T369861: Update Special:IPContributions mobile UX copy.Jul 18 2024, 8:47 PM
Tchanders moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)) board.Jul 19 2024, 8:46 AM
Tchanders updated the task description. (Show Details)Jul 19 2024, 10:36 AM
Tchanders mentioned this in T370438: Improve feature parity between Special:Contributions and Special:DeletedContributions.
gerritbot added a comment.Jul 19 2024, 11:15 AM

Change #1055260 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] SpecialIPContributions: Improve navigation between modes

https://gerrit.wikimedia.org/r/1055260

gerritbot added a comment.Jul 19 2024, 4:44 PM

Change #1055288 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Add error banner to Special:IPContributions for invalid target

https://gerrit.wikimedia.org/r/1055288

Maintenance_bot removed a project: Patch-For-Review.Jul 19 2024, 5:30 PM
Tchanders moved this task from Needs Review to Needs QA on the Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)) board.Jul 19 2024, 8:46 PM
Tchanders edited projects, added Temporary accounts (Blockers to minor pilot wiki deployment); removed Temporary accounts (Blockers to testwiki deployment).Jul 21 2024, 9:13 PM
dom_walden moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)) board.Jul 22 2024, 12:25 PM
dom_walden subscribed.

The transitions for the toggle buttons and "deleted user contributions"/"contributions" link go:

Temporary userToggle buttonsLegacy
Active
ipcontributions.png (440×982 px, 73 KB)
<->
contributions.png (482×970 px, 56 KB)
"(deleted user) contributions" link↕↕
Deleted
ipcontributions_isArchived.png (426×992 px, 45 KB)
->
deletedcontributions.png (579×986 px, 46 KB)

Note that going from Special:IPContributions/<ip>&isArchive=1 and clicking "Legacy IP edits" takes you to Special:DeletedContributions, which does not have a toggle.

  • Fix error message banner

Invalid IP passed to Special:IPContributions:

ipcontributions_invalidip.png (799×989 px, 57 KB)

After making a search:
ipcontributions_invalidip_search.png (861×988 px, 76 KB)

The link in the error message goes to Special:Contributions/<target>.

  • Make deleted contributions a link instead of a tab

Yep.

Tchanders closed this task as Resolved.Jul 22 2024, 3:17 PM

Note that going from Special:IPContributions/<ip>&isArchive=1 and clicking "Legacy IP edits" takes you to Special:DeletedContributions, which does not have a toggle.

Thanks for pointing this out - it will be fixed via T370438: Improve feature parity between Special:Contributions and Special:DeletedContributions.

Tchanders reopened this task as Open.Jul 24 2024, 1:44 PM
Tchanders moved this task from Done to Needs Design Review on the Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)) board.
Tchanders edited projects, added Trust and Safety Product Sprint (Sprint Erhu (August 5th - August 16th)); removed Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)).Aug 5 2024, 9:33 AM
Tchanders moved this task from Priority Backlog to Needs Design Review on the Trust and Safety Product Sprint (Sprint Erhu (August 5th - August 16th)) board.
KColeman-WMF added a comment.Aug 23 2024, 4:35 PM

Overall looks good! However two things appear outstanding:

  1. Toggle button is still missing on Special:DeletedContributions?
  2. In the Desktop design the ToggleButton is aligned on the right rather than stacked underneath (it only stacks on mobile) - the reason for this is to bring the information up the page and make the most of available desktop space. Is this something we can do?

Desktop Toggle button aligned right:

toggleonright.png (437×1 px, 92 KB)

KColeman-WMF edited projects, added Trust and Safety Product Sprint (Sprint Theremin (Aug 26 - Sept. 6)); removed Trust and Safety Product Sprint (Sprint Erhu (August 5th - August 16th)).Aug 23 2024, 4:36 PM
• JayCano removed Tchanders as the assignee of this task.Aug 26 2024, 10:26 AM
• JayCano set the point value for this task to 1.
Dreamy_Jazz added a comment.EditedSep 2 2024, 4:05 PM
In T369930#10088404, @KColeman-WMF wrote:
  1. In the Desktop design the ToggleButton is aligned on the right rather than stacked underneath (it only stacks on mobile) - the reason for this is to bring the information up the page and make the most of available desktop space. Is this something we can do?

Consider the following from testwiki:

image.png (186×976 px, 18 KB)

If the buttons are moved to the right, then this is what it looks like:

image.png (192×966 px, 21 KB)

Forcing the user links to be on the same line makes it look like:

image.png (179×971 px, 20 KB)

By putting the buttons on the right of the screen, we could make the user tool links overflow into three lines. Want to check if this is okay.

Dreamy_Jazz claimed this task.Sep 2 2024, 4:19 PM
KColeman-WMF added a comment.Sep 2 2024, 6:07 PM

Thanks @Dreamy_Jazz! When I was testing 'worst case' scenarios for user links in the desktop design it didn't run over more than two lines, however this likely won't be the case on smaller screens. In my view we should be maximising desktop real estate where possible.

Another reason I proposed that we float the buttons right is because I had GUC in mind, which will eventually have pagination that's similar to new Codex table pagination (and a toggle button to toggle between table and list views). If the toggle button isn't floated right then this will push information down the page on desktop views and ideally we want to show table/list rows as far up the page as we can to reduce scrolling. I think we can try floating right and if it causes problems revert the change?

Dreamy_Jazz added a comment.Sep 3 2024, 1:46 PM

Sure. I will work on both points you raised in T369930#10088404.

gerritbot added a comment.Sep 3 2024, 1:58 PM

Change #1070259 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Show the temp IP toggle buttons on Special:DeletedContributions

https://gerrit.wikimedia.org/r/1070259

gerritbot added a project: Patch-For-Review.Sep 3 2024, 1:58 PM
Dreamy_Jazz moved this task from Priority Backlog to Needs review on the Trust and Safety Product Sprint (Sprint Theremin (Aug 26 - Sept. 6)) board.Sep 3 2024, 2:40 PM

Doing the work on the point about the position of the toggle buttons is maybe more work than I had anticipated. I think to achieve that, we need to add a new hook to core to allow modification of the HTML generated when creating the user tool links, so that we can place the buttons in a wrapper container with just the tool links.

gerritbot added a comment.Sep 3 2024, 9:15 PM

Change #1070259 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Show the temp IP toggle buttons on Special:DeletedContributions

https://gerrit.wikimedia.org/r/1070259

Maintenance_bot removed a project: Patch-For-Review.Sep 3 2024, 9:30 PM
ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.22; 2024-09-10); removed MW-1.43-notes (1.43.0-wmf.15; 2024-07-23).Sep 3 2024, 10:00 PM
Dreamy_Jazz removed Dreamy_Jazz as the assignee of this task.Sep 4 2024, 9:59 AM
Dreamy_Jazz moved this task from Needs review to Ready on the Trust and Safety Product Sprint (Sprint Theremin (Aug 26 - Sept. 6)) board.
Djackson-ctr mentioned this in T369859: Update Special:IPContributions UI messages according to design specification.Sep 9 2024, 5:11 PM
kostajh added a comment.Sep 16 2024, 8:56 AM
In T369930#10113345, @Dreamy_Jazz wrote:

Doing the work on the point about the position of the toggle buttons is maybe more work than I had anticipated. I think to achieve that, we need to add a new hook to core to allow modification of the HTML generated when creating the user tool links, so that we can place the buttons in a wrapper container with just the tool links.

@KColeman-WMF do we need to do this work about the position of the toggle buttons? Or could we split that off into a new task?

kostajh closed this task as Resolved.Sep 16 2024, 10:14 AM
kostajh claimed this task.
In T369930#10147827, @kostajh wrote:
In T369930#10113345, @Dreamy_Jazz wrote:

Doing the work on the point about the position of the toggle buttons is maybe more work than I had anticipated. I think to achieve that, we need to add a new hook to core to allow modification of the HTML generated when creating the user tool links, so that we can place the buttons in a wrapper container with just the tool links.

@KColeman-WMF do we need to do this work about the position of the toggle buttons? Or could we split that off into a new task?

@Dreamy_Jazz will file a new task for this.

Dreamy_Jazz moved this task from Ready to Done on the Trust and Safety Product Sprint (Sprint Theremin (Aug 26 - Sept. 6)) board.Sep 16 2024, 1:16 PM
Dreamy_Jazz mentioned this in T375282: Update the position of the IPContributions and Contributions toggle switches to match the design spec.Sep 20 2024, 4:26 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits