Page MenuHomePhabricator

Suppressed users shouldn't be shown in a drop-down list of users to ping
Open, Needs TriagePublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Click Mention a user button
  • Type in a username (I typed "DerHexer" on a talk page on Meta-wiki.)

What happens?:
Drop-down list of suggested usernames includes suppressed users that aren't showing in the global list of users. (I see two usernames that start with "DerHexer" plus some obscenities.)

What should have happened instead?:
Suppressed users shouldn't be shown.

Event Timeline

This happens when the users are blocked and suppressed globally, but also blocked locally without suppression. The local blocks need to be updated (adding username suppression) or removed (so that the global suppression may take effect). Previous discussions: T277919#6986006, T25310

Someone may have fixed the specific example on metawiki following this report. The blocked users are available from the API, but they're successfully filtered out in the completion display. (The removal criteria is user.blockexpiry === 'infinite' && !user.blockpartial if you're looking at those results.)

image.png (536×252 px, 16 KB)

I am not sure filtering out plain blocked users is a good idea. Someone might have a 1 day block for getting a bit too worked up in a discussion, but it would be a valid use case to ping them in a bunch of places.


This seems like a general hidden vs suppressed difference for global locks. And to be honest the only benefit of just plain hidden is that it always works while for global suppression you have to use DerHexer's script because of T25310, like usually if a username is bad enough to be hidden it also meets the OS policy to be suppressed.

Someone with a temporary block wouldn't have been filtered out of the completions. See my previous comment for the criteria -- basically: a permanent non-partial block.