Page MenuHomePhabricator

New Notification flashes bright blue, unreadable in dark mode
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue:

What happens?:
The new notification is shown with a bright blue background and basically unreadable. After a short time the background fades to the normal color and the notification becomes readable.

What should have happened instead?:
The notification should be readable right from the start.

Notes:

Event Timeline

KStoller-WMF moved this task from Inbox to Up Next (estimated tasks) on the Growth-Team board.

Thank you for tagging this task with good first task for Wikimedia newcomers!

Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.

A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly pointed to the codebase URL and provide clear steps to help a contributor get setup for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !

Thank you for helping us drive new contributions to our projects <3

Able to replicate on testwiki, both for notices and alerts.

Also found that the "You have a new Talk page message" is also not accessible, and on hover is worse:

image.png (87×453 px, 7 KB)

(made T372056: "You have a new Talk page message" is not accessible in dark mode)

I tried to reproduce the issue as per the task description (i.e. a temp user on dewiki beta got the welcome notification) - seems to be working without any issues (see the animated gif below):

notification_flash2.gif (613×1 px, 55 KB)

Also checked testwiki wmf.18 - the issue was not present there. Checked in FF and Chrome browsers.

I can still reproduce on Firefox modern using the instructions in description as well as on live English Wikipedia.

KStoller-WMF subscribed.

@JFernandez-WMF will suggest a design token and/or color to replace the current bright blue background that doesn't work well in darkmode.

@JFernandez-WMF will suggest a design token and/or color to replace the current bright blue background that doesn't work well in darkmode.

I quickly looked up the status quo. This is where the animation is defined color-wise:

modules/styles/mw.echo.ui.NotificationItemWidget.less
@keyframes unseen-fadeout-to-unread {
	from {
		background-color: @notification-background-unseen;
	}

	to {
		background-color: @notification-background-unread;
	}
}

@keyframes unseen-fadeout-to-read {
	from {
		background-color: @notification-background-unseen;
	}

	to {
		background-color: @notification-background-read;
	}
}

and the variables are:

modules/echo.variables.less
@notification-background-unseen: #dce8ff;
@notification-background-unread: @background-color-base;
@notification-background-read: @background-color-neutral;

Closest option at the moment would be @background-color-progressive-subtle I would assume?

Mh, maybe.
I probably wouldn't notice the slight color change in the animation.
If I set the initial colors of the animation next to each other, then it looks like this:

image.png (304×1 px, 48 KB)

And in darkmode:

image.png (267×1 px, 35 KB)

@JFernandez-WMF: What do you think?

Change #1070045 had a related patch set uploaded (by Sjoerddebruin; author: Sjoerddebruin):

[mediawiki/extensions/Echo@master] Set Codex-token for @notification-background-unseen

https://gerrit.wikimedia.org/r/1070045

Due to the lack of a response so far I've already prepared the patch, I don't think there are other viable options and I rather have this fixed than waiting for a formality approval.

Due to the lack of a response so far I've already prepared the patch, I don't think there are other viable options and I rather have this fixed than waiting for a formality approval.

Ah, turns out I forgot to actually push the exact same change I already have on disk XD. I agree, it is probably fine to move forward with this for now, and we can still make adjustments later if so required.

Change #1070045 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Set Codex-token for @notification-background-unseen

https://gerrit.wikimedia.org/r/1070045

KStoller-WMF moved this task from Incoming to QA on the Growth-Team (FY2024-25 Q1 Sprint 4) board.
KStoller-WMF added a subscriber: JFernandez-WMF.

Thanks @Sjoerddebruin, I'm assigning to you since you helped move this forward! I'll move it to QA now to make sure we test it.

Tested in testwiki wmf.23 (FF 130) - the fix is in place:

dark_mode_notification2.gif (387×700 px, 44 KB)