Page MenuHomePhabricator

[SW] [WtC-M2] [SNL] Replace WiKit Button component by Codex's
Closed, ResolvedPublic

Description

Problem

The Special:NewLexeme's user interface was composed using WiKit next elements, such as Button. The WiKit design system is now on its deprecation path, as it has been superseded by Codex, the official Wikimedia design system. The utilization of WiKit components is not recommended, and they should be replaced in order to reduce maintenance costs and ensure consistency.

Solution

We have to replace the WiKit Button by the Codex equivalent: cdx-button (See demo) with action: progressive and weight: primary.

This will take us a step closer to switching to the new design system and deprecating the old.

image.png (1×2 px, 408 KB)

The WiKit primary progressive button to be replaced is used in the following Special:NewLexeme component:

Acceptance criteria
  • The WiKit button used in Special:NewLexeme is replaced by its Codex equivalent

Event Timeline

Arian_Bozorg renamed this task from [WtC-M2] [SNL] Replace WiKit Button component by Codex's to [SW] [WtC-M2] [SNL] Replace WiKit Button component by Codex's.Jul 16 2024, 1:41 PM

Hey @ArthurTaylor when I click the netlify link in the PR this is the UI i see

grafik.png (930×2 px, 149 KB)

That doesn't seem right. Can you provide me with the correct netlify link for the review? Thanks!

https://e89f5b5829b9548755554c4a1161965a9f2d--new-lexeme-special-page.netlify.app/ is the correct link. The netlify environment is different from a wiki-embedded environment - in netlify you will just see the new lexeme form on its own outside of a wiki context. But hopefully this is enough for a review. If that's not enough then we'll need to look at getting a staging environment up and running for you to review the components 'in situ'.

that's exactly the link i was looking at and as you can see it looks very different from what it probably looks like IRL. It would not make sense for me to review the changes using that link. How was Sarai doing your reviews?

For most components, when we commit the code, the changes are live to view on the beta wiki within some minutes. Special New Lexeme doesn't work that way - we need to do some extra work to make the changes live.

Once the changes are live, it's usually about a week before they hit production. If you have time in the coming week to do another review of the tickets, we can make the current set of changes live and you can review them on beta and give us feedback before they hit production. (Or after they hit production, but obviously it's a slightly worse user experience in that case if we have subsequently to make changes based on your feedback).

Should we activate the current set of changes for deployment to beta (and production) so that you can review?

we can make the current set of changes live and you can review them on beta and give us feedback before they hit production. (Or after they hit production, but obviously it's a slightly worse user experience in that case if we have subsequently to make changes based on your feedback).

Should we activate the current set of changes for deployment to beta (and production) so that you can review?

FWIW, IMHO the current migration state isn’t really suitable for production – the different style of the field label between the lemma (migrated) and language / lexical category (not migrated yet) is pretty noticeable.

image.png (326×807 px, 32 KB)

We can still roll it out to Beta, but then I’d want to revert that before the next branch cut on Monday. (I don’t like doing it that way, but it might be the best way to let UX look at the changes.)

What about a flag that decides which dist bundle to serve, is it too much overhead?

Hey all, I'd be super happy about the beta option. I have time next week and could do the review that way. Thanks for suggesting!

I wonder if https://patchdemo.wmflabs.org/ is also an option here - maybe we could stage the changes in a patch and deploy that there?

Probably not, Patch Demo doesn’t support Wikibase (#552).

I wonder if https://patchdemo.wmflabs.org/ is also an option here - maybe we could stage the changes in a patch and deploy that there?

I wish, actually about a year ago I was interviewed by @SDunlap about a prototype she was working on, I think it was called Catalyst? I wonder if there's any progress there, as I haven't caught up since I got back.