cooltey opened https://github.com/wikimedia/apps-android-wikipedia/pull/4824

Hi @AlexHollender-WMF

The implementation is completed. Please download the APK from the ticket description, thanks.

(This does not impact the functionality)
Would it be possible to provide an SVG of this image? The following was the one I exported from Figma and it looks like the markers are not showing correctly.

@cooltey yes, my apologies. Here is the SVG:

A few additional notes and questions (which I should have specified earlier on, my apologies for that as well):

1. Currently when I tap the Places card in the Explore feed it opens up the article. Would it be possible instead to open the article preview within the Places feature? I think that this would better help people understand/explore the value of the places feature.

2. I noticed that sometimes the card in the Explore feed uses the gray circle placeholder for the image even though the article has a preview image (which is used in the Places map & list view). Is this expected?

3. @JTannerWMF I'm not sure why, but for some reason I kind of tripped up when reading "Places nearby", like my brain couldn't quite connect the concepts. Do you think "Places near you" is more clear?

4. I am waiting to hear back from Robin, but we might need to switch the article title on the card to the h1-article type style.

5. Should we enable a long-press action for the Explore feed card? It seems like the standard options for an article card would make sense, maybe with a slight adjustment if we end up doing #1 above:

• Open in Places
• Open in new tab
• Save
• Share link
• Copy link address

6. In the case where I deny location permission, when I go back to the Explore feed this is what I see:

If a user has opened the Places feature before they will see this card in their explore feed, which should show the last article they looked at, NOT the closest article to them

@JTannerWMF if this is open for discussion I'm curious to better understand this requirement (mainly why we wouldn't show the closest article to them).

Hi @AlexHollender-WMF,

Thanks for the SVG! I have updated the APK and please download the APK from the ticket description to see the changes, thanks!

1. Currently when I tap the Places card in the Explore feed it opens up the article. Would it be possible instead to open the article preview within the Places feature? I think that this would better help people understand/explore the value of the places feature.

Done.

2. I noticed that sometimes the card in the Explore feed uses the gray circle placeholder for the image even though the article has a preview image (which is used in the Places map & list view). Is this expected?

Fixed.

4. I am waiting to hear back from Robin, but we might need to switch the article title on the card to the h1-article type style.

Changed so you can check it with Robin.

5. Should we enable a long-press action for the Explore feed card? It seems like the standard options for an article card would make sense, maybe with a slight adjustment if we end up doing #1 above:

• Open in Places
• Open in new tab
• Save
• Share link
• Copy link address

Added.

6. In the case where I deny location permission, when I go back to the Explore feed this is what I see:

I'm sure if this matches the requirements (I'm unclear why that article is the one selected, and why it displays 0 miles).

In this case, on the explore feed, we use the stored "last location information" to request the nearby API. So if the user ever visited the Places feature and played around the feature (even without the location permission), the user can still see the card.

Since we are not going to request permission on the Explore feed, it should be fine to keep the logic, or we can discuss an alternative solution for this.

If a user has opened the Places feature before they will see this card in their explore feed, which should show the last article they looked at, NOT the closest article to them

@JTannerWMF if this is open for discussion I'm curious to better understand this requirement (mainly why we wouldn't show the closest article to them).

Yes and we should discuss this in the team meeting.

@cooltey the updates look great for the most part. A few small notes:

It seems there is extra white space above and below the map illustration

Thanks for updating the font. Let's use h3-article. Sorry for the back and forth there.

6. In the case where I deny location permission, when I go back to the Explore feed this is what I see:

I'm sure if this matches the requirements (I'm unclear why that article is the one selected, and why it displays 0 miles).

In this case, on the explore feed, we use the stored "last location information" to request the nearby API. So if the user ever visited the Places feature and played around the feature (even without the location permission), the user can still see the card.

Ok, I understand. I believe in this case we should render the card with "Unknown distance", because we don't know how far the place is from them. Does that make sense?

what we are currently showing	what iOS shows	what I think we should show

On my initial encounter of the Places card in the Explore feed, if I tap on it, enable location permission, then after exploring Places press the back button I land back at the Explore feed card, however it is still in the initial state (with the illustration, asking me to Enable location). Is there any way to refresh the card to reflect that location permissions have been enabled?

Hi @AlexHollender-WMF

Thanks, please download the APK again to see the changes.

It seems there is extra white space above and below the map illustration

Fixed!

---

Thanks for updating the font. Let's use h3-article. Sorry for the back and forth there.

No worries 👍

6. In the case where I deny location permission, when I go back to the Explore feed this is what I see:

I'm sure if this matches the requirements (I'm unclear why that article is the one selected, and why it displays 0 miles).

In this case, on the explore feed, we use the stored "last location information" to request the nearby API. So if the user ever visited the Places feature and played around the feature (even without the location permission), the user can still see the card.

Ok, I understand. I believe in this case we should render the card with "Unknown distance", because we don't know how far the place is from them. Does that make sense?

what we are currently showing	what iOS shows	what I think we should show

It makes sense to me, done! I also added a filter that if the distance is 0, the card will show the next nearest place instead of the 0 distance one.

Now, the feed will refresh after you visit the Places and return.

@cooltey thanks for the updates

1. I'm still seeing the h1-article font for the article title (should be h3-article)

h1-article	h3-article

On my initial encounter of the Places card in the Explore feed, if I tap on it, enable location permission, then after exploring Places press the back button I land back at the Explore feed card, however it is still in the initial state (with the illustration, asking me to Enable location). Is there any way to refresh the card to reflect that location permissions have been enabled?

Ok, so now the entire Explore feed reloads and scrolls back up to the top if I click on the Places card then tap "back" (from Places to Explore). In a perfect world you would keep your scroll position in the Explore feed, and just the Places card would be refresh.

Since this was meant to solve a one-time issue, I don't think it's worth refreshing the Explore feed and loosing your place within it every time you go back from Places to Explore. If there's a way to keep your scroll position, and just refresh the Places card that would be great, otherwise I think we should go back to how it was before.

That's it for design review. I found two other issues, but I think it's more in the territory of QA, so would just want to make sure that these flows get added to the QA instructions:

1. (With location permission enabled) If I tap on a Places card in the Explore feed, then go back to the Explore feed, the Places card shows "unknown distance"

tap on a Places card	return to Places card

2. If I decline location permission but still use the Places feature (by manually zooming in on the map), then return to the Explore feed I see the correct card, however it is still showing a distance (which should be unknown)

Hi @AlexHollender-WMF

Please download the APK again to see the changes, thanks.

In T370100#10046559, @AlexHollender-WMF wrote:

@cooltey thanks for the updates

1. I'm still seeing the h1-article font for the article title (should be h3-article)

Sorry, missed that! Done.

---

On my initial encounter of the Places card in the Explore feed, if I tap on it, enable location permission, then after exploring Places press the back button I land back at the Explore feed card, however it is still in the initial state (with the illustration, asking me to Enable location). Is there any way to refresh the card to reflect that location permissions have been enabled?

Ok, so now the entire Explore feed reloads and scrolls back up to the top if I click on the Places card then tap "back" (from Places to Explore). In a perfect world you would keep your scroll position in the Explore feed, and just the Places card would be refresh.

Since this was meant to solve a one-time issue, I don't think it's worth refreshing the Explore feed and loosing your place within it every time you go back from Places to Explore. If there's a way to keep your scroll position, and just refresh the Places card that would be great, otherwise I think we should go back to how it was before.

Got it. Can we only refresh the feed only go back and refresh the feed if you go to Places from the "Enable permission" card? If you'd like to keep it in the same position for both states, I can change it back.

Ideally, we can do a single card refresh mechanics (like what we've done for Suggested Edits), but it requires extra logic + has some minor issues with that method (which is not recommended).

---

That's it for design review. I found two other issues, but I think it's more in the territory of QA, so would just want to make sure that these flows get added to the QA instructions:

1. (With location permission enabled) If I tap on a Places card in the Explore feed, then go back to the Explore feed, the Places card shows "unknown distance"

tap on a Places card	return to Places card

This is expected: because the last coordinates were saved and it will be used in calculating the distance between the cards.

---

2. If I decline location permission but still use the Places feature (by manually zooming in on the map), then return to the Explore feed I see the correct card, however it is still showing a distance (which should be unknown)

This is also expected: because the app saves the last coordinates after you leave Places, whether you have the location permission or not. Since we are not checking the location permission on the explore feed, this issue is not avoidable.

@cooltey looks good. Moving it along on the board assuming I don't need to review the final change below (since I had already seen it like that initially).

Got it. Can we only refresh the feed only go back and refresh the feed if you go to Places from the "Enable permission" card? If you'd like to keep it in the same position for both states, I can change it back.

Yes, let's switch it back so that:

• the Explore feed does not refresh
• you maintain your scroll position

Thanks @AlexHollender-WMF, done!

Looking good on 2.7.50498-beta-2024-08-19