| KStoller-WMF | |
| Jul 16 2024, 2:49 AM |
| F48443748: Screenshot_20240424_112702.png | |
| Jul 16 2024, 2:49 AM |
The new Impact Module has been released to all Wikipedias for several months, it's time to remove the "updated design" popup.
In other words, we should revert the work done as part of this task: T323619: NewImpact: Introduce new design to existing newcomers via GuidedTour and Drawer
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Sgs | T370120 Special:Homepage: Remove Impact Module popup about "updated design" | |||
| Resolved | Sgs | T376461 Remove unused user property growthexperiments-tour-newimpact-discovery |
I agree we should do that too, but I think that's a different and larger effort. Here's the task for that: T350077: Drop support for the old Impact module
I moved it into Engineering Maintenance so we don't forget about it, but feel free to move it into "Up Next" if you think we should work on ASAP.
We happen to have the "new impact discovery" instrumented. I'm assuming it is ok to remove related instrumentation schema properties as part of this task. cc @nettrom_WMF
Change #1060401 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):
[mediawiki/extensions/GrowthExperiments@master] NewImpact: remove discovery tour for the module
Change #1060409 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):
[schemas/event/secondary@master] analytics/legacy/homepagemodule: remove deprecated newimpact discovery tour actions
Change #1060410 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):
[mediawiki/extensions/GrowthExperiments@master] Bump homepagemodule schema
Change #1060401 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] NewImpact: remove discovery tour for the module
Is there an example of removing values from a schema enumeration in a backwards compatible way? 1060409 complains about that but Idk how to do it.
Change #1060409 abandoned by Sergio Gimeno:
[schemas/event/secondary@master] analytics/legacy/homepagemodule: remove deprecated newimpact discovery tour actions
Reason:
Assuming it is fine to leave deprecated actions for backwards comp
Change #1060410 abandoned by Sergio Gimeno:
[mediawiki/extensions/GrowthExperiments@master] Bump homepagemodule schema
Reason:
No need for bump for deprecated actions
Checked in beta and testwiki wmf.23 (desktop and mobile) for new and old accounts; also for users who used the options:"Restore all default preferences (in all sections)".
Checked the events for Impact module in HomepageModule schema - all events are still in place; no events related to the newimpact tour (i.e. newimpactdiscovery- events) are recorded.