Page MenuHomePhabricator

[WtC-M3] [QB] Port BouncingDots to Query Builder
Closed, ResolvedPublic

Description

Problem

The BouncingDots component was implemented in WiKit to indicate the processing of the users' input in DateInput.

This is a core component that is in the process of being designed for Codex. Unfortunately, it likely won't be available in time before we complete the migration.

Solution

In order to unblock the migration to Codex and the deprecation of WiKit, we'll port the WiKit InputWithExtender component to the Query Builder repository. We'll apply all necessary changes to make the element compatible with the new version of the tool.

Considerations
  • Replacement by Codex component: It is to be confirmed whether we'd be able to reuse the BouncingDots loader inside the ported DataInput. In which case, a separate replacement task will need to be created (See Table component replacement task for guidance).
  • Styles: In order to unblock WiKit's deprecation, we should also remove all WiKit tokens used within the BouncingDots loader. Since the component might be soon replaced by Codex's, we can just use discrete values in this case to reduce effort.
Open questions
  • Will it be feasible/reasonable to use Codex’s BouncingDots loader inside of DateInput in the context of the Query Builder?
Acceptance criteria
  • The WiKit BouncingDots component is ported to Query builder and made compatible with the migrated version of the tool
  • Any WiKit building blocks, dependencies or styles are replaced

Details

Event Timeline

Arian_Bozorg renamed this task from [SW] [WtC-M3] [QB] Port BouncingDots to Query Builder to [WtC-M3] [QB] Port BouncingDots to Query Builder.Jul 30 2024, 8:52 AM

Change #1099186 had a related patch set uploaded (by Hasan Akgün (WMDE); author: Hasan Akgün (WMDE)):

[wikidata/query-builder@master] Port Wikit Bouncing Dots component to QB

https://gerrit.wikimedia.org/r/1099186

Change #1099186 merged by jenkins-bot:

[wikidata/query-builder@master] Port Wikit Bouncing Dots component to QB

https://gerrit.wikimedia.org/r/1099186

Could you please provide me with a netlify link so that i can review the changes?

Can someone update me on whether a decision was taken whether the bouncing dots are meant to be reused in the QB? Until then there's nothing for me to review here I think. Please let me know if i'm wrong.

hm, according to this ticket T367898 it looks to me like the bouncing dots should be included in the "new" version. I was not able to create a situation where the bouncing dots were visible to me (same situation lead to bouncing dots in the current QB version).

Had a look together with @HasanAkgun_WMDE and everything looks good now 🎉