Page MenuHomePhabricator

AbuseFilter special page is not dark mode friendly
Closed, ResolvedPublicBUG REPORT

Assigned To
Authored By
Jdlrobson
Jul 16 2024, 6:36 PM
Referenced Files
F62313436: image.png
Jun 13 2025, 2:07 PM
F62313429: image.png
Jun 13 2025, 2:07 PM
F62313048: image.png
Jun 13 2025, 1:09 PM
F56777207: image.png
Jul 30 2024, 1:10 AM

Description

Steps to replicate the issue (include links if applicable):

What happens?:
The tr.mw-abusefilter-list-disabled, tr.mw-abusefilter-list-disabled td element uses color: #666; which is not a recognized design token and does not pass color contrast requirements for accessibility

What should have happened instead?:
The color #666 should be replaced with a design token from https://doc.wikimedia.org/codex/latest/design-tokens/overview.html or an override should be provided for dark mode to use a more suitable color.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
https://www.mediawiki.org/wiki/Recommendations_for_night_mode_compatibility_on_Wikimedia_wikis

Event Timeline

And this dropdown on the same page.

image.png (656×916 px, 35 KB)

Noting that the dropdown only seems to affect certain browsers - when I open https://commons.wikimedia.org/wiki/Special:AbuseFilter/examine/log/11407273 on Windows it doesn't work but it works fine on Arch Linux Firefox 139.0

image.png (956×1 px, 176 KB)

Change #1156842 had a related patch set uploaded (by Matr1x; author: Matr1x):

[mediawiki/extensions/AbuseFilter@master] Support dark mode for Abuse Filter editor

https://gerrit.wikimedia.org/r/1156842

The dropdown will probably be solved by T369576 once OOUI v0.52.0 is released (T396629).

Change #1156842 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] Support dark mode for Abuse Filter editor

https://gerrit.wikimedia.org/r/1156842

Matrix claimed this task.

All issues look to be fixed.

Test wiki on Patch demo by Matrix using patch(es) linked to this task was deleted:

https://patchdemo.wmcloud.org//wikis/743038d27f/w/