Page MenuHomePhabricator

suggested improvements for global vanishing messages
Closed, ResolvedPublicBUG REPORT

Description

Some messages were recently added for global vanishing. As I've been translating, I found some issues. Addressing them will improve the UI and make them easier to translate.

  1. globalrenamequeue-request-vanish-status-title: Vanish from "$1"

$1 is not documented in qqq. It has to be documented.

If I understand the code correctly, it's the username that the person wants to hide.

Perhaps it's better to write it as `Vanish "$1" or Vanish as "$1".

  1. globalvanishrequest-blocked-title: Global user account vanish request blocked

The message Global user account vanish request blocked (globalvanishrequest-blocked-title) should probably be changed. Just saying that the request is blocked is a bit weird: usually, accounts are blocked and not requests. If it happens because of a human decision, then it should probably be something like "Global user account vanish request rejected" or "Global user account vanish request rejected because your account is blocked".

If the software automatically detects that it cannot be done because the user is blocked, then maybe it should be something like "Global user account vanish request cannot be processed because your account is blocked". (But then maybe it should be impossible to submit this request in the first place?)

Event Timeline

Change #1054668 had a related patch set uploaded (by Seawolf35gerrit; author: Seawolf35gerrit):

[mediawiki/extensions/CentralAuth@master] Improvements for global vanishing messages.

https://gerrit.wikimedia.org/r/1054668

Change #1054668 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Improvements for global vanishing messages.

https://gerrit.wikimedia.org/r/1054668