Page MenuHomePhabricator
Create Task
Maniphest T370219

DBQueryError marking page for translation: Table 'mediawikiwiki.translate_cache' doesn't exist
Closed, ResolvedPublic2 Estimated Story PointsPRODUCTION ERROR
Actions

Description

Trying to mark any page for translation fails:

A database query error has occurred. This may indicate a bug in the software.
[23920d5e-75f7-4412-9004-b246bbfce42d] 2024-07-16 21:13:42: Fatal exception of type "Wikimedia\Rdbms\DBQueryError"
Error
normalized_message
[{reqId}] {exception_url}   Wikimedia\Rdbms\DBQueryError: Error 1146: Table 'mediawikiwiki.translate_cache' doesn't exist
Function: MediaWiki\Extension\Translate\Cache\PersistentDatabaseCache::delete
Query: DELETE FROM `translate_cache` WHERE tc_key = 'pa
exception.trace
from /srv/mediawiki/php-1.43.0-wmf.14/includes/libs/rdbms/database/Database.php(1194)
#0 /srv/mediawiki/php-1.43.0-wmf.14/includes/libs/rdbms/database/Database.php(1178): Wikimedia\Rdbms\Database->getQueryException(string, integer, string, string)
#1 /srv/mediawiki/php-1.43.0-wmf.14/includes/libs/rdbms/database/Database.php(1152): Wikimedia\Rdbms\Database->getQueryExceptionAndLog(string, integer, string, string)
#2 /srv/mediawiki/php-1.43.0-wmf.14/includes/libs/rdbms/database/Database.php(643): Wikimedia\Rdbms\Database->reportQueryError(string, integer, string, string, boolean)
#3 /srv/mediawiki/php-1.43.0-wmf.14/includes/libs/rdbms/database/Database.php(1714): Wikimedia\Rdbms\Database->query(Wikimedia\Rdbms\Query, string)
#4 /srv/mediawiki/php-1.43.0-wmf.14/includes/libs/rdbms/database/DBConnRef.php(127): Wikimedia\Rdbms\Database->delete(string, array, string)
#5 /srv/mediawiki/php-1.43.0-wmf.14/includes/libs/rdbms/database/DBConnRef.php(581): Wikimedia\Rdbms\DBConnRef->__call(string, array)
#6 /srv/mediawiki/php-1.43.0-wmf.14/extensions/Translate/src/Cache/PersistentDatabaseCache.php(119): Wikimedia\Rdbms\DBConnRef->delete(string, array, string)
#7 /srv/mediawiki/php-1.43.0-wmf.14/extensions/Translate/src/PageTranslation/TranslatablePageStateStore.php(32): MediaWiki\Extension\Translate\Cache\PersistentDatabaseCache->delete(string)
#8 /srv/mediawiki/php-1.43.0-wmf.14/extensions/Translate/src/PageTranslation/TranslatablePageMarker.php(321): MediaWiki\Extension\Translate\PageTranslation\TranslatablePageStateStore->remove(MediaWiki\Page\PageStoreRecord)
#9 /srv/mediawiki/php-1.43.0-wmf.14/extensions/Translate/src/PageTranslation/PageTranslationSpecialPage.php(308): MediaWiki\Extension\Translate\PageTranslation\TranslatablePageMarker->markForTranslation(MediaWiki\Extension\Translate\PageTranslation\TranslatablePageMarkOperation, MediaWiki\Extension\Translate\PageTranslation\TranslatablePageSettings, MediaWiki\User\User)
#10 /srv/mediawiki/php-1.43.0-wmf.14/extensions/Translate/src/PageTranslation/PageTranslationSpecialPage.php(170): MediaWiki\Extension\Translate\PageTranslation\PageTranslationSpecialPage->onActionMark(MediaWiki\Title\Title, integer)
#11 /srv/mediawiki/php-1.43.0-wmf.14/includes/specialpage/SpecialPage.php(719): MediaWiki\Extension\Translate\PageTranslation\PageTranslationSpecialPage->execute(NULL)
#12 /srv/mediawiki/php-1.43.0-wmf.14/includes/specialpage/SpecialPageFactory.php(1694): MediaWiki\SpecialPage\SpecialPage->run(NULL)
#13 /srv/mediawiki/php-1.43.0-wmf.14/includes/actions/ActionEntryPoint.php(502): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, MediaWiki\Context\RequestContext)
#14 /srv/mediawiki/php-1.43.0-wmf.14/includes/actions/ActionEntryPoint.php(145): MediaWiki\Actions\ActionEntryPoint->performRequest()
#15 /srv/mediawiki/php-1.43.0-wmf.14/includes/MediaWikiEntryPoint.php(200): MediaWiki\Actions\ActionEntryPoint->execute()
#16 /srv/mediawiki/php-1.43.0-wmf.14/index.php(58): MediaWiki\MediaWikiEntryPoint->run()
#17 /srv/mediawiki/w/index.php(3): require(string)
#18 {main}
Impact
Notes

Details

MediaWiki Version
1.43.0-wmf.14
Request URL
https://www.mediawiki.org/wiki/Special:PageTranslation
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
TranslatablePageStateStore: Check if translate_cache table existsmediawiki/extensions/Translatemaster+32 -2
TranslatablePageState: Check if banner namespaces are configuredmediawiki/extensions/Translatemaster+33 -7
TranslatablePageState: Check if banner namespaces are configuredmediawiki/extensions/Translatewmf/1.43.0-wmf.14+33 -7
Customize query in gerrit

Related Objects
Search...

Event Timeline

Pppery created this task.Jul 16 2024, 9:15 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 16 2024, 9:15 PM
Pppery triaged this task as Unbreak Now! priority.Jul 16 2024, 9:15 PM
Aklapper renamed this task from DBQueryError marking page for translation to DBQueryError marking page for translation: Table 'mediawikiwiki.translate_cache' doesn't exist.Jul 16 2024, 9:33 PM
Aklapper updated the task description. (Show Details)
Aklapper added a project: Language-Team.Jul 16 2024, 9:42 PM
dancy added a parent task: T366959: 1.43.0-wmf.14 deployment blockers.Jul 16 2024, 9:55 PM
dancy subscribed.

I added this task as a train blocker.

Pppery added a subscriber: Shirayuki.Jul 16 2024, 10:59 PM

This just got reported again on-wiki at https://www.mediawiki.org/wiki/Topic:Y8ob5vsn9fzmef1j

bd808 subscribed.Jul 16 2024, 11:25 PM

Sounds a lot like a repeat of the problem from T272428: Error 1146: Table 'mediawikiwiki.translate_cache' doesn't exist where a new code path was missing feature flags to keep it from trying to use the translate_cache table here.

abi_ edited projects, added Language and Product Localization; removed Language-Team.Jul 17 2024, 3:36 AM
gerritbot added a comment.Jul 17 2024, 3:57 AM

Change #1054692 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] TranslatablePageStateStore: Check if translate_cache table exists

https://gerrit.wikimedia.org/r/1054692

gerritbot added a project: Patch-For-Review.Jul 17 2024, 3:58 AM
gerritbot added a comment.Jul 17 2024, 5:06 AM

Change #1054697 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] TranslatablePageState: Check if banner namespaces are configured

https://gerrit.wikimedia.org/r/1054697

abi_ claimed this task.Jul 17 2024, 5:14 AM
abi_ edited projects, added LPL Essential (LPL Essential 2024 Jul-Oct); removed Language and Product Localization.
abi_ set the point value for this task to 2.
abi_ moved this task from Sprint Backlog to Needs Review on the LPL Essential (LPL Essential 2024 Jul-Oct) board.
gerritbot added a comment.Jul 17 2024, 5:19 AM

Change #1054699 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@wmf/1.43.0-wmf.14] TranslatablePageState: Check if banner namespaces are configured

https://gerrit.wikimedia.org/r/1054699

gerritbot added a comment.Jul 17 2024, 7:50 AM

Change #1054699 merged by jenkins-bot:

[mediawiki/extensions/Translate@wmf/1.43.0-wmf.14] TranslatablePageState: Check if banner namespaces are configured

https://gerrit.wikimedia.org/r/1054699

Stashbot added a comment.Jul 17 2024, 7:51 AM

Mentioned in SAL (#wikimedia-operations) [2024-07-17T07:51:34Z] <kartik@deploy1002> Started scap sync-world: Backport for [[gerrit:1054699|TranslatablePageState: Check if banner namespaces are configured (T370219)]]

gerritbot added a comment.Jul 17 2024, 7:53 AM

Change #1054697 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] TranslatablePageState: Check if banner namespaces are configured

https://gerrit.wikimedia.org/r/1054697

Stashbot added a comment.Jul 17 2024, 7:54 AM

Mentioned in SAL (#wikimedia-operations) [2024-07-17T07:54:12Z] <kartik@deploy1002> abi, kartik: Backport for [[gerrit:1054699|TranslatablePageState: Check if banner namespaces are configured (T370219)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.15; 2024-07-23).Jul 17 2024, 8:00 AM
Stashbot added a comment.Jul 17 2024, 8:06 AM

Mentioned in SAL (#wikimedia-operations) [2024-07-17T08:06:00Z] <kartik@deploy1002> Finished scap: Backport for [[gerrit:1054699|TranslatablePageState: Check if banner namespaces are configured (T370219)]] (duration: 14m 26s)

Tacsipacsi subscribed.Jul 17 2024, 8:39 AM

With one patch deployed, this is no longer UBN/train blocker, is it?

abi_ added a comment.Jul 17 2024, 8:46 AM
In T370219#9989300, @Tacsipacsi wrote:

With one patch deployed, this is no longer UBN/train blocker, is it?

I'm inclined to mark this as done, and create a separate task to have this table created on production following: https://wikitech.wikimedia.org/wiki/Creating_new_tables

Tacsipacsi added a comment.Jul 17 2024, 9:54 AM

That sounds good to me, but if you do that, what’s the fate of https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Translate/+/1054692? Do you plan to abandon it? (As I wrote in the comment on Gerrit, I’d support that, but I’d like you to be explicit about it.)

Jdforrester-WMF closed this task as Resolved.Jul 17 2024, 1:12 PM
Jdforrester-WMF mentioned this in T370265: Create new translate_cache table on Wikimedia wikis with the Translate extension installed.
Jdforrester-WMF subscribed.
In T370219#9989310, @abi_ wrote:
In T370219#9989300, @Tacsipacsi wrote:

With one patch deployed, this is no longer UBN/train blocker, is it?

I'm inclined to mark this as done, and create a separate task to have this table created on production following: https://wikitech.wikimedia.org/wiki/Creating_new_tables

Done: T370265

gerritbot added a comment.Jul 17 2024, 2:55 PM

Change #1054692 abandoned by Abijeet Patro:

[mediawiki/extensions/Translate@master] TranslatablePageStateStore: Check if translate_cache table exists

Reason:

In favor of Id442e6a858a65bc35b6558d5c1448ca329ca5d73

https://gerrit.wikimedia.org/r/1054692

dancy added a comment.Jul 17 2024, 2:56 PM

Thanks everyone!

Maintenance_bot removed a project: Patch-For-Review.Jul 17 2024, 3:30 PM
abi_ moved this task from Needs Review to Done on the LPL Essential (LPL Essential 2024 Jul-Oct) board.Jul 18 2024, 6:43 AM
• Jayve20 changed the task status from Resolved to Declined.Jul 27 2024, 6:59 AM
• Jayve20 removed abi_ as the assignee of this task.
• Jayve20 updated the task description. (Show Details)
• Jayve20 removed projects: MW-1.43-notes (1.43.0-wmf.15; 2024-07-23), LPL Essential (LPL Essential 2024 Jul-Oct), MediaWiki-extensions-Translate, Wikimedia-production-error.
• Jayve20 removed the point value 2 for this task.
• Jayve20 edited subscribers, added: abi_; removed: Jdforrester-WMF, Tacsipacsi, bd808 and 4 others.
Pppery changed the task status from Declined to Resolved.Jul 27 2024, 2:46 PM
Pppery assigned this task to abi_.
Pppery updated the task description. (Show Details)
Pppery added projects: MW-1.43-notes (1.43.0-wmf.15; 2024-07-23), LPL Essential (LPL Essential 2024 Jul-Oct), MediaWiki-extensions-Translate, Wikimedia-production-error.
Pppery set the point value for this task to 2.
Pppery added subscribers: Jdforrester-WMF, Tacsipacsi, bd808 and 4 others.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits