tonisevener opened https://github.com/wikimedia/wikipedia-ios/pull/4901

Part 1 ^

There will be more PRs to come for this one.

@HNordeenWMF it's pretty easy to hide the footer on article as well (About this article, Read more). Would you like me to do this, to limit paths away from the alt text context? Here's a screenshot of what I have so far:

@Tsevener if it's not any additional work, then sure that would be great to hide the footer! I just updated the task with that as a nice-to-have

mazevedofs closed https://github.com/wikimedia/wikipedia-ios/pull/4901

tonisevener opened https://github.com/wikimedia/wikipedia-ios/pull/4904

Note most of this work is done, but it won't be testable from Experiment C until https://phabricator.wikimedia.org/T370305 is done.

Great work so far @Mazevedo 👏 Some notes:

1) Can the preview scroll to the image that has just been added?

https://share.icloud.com/photos/0c39vg8GJKAyBzmDzYnCJubmQ

2) Is it possible to expand this sheet on tap? Currently, only a "hold and drag up" gesture expands the panel

3) After adding alt text to this image:

I get this (see annotations in the screenshot):

The publishing might need some tweaks. Here’s a video as well:

https://share.icloud.com/photos/0868AeSbLVA2RgcCrFXMfAtiA

The empty sheet is also present when tapping back (to go to the Explore feed):

{F57119803}

4) If the header image is the same as the destination image, can we hide it? It’s a bit confusing to see the image first, then scroll to the same image further down in the article:

https://share.icloud.com/photos/04drM2fN-wX9u7XgfxqGhIfYQ

Thanks @scblr! #3 is a major bug that I'll work on now, that was a difference in physical device vs. simulator that I missed 😑. We won't work on the other ones (at least not right away) unless @HNordeenWMF disagrees. Can you create a separate task for them so that we don't lose track of them?

I agree with that prioritization @Tsevener!

#1 is an improvement the core image recommendations flow, which is outside of the scope of this work. It can be filed as an improvement for Image recs V2: T364157
#2 The ability to minimize is new, and not present in Image recs yet. The prototype used in user testing had hold & drag behavior: T360567. Only 1/10 minimized the half sheet and did not know to slide it back up to view the image again. Adding the tap seems like a nice-to-have improvement, @scblr could you please file a task for this & attach to T371333? We can reassess in Sprint 3 and see if we're able to incorporate this.
#4 We could discuss if it became a permanent task, I do think there is value in knowing that the image you added has become the header image in the App

#3 Bug fix: https://github.com/wikimedia/wikipedia-ios/pull/4917

In T370231#10045625, @Tsevener wrote:

Thanks @scblr! #3 is a major bug that I'll work on now, that was a difference in physical device vs. simulator that I missed 😑. We won't work on the other ones (at least not right away) unless @HNordeenWMF disagrees. Can you create a separate task for them so that we don't lose track of them?

Sounds good, thanks Toni! 👍

In T370231#10045684, @HNordeenWMF wrote:

I agree with that prioritization @Tsevener!

#1 is an improvement the core image recommendations flow, which is outside of the scope of this work. It can be filed as an improvement for Image recs V2: T364157

Done: T372032 ✅

#2 The ability to minimize is new, and not present in Image recs yet. The prototype used in user testing had hold & drag behavior: T360567. Only 1/10 minimized the half sheet and did not know to slide it back up to view the image again. Adding the tap seems like a nice-to-have improvement, @scblr could you please file a task for this & attach to T371333?

Done: T372033 ✅

#4 We could discuss if it became a permanent task, I do think there is value in knowing that the image you added has become the header image in the App

Ok, I left a note in T364157 ✅

I noticed this in testing & it affects a few articles since a lot of times these are Stubs that come up for "Add an image"

• Add an image to a stub article
• Enter Add Alt text flow
• Try to scroll down to view image

What happens:

• You can't scroll to see full image initially
• If you minimize the half sheet, then bring it back, you can scroll
• See behavior starting at 1:29: https://drive.google.com/file/d/1r5SphsyjzHiZdtmavAkvDU7bf-JquRE-/view?usp=sharing

Expected behavior

• Scrolling to view entire image works initially

@HNordeenWMF Looking at this now!

Update from sync: @HNordeenWMF will make https://phabricator.wikimedia.org/T370231#10053106 a separate bug task. I made some progress on it in branch T370231-3. It is reproducible when posting an edit to production (so when there is an actual image to scroll to). I think it is related to lazy loading of the image.

It looks good for me on 7.5.8 (3979)